All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Vikash Garodia" <vikash.garodia@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
	media-ci@linuxtv.org
Subject: Re: [PATCH v7 05/12] media: iris: Route buffers to the matching context bank device
Date: Fri, 20 Nov 2026 11:28:18 +0000	[thread overview]
Message-ID: <sashiko-outbox-225041@kernel.org> (raw)
In-Reply-To: <20261120-vpu_iommu_iova_handling-v7-5-25a771235a7f@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] media: iris: commit message misclassifies SCRATCH_1 and omits
  HFI queue routing
--

commit bcf470fe5bd4c987e0c348301754ebc9faa2c5af
Author: Vikash Garodia <vikash.garodia@oss.qualcomm.com>

media: iris: Route buffers to the matching context bank device

This commit introduces iris_get_cb_dev() to route V4L2, internal, and HFI
queue DMA allocations to the matching pixel or non-pixel context bank
device, falling back to core->dev when context bank devices are absent.

> Add iris_get_cb_dev(), which maps a buffer type to the owning context
> bank device. Bitstream and internal buffers (BIN, ARP, COMV, LINE,
> NON_COMV, PERSIST) belong to the non-pixel device, and uncompressed
> buffers (DPB, PARTIAL, SCRATCH_1, SCRATCH_2, VPSS) to the pixel device.

[Severity: Low]
This isn't a bug, but the commit message lists SCRATCH_1 under the pixel
device whereas iris_get_cb_dev() routes BUF_SCRATCH_1 (the combined COMV,
NON_COMV, and LINE internal buffer) to core->np_dev.  The commit message
also omits mentioning that iris_hfi_queues_init() and
iris_hfi_queues_deinit() are updated to allocate the HFI queue table and
SFR buffers from core->np_dev.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-vpu_iommu_iova_handling-v7-0-25a771235a7f@oss.qualcomm.com?part=5

  reply	other threads:[~2026-11-20 11:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 11:10 [PATCH v7 00/12] media: iris: Migrate iommus to iris sub nodes Vikash Garodia
2026-11-20 11:10 ` [PATCH v7 01/12] dt-bindings: media: qcom,venus: Add context bank subnodes to common schema Vikash Garodia
2026-11-20 11:10 ` [PATCH v7 02/12] dt-bindings: media: qcom,sm8550-iris: Add context bank subnodes Vikash Garodia
2026-11-20 11:10 ` [PATCH v7 03/12] dt-bindings: media: qcom,sm8750-iris: " Vikash Garodia
2026-11-20 11:10 ` [PATCH v7 04/12] media: iris: Add non-pixel and pixel context bank devices Vikash Garodia
2026-11-20 11:10 ` [PATCH v7 05/12] media: iris: Route buffers to the matching context bank device Vikash Garodia
2026-11-20 11:28   ` sashiko-bot [this message]
2026-11-20 11:10 ` [PATCH v7 06/12] media: iris: Skip DMA mask setup when the core device has no IOMMU Vikash Garodia
2026-11-20 11:10 ` [PATCH v7 07/12] arm64: dts: qcom: hamoa: Add Iris context bank subnodes Vikash Garodia
2026-11-20 11:10 ` [PATCH v7 08/12] arm64: dts: qcom: sm8550: " Vikash Garodia
2026-11-20 11:10 ` [PATCH v7 09/12] arm64: dts: qcom: lemans: " Vikash Garodia
2026-11-20 11:11 ` [PATCH v7 10/12] arm64: dts: qcom: monaco: " Vikash Garodia
2026-11-20 11:11 ` [PATCH v7 11/12] arm64: dts: qcom: sm8650: " Vikash Garodia
2026-11-20 11:11 ` [PATCH v7 12/12] arm64: dts: qcom: sm8750: " Vikash Garodia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-225041@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=media-ci@linuxtv.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vikash.garodia@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.