All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: MidG971 <midgy971@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: rk3568-rock-3b: describe the Ethernet PHY LEDs
Date: Fri, 20 Nov 2026 11:46:52 +0000	[thread overview]
Message-ID: <sashiko-outbox-225096@kernel.org> (raw)
In-Reply-To: <20261120113555.1402132-1-midgy971@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: rockchip: under-indented leds nodes in
  rk3568-rock-3b.dts
--

commit 0800df3a997571bcce7adee9bf91cb1d76d2c711
Author: Midgy BALON <midgy971@gmail.com>

arm64: dts: rockchip: rk3568-rock-3b: describe the Ethernet PHY LEDs

This commit adds leds child subnodes to the rgmii_phy0 and rgmii_phy1
Ethernet PHY nodes on the Radxa ROCK 3B to describe the amber and green
RJ45 jack LEDs.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts b/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts
> index b9f09087b1766..5fb8b9e9b104b 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-rock-3b.dts
> @@ -580,6 +580,22 @@ rgmii_phy0: ethernet-phy@1 {
>  		reset-assert-us = <20000>;
>  		reset-deassert-us = <50000>;
>  		reset-gpios = <&gpio3 RK_PB7 GPIO_ACTIVE_LOW>;
> +	leds {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		led@0 {
> +			reg = <0>;
> +			color = <LED_COLOR_ID_AMBER>;
> +			function = LED_FUNCTION_LAN;
> +		};
> +
> +		led@1 {
> +			reg = <1>;
> +			color = <LED_COLOR_ID_GREEN>;
> +			function = LED_FUNCTION_LAN;
> +		};
> +	};
>  	};
>  };
>  
> @@ -590,6 +606,22 @@ rgmii_phy1: ethernet-phy@1 {
>  		reset-assert-us = <20000>;
>  		reset-deassert-us = <50000>;
>  		reset-gpios = <&gpio3 RK_PB0 GPIO_ACTIVE_LOW>;
> +	leds {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		led@0 {
> +			reg = <0>;
> +			color = <LED_COLOR_ID_AMBER>;
> +			function = LED_FUNCTION_LAN;
> +		};
> +
> +		led@1 {
> +			reg = <1>;
> +			color = <LED_COLOR_ID_GREEN>;
> +			function = LED_FUNCTION_LAN;
> +		};
> +	};
>  	};
>  };

[Severity: Low]
This isn't a bug, but both leds child subnodes in rgmii_phy0 and
rgmii_phy1 are indented by one tab instead of two (aligning with the
enclosing ethernet-phy@1 nodes) and lack a blank line after reset-gpios,
contrary to Documentation/devicetree/bindings/dts-coding-style.rst.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120113555.1402132-1-midgy971@gmail.com?part=1

  reply	other threads:[~2026-11-20 11:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 11:35 [PATCH] arm64: dts: rockchip: rk3568-rock-3b: describe the Ethernet PHY LEDs MidG971
2026-11-20 11:35 ` MidG971
2026-11-20 11:46 ` sashiko-bot [this message]
2026-11-20 12:32 ` [PATCH v2] " MidG971
2026-11-20 12:32   ` MidG971

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-225096@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=midgy971@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.