All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
	"David Hildenbrand" <david@kernel.org>,
	"Vlastimil Babka" <vbabka@kernel.org>,
	"Brendan Jackman" <jackmanb@google.com>,
	"Michal Hocko" <mhocko@suse.com>,
	"Suren Baghdasaryan" <surenb@google.com>,
	"Jason Wang" <jasowang@redhat.com>,
	"Andrea Arcangeli" <aarcange@redhat.com>,
	"Dev Jain" <dev.jain@arm.com>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Greg Ungerer" <gerg@linux-m68k.org>,
	"Gregory Price" <gourry@gourry.net>,
	"Huang, Ying" <ying.huang@linux.alibaba.com>,
	"Lance Yang" <lance.yang@linux.dev>,
	"Lorenzo Stoakes" <ljs@kernel.org>,
	"Magnus Lindholm" <linmag7@gmail.com>,
	"Matthew Wilcox" <willy@infradead.org>,
	"Miaohe Lin" <linmiaohe@huawei.com>, "Zi Yan" <ziy@nvidia.com>,
	linux-mm@kvack.org, virtualization@lists.linux.dev,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Brendan Jackman" <brendan.jackman@linux.dev>,
	"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH v11 7/7] mm: page_reporting: add flush parameter with page budget
Date: Fri, 20 Nov 2026 12:03:31 +0000	[thread overview]
Message-ID: <sashiko-outbox-225116@kernel.org> (raw)
In-Reply-To: <2d518dd7b8f7be147b9a957ad94f6c6641e4b5ef.1795089715.git.mst@redhat.com>

Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [Medium] mm: page_reporting: redundant work flush in
  page_reporting_flush_set()
- [Medium] mm: page_reporting: hardcoded capacity in
  page_reporting_flush_set()
- [Low] mm: page_reporting: unused variable and get op for write-only
  flush param
--

commit 18e2a422153fdecadcaa01e59911f68043266f81
Author: Michael S. Tsirkin <mst@redhat.com>

mm: page_reporting: add flush parameter with page budget

This commit adds a write-only "flush" module parameter to trigger
immediate page reporting up to an approximate page budget.

> diff --git a/mm/page_reporting.c b/mm/page_reporting.c
> index 841dcd64777d1..74c03844fc3e9 100644
> --- a/mm/page_reporting.c
> +++ b/mm/page_reporting.c
> @@ -360,6 +360,46 @@ static void page_reporting_process(struct work_struct *work)
>  static DEFINE_MUTEX(page_reporting_mutex);
>  DEFINE_STATIC_KEY_FALSE(page_reporting_enabled);
>  
> +static int page_reporting_flush_set(const char *val,
> +				    const struct kernel_param *kp)
> +{
> +	struct page_reporting_dev_info *prdev;
> +	unsigned int budget;
> +	int err;
> +
> +	err = kstrtouint(val, 0, &budget);
> +	if (err)
> +		return err;
> +	if (!budget)
> +		return 0;
> +
> +	mutex_lock(&page_reporting_mutex);
> +	prdev = rcu_dereference_protected(pr_dev_info,
> +				lockdep_is_held(&page_reporting_mutex));
> +	if (prdev) {
> +		while (budget) {
> +			budget -= min(budget, PAGE_REPORTING_CAPACITY);

[Severity: Medium]
Should this decrement budget by prdev->capacity instead of
PAGE_REPORTING_CAPACITY?  A driver can register with a smaller
prdev->capacity than PAGE_REPORTING_CAPACITY, which is what
page_reporting_process() uses to size each batch, so using
PAGE_REPORTING_CAPACITY exhausts the requested budget too early.

> +			flush_delayed_work(&prdev->work);
> +			__page_reporting_request(prdev);
> +			flush_delayed_work(&prdev->work);
> +			if (atomic_read(&prdev->state) == PAGE_REPORTING_IDLE)
> +				break;

[Severity: Medium]
Does calling flush_delayed_work(&prdev->work) both before and after
__page_reporting_request(prdev) inside the loop run two reporting passes
per iteration and an extra pass after all pages are reported?

When page_reporting_process() finishes a pass with more pages left to
report, it already re-schedules prdev->work before returning:

mm/page_reporting.c:page_reporting_process() {
    ...
	state = atomic_cmpxchg(&prdev->state, state, PAGE_REPORTING_IDLE);
	if (state == PAGE_REPORTING_REQUESTED)
		page_reporting_schedule_work(prdev);
}

Whenever prdev->work is already queued (including every iteration after
the first), the first flush_delayed_work() runs a full reporting pass.  If
that pass finishes all remaining pages and sets prdev->state to
PAGE_REPORTING_IDLE, __page_reporting_request() immediately transitions
prdev->state back to PAGE_REPORTING_REQUESTED and queues another pass that
the second flush_delayed_work() executes across all zones.  If unreported
pages remain after the first flush, page_reporting_process() has already
queued prdev->work again, so the second flush_delayed_work() runs a second
full pass in the same iteration while only decrementing budget once.

> +			if (signal_pending(current))
> +				break;
> +		}
> +	}
> +	mutex_unlock(&page_reporting_mutex);
> +	return 0;
> +}
> +
> +static const struct kernel_param_ops flush_ops = {
> +	.set = page_reporting_flush_set,
> +	.get = param_get_uint,
> +};
> +static unsigned int page_reporting_flush;
> +module_param_cb(flush, &flush_ops, &page_reporting_flush, 0200);

[Severity: Low]
Since flush is a write-only parameter and page_reporting_flush_set() never
touches page_reporting_flush, should flush_ops.get and
page_reporting_flush be dropped (passing NULL to module_param_cb()) so
param_attr_show() returns -EPERM if the sysfs mode is changed?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1795089715.git.mst@redhat.com?part=7

      reply	other threads:[~2026-11-20 12:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 12:02 [PATCH v11 0/7] mm/virtio: skip redundant zeroing of host-zeroed reported pages Michael S. Tsirkin
2026-11-19 12:02 ` [PATCH v11 1/7] mm: add PG_zeroed page flag and buddy merge tracking Michael S. Tsirkin
2026-11-20 12:03   ` sashiko-bot
2026-11-19 12:02 ` [PATCH v11 2/7] mm: page_reporting: support host-zeroed reported pages Michael S. Tsirkin
2026-11-20 12:03   ` sashiko-bot
2026-11-19 12:02 ` [PATCH v11 3/7] mm: skip zeroing in vma_alloc_anon_folio_pmd for pre-zeroed pages Michael S. Tsirkin
2026-11-20 12:03   ` sashiko-bot
2026-11-19 12:02 ` [PATCH v11 4/7] mm: skip zeroing of pre-zeroed order-0 user pages Michael S. Tsirkin
2026-11-20 12:03   ` sashiko-bot
2026-11-19 12:02 ` [PATCH v11 5/7] mm: skip zeroing in alloc_anon_folio for pre-zeroed pages Michael S. Tsirkin
2026-11-20 12:03   ` sashiko-bot
2026-11-19 12:02 ` [PATCH v11 6/7] virtio_balloon: add DEVICE_INIT_REPORTED feature Michael S. Tsirkin
2026-11-20 12:03   ` sashiko-bot
2026-11-19 12:03 ` [PATCH v11 7/7] mm: page_reporting: add flush parameter with page budget Michael S. Tsirkin
2026-11-20 12:03   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-225116@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=brendan.jackman@linux.dev \
    --cc=david@kernel.org \
    --cc=dev.jain@arm.com \
    --cc=eperezma@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=gerg@linux-m68k.org \
    --cc=gourry@gourry.net \
    --cc=hannes@cmpxchg.org \
    --cc=jackmanb@google.com \
    --cc=jasowang@redhat.com \
    --cc=lance.yang@linux.dev \
    --cc=linmag7@gmail.com \
    --cc=linmiaohe@huawei.com \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=mst@redhat.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    --cc=virtualization@lists.linux.dev \
    --cc=willy@infradead.org \
    --cc=ying.huang@linux.alibaba.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.