From: sashiko-bot@kernel.org
To: tilak.tirumalesh.tangudu@intel.com, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 1/4] drm/xe: Add has_sem64 bit to graphics/media IP descriptors
Date: Fri, 20 Nov 2026 12:23:10 +0000 [thread overview]
Message-ID: <sashiko-outbox-225139@kernel.org> (raw)
In-Reply-To: <20261120120231.748267-2-tilak.tirumalesh.tangudu@intel.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/xe: missing has_sem64 in graphics_xe3p_xpc disables sem64
on 35.11/35.03
--
commit a3b281833b67c5a6ce1acdb4fe1005d2dea0dadd
Author: Tangudu Tilak Tirumalesh <tilak.tirumalesh.tangudu@intel.com>
drm/xe: Add has_sem64 bit to graphics/media IP descriptors
This commit adds a has_sem64 capability flag to the graphics and media IP
descriptors for Xe3p platforms and resolves gt->info.has_sem64 during GT
initialization, clearing it on both GTs if the primary and media GTs
disagree.
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index 3bd68ed9daa81..a7ceb570d89af 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -127,6 +127,7 @@ static const struct xe_graphics_desc graphics_xe3p_lpg = {
> .multi_queue_engine_class_mask = BIT(XE_ENGINE_CLASS_COPY) | BIT(XE_ENGINE_CLASS_COMPUTE),
> .num_geometry_xecore_fuse_regs = 3,
> .num_compute_xecore_fuse_regs = 3,
> + .has_sem64 = 1,
> };
>
> static const struct xe_graphics_desc graphics_xe3p_xpc = {
> @@ -153,11 +154,20 @@ static const struct xe_media_desc media_xelpmp = {
> .hw_engine_mask =
> GENMASK(XE_HW_ENGINE_VCS7, XE_HW_ENGINE_VCS0) |
> GENMASK(XE_HW_ENGINE_VECS3, XE_HW_ENGINE_VECS0) |
> - BIT(XE_HW_ENGINE_GSCCS0)
> + BIT(XE_HW_ENGINE_GSCCS0),
> +};
> +
> +static const struct xe_media_desc media_xe3p_lpm = {
> + .hw_engine_mask =
> + GENMASK(XE_HW_ENGINE_VCS7, XE_HW_ENGINE_VCS0) |
> + GENMASK(XE_HW_ENGINE_VECS3, XE_HW_ENGINE_VECS0) |
> + BIT(XE_HW_ENGINE_GSCCS0),
> + .has_sem64 = 1,
> };
>
> static const struct xe_media_desc media_xe3p_hpm = {
> .has_uncorrectable_error_reporting = 1,
> + .has_sem64 = 1,
[Severity: Medium]
Should graphics_xe3p_xpc (Graphics IP 35.11) also set .has_sem64 = 1?
In alloc_primary_gt(), the stepping check is scoped to
GRAPHICS_VERx100(xe) == 3510, matching MEDIA_VERx100(xe) == 3500 in
alloc_media_gt(). Because graphics_xe3p_xpc omits .has_sem64 = 1,
tile->primary_gt->info.has_sem64 is always false on Graphics IP 35.11, and
the cross-GT check in xe_info_init() then clears
tile->media_gt->info.has_sem64 back to false on the paired Media IP 35.03
(media_xe3p_hpm) GT as well.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120120231.748267-1-tilak.tirumalesh.tangudu@intel.com?part=1
next prev parent reply other threads:[~2026-11-20 12:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 12:02 [PATCH 0/4] drm/xe: Use MI_SEMAPHORE_WAIT_64 (Wa_16029281913) tilak.tirumalesh.tangudu
2026-11-20 12:02 ` [PATCH 1/4] drm/xe: Add has_sem64 bit to graphics/media IP descriptors tilak.tirumalesh.tangudu
2026-11-20 12:23 ` sashiko-bot [this message]
2026-11-20 12:45 ` Tangudu, Tilak Tirumalesh
2026-11-20 12:02 ` [PATCH 2/4] drm/xe: Add MI_SEMAPHORE_WAIT_64 instruction definition tilak.tirumalesh.tangudu
2026-11-20 12:02 ` [PATCH 3/4] drm/xe: Use MI_SEMAPHORE_WAIT_64 for fake watchdog where supported tilak.tirumalesh.tangudu
2026-11-20 12:18 ` K V P, Satyanarayana
2026-11-20 12:02 ` [PATCH 4/4] drm/xe: Use MI_SEMAPHORE_WAIT_64 in ULLS postamble " tilak.tirumalesh.tangudu
2026-11-20 12:17 ` ✗ CI.checkpatch: warning for drm/xe: Use MI_SEMAPHORE_WAIT_64 (Wa_16029281913) (rev4) Patchwork
2026-11-20 12:19 ` ✓ CI.KUnit: success " Patchwork
2026-11-20 12:54 ` ✓ Xe.CI.BAT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2026-11-13 15:57 [PATCH 0/4] drm/xe: Use MI_SEMAPHORE_WAIT_64 (Wa_16029281913) tilak.tirumalesh.tangudu
2026-11-13 15:57 ` [PATCH 1/4] drm/xe: Add has_sem64 bit to graphics/media IP descriptors tilak.tirumalesh.tangudu
2026-11-13 16:20 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-225139@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tilak.tirumalesh.tangudu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.