All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Bibek Kumar Patro" <bibek.patro@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH RESEND v4 04/20] arm64: dts: qcom: lemans: Add GEM_NOC interconnect for adreno SMMU
Date: Fri, 20 Nov 2026 13:56:33 +0000	[thread overview]
Message-ID: <sashiko-outbox-225305@kernel.org> (raw)
In-Reply-To: <20261120-smmu_interconnect_addition-v4-4-be30526391d9@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: lemans: adreno_smmu interconnects placed in
  lemans.dtsi
--

commit 69c1b90a142a42fba13058e11d6ad8fe981b319c
Author: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>

arm64: dts: qcom: lemans: Add GEM_NOC interconnect for adreno SMMU

This commit adds the GEM_NOC interconnect property to the adreno_smmu node
in lemans.dtsi.

> diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qcom/lemans.dtsi
> index 20f329c0df751..be71eb30f9979 100644
> --- a/arch/arm64/boot/dts/qcom/lemans.dtsi
> +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi
> @@ -3127,6 +3127,8 @@ adreno_smmu: iommu@3da0000 {
>  				     <GIC_SPI 685 IRQ_TYPE_LEVEL_HIGH>,
>  				     <GIC_SPI 686 IRQ_TYPE_LEVEL_HIGH>,
>  				     <GIC_SPI 687 IRQ_TYPE_LEVEL_HIGH>;
> +			interconnects = <&gem_noc MASTER_GPU_TCU QCOM_ICC_TAG_ALWAYS
> +					 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
>  		};

[Severity: High]
Should interconnects be placed under &adreno_smmu in lemans-embedded.dtsi
instead of lemans.dtsi?

Commit 1f90a2bab7f6 ("arm64: dts: qcom: lemans: Move platform resources
into lemans-embedded.dtsi") moved the interconnect dt-binding headers, the
gem_noc and mc_virt provider nodes, and &adreno_smmu's power-domains and
clocks out of lemans.dtsi into lemans-embedded.dtsi.  Adding this property
to lemans.dtsi breaks building any target that includes lemans-gearvm.dtsi
(added in commit c1ef028799fc ("arm64: dts: qcom: Add device tree for
Lemans GearVM variant")), because neither lemans.dtsi nor
lemans-gearvm.dtsi includes the interconnect headers or defines &gem_noc
and &mc_virt.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-smmu_interconnect_addition-v4-0-be30526391d9@oss.qualcomm.com?part=4

  reply	other threads:[~2026-11-20 13:56 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 13:41 [PATCH RESEND v4 00/20] iommu/arm-smmu: Add interconnect bandwidth voting support Bibek Kumar Patro
2026-11-20 13:41 ` [PATCH RESEND v4 01/20] dt-bindings: iommu: arm,smmu: Document interconnects property Bibek Kumar Patro
2026-11-20 13:41 ` [PATCH RESEND v4 02/20] iommu/arm-smmu: Add interconnect bandwidth voting support Bibek Kumar Patro
2026-11-20 13:59   ` sashiko-bot
2026-11-20 13:41 ` [PATCH RESEND v4 03/20] arm64: dts: qcom: kodiak: Add GEM_NOC interconnect for adreno SMMU Bibek Kumar Patro
2026-11-20 13:41 ` [PATCH RESEND v4 04/20] arm64: dts: qcom: lemans: " Bibek Kumar Patro
2026-11-20 13:56   ` sashiko-bot [this message]
2026-11-20 13:41 ` [PATCH RESEND v4 05/20] arm64: dts: qcom: monaco: " Bibek Kumar Patro
2026-11-20 13:41 ` [PATCH RESEND v4 06/20] arm64: dts: qcom: talos: " Bibek Kumar Patro
2026-11-20 13:41 ` [PATCH RESEND v4 07/20] arm64: dts: qcom: sm8150: " Bibek Kumar Patro
2026-11-20 13:41 ` [PATCH RESEND v4 08/20] arm64: dts: qcom: sm8250: " Bibek Kumar Patro
2026-11-20 13:41 ` [PATCH RESEND v4 09/20] arm64: dts: qcom: sm8350: " Bibek Kumar Patro
2026-11-20 13:41 ` [PATCH RESEND v4 10/20] arm64: dts: qcom: sc8180x: " Bibek Kumar Patro
2026-11-20 13:41 ` [PATCH RESEND v4 11/20] arm64: dts: qcom: sc8280xp: " Bibek Kumar Patro
2026-11-20 13:41 ` [PATCH RESEND v4 12/20] arm64: dts: qcom: sm8450: " Bibek Kumar Patro
2026-11-20 13:41 ` [PATCH RESEND v4 13/20] arm64: dts: qcom: sm8550: " Bibek Kumar Patro
2026-11-20 13:41 ` [PATCH RESEND v4 14/20] arm64: dts: qcom: sm8650: " Bibek Kumar Patro
2026-11-20 13:41 ` [PATCH RESEND v4 15/20] arm64: dts: qcom: hamoa: " Bibek Kumar Patro
2026-11-20 13:41 ` [PATCH RESEND v4 16/20] arm64: dts: qcom: kaanapali: " Bibek Kumar Patro
2026-11-20 13:41 ` [PATCH RESEND v4 17/20] arm64: dts: qcom: glymur: Add HSC_NOC " Bibek Kumar Patro
2026-11-20 13:41 ` [PATCH RESEND v4 18/20] arm64: dts: qcom: milos: Add GEM_NOC " Bibek Kumar Patro
2026-11-20 13:41 ` [PATCH RESEND v4 19/20] arm64: dts: qcom: hawi: " Bibek Kumar Patro
2026-11-20 13:41 ` [PATCH RESEND v4 20/20] arm64: dts: qcom: sar2130p: " Bibek Kumar Patro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-225305@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=bibek.patro@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.