From: sashiko-bot@kernel.org
To: "Charles Keepax" <ckeepax@opensource.cirrus.com>
Cc: linux-sound@vger.kernel.org, mfd@lists.linux.dev, lee@kernel.org
Subject: Re: [PATCH] mfd: cs42l43: Stop using legacy SoundWire IRQ callback
Date: Fri, 20 Nov 2026 14:10:00 +0000 [thread overview]
Message-ID: <sashiko-outbox-225329@kernel.org> (raw)
In-Reply-To: <20261120135626.2004361-1-ckeepax@opensource.cirrus.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] mfd: cs42l43: missing Fixes trailer for SoundWire alert clearing
fix
- [Low] mfd: cs42l43: trailing commas instead of semicolons in
cs42l43_irq_config()
--
commit 1dac89cd53b087ddddba16f33e5c9fbd6eb8fbc3
Author: Charles Keepax <ckeepax@opensource.cirrus.com>
> mfd: cs42l43: Stop using legacy SoundWire IRQ callback
>
> When removing the cs42l43 driver on SoundWire the core will warn of
> too many retries on the SoundWire alert. This is caused by the use
> of the legacy SoundWire IRQ callback to clear INT_STAT_GEN1. This
> implementation defined SoundWire alert bit is used to tie the cs42l43
> internal interrupts into the SoundWire alert mechanism. However,
> the legacy SoundWire IRQ callback is gated by the probed flag inside
> the core and that is cleared before the driver's remove callback
> is called. This means that any IRQs triggered during the driver
> remove process will not clear INT_STAT_GEN1 leading to the device
> being stuck in the alert state until it is removed from the bus.
>
> To fix this issue handling is moved to the regmap IRQ handle_post_irq
> callback which ensures that INT_STAT_GEN1 will be cleared right up
> until the IRQ itself is cleaned up.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
[Severity: Low]
This fixes a bug where CS42L43_GEN_INT_STAT_1 is not cleared during SoundWire
driver removal. Should this include:
Fixes: ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
> diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c
> index a83b62064dae6..d36628e8dc279 100644
> --- a/drivers/mfd/cs42l43.c
> +++ b/drivers/mfd/cs42l43.c
[ ... ]
> @@ -917,7 +904,14 @@ static int cs42l43_irq_config(struct cs42l43 *cs42l43)
> if (cs42l43->sdw)
> cs42l43->irq = cs42l43->sdw->irq;
>
> - cs42l43->irq_chip = cs42l43_irq_chip;
> + /* Manually fill so extra settings from bus are preserved */
> + cs42l43->irq_chip.name = "cs42l43",
> + cs42l43->irq_chip.status_base = CS42L43_DECIM_INT,
> + cs42l43->irq_chip.mask_base = CS42L43_DECIM_MASK,
> + cs42l43->irq_chip.num_regs = 16,
> + cs42l43->irq_chip.irqs = cs42l43_regmap_irqs,
> + cs42l43->irq_chip.num_irqs = ARRAY_SIZE(cs42l43_regmap_irqs),
> + cs42l43->irq_chip.runtime_pm = true,
> cs42l43->irq_chip.irq_drv_data = cs42l43;
[Severity: Low]
The new cs42l43->irq_chip field assignments end with commas instead of
semicolons, chaining them into a single comma-operator expression and
triggering -Wcomma warnings.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120135626.2004361-1-ckeepax@opensource.cirrus.com?part=1
prev parent reply other threads:[~2026-11-20 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 13:56 [PATCH] mfd: cs42l43: Stop using legacy SoundWire IRQ callback Charles Keepax
2026-11-20 14:10 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-225329@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lee@kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mfd@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.