All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Shitalkumar Gandhi" <shital.gandhi45@gmail.com>,
	intel-wired-lan@lists.osuosl.org
Cc: bpf@vger.kernel.org
Subject: Re: [PATCH iwl-next 1/2] i40e: wait for one RCU grace period in i40e_down(), not one per queue
Date: Fri, 20 Nov 2026 15:17:31 +0000	[thread overview]
Message-ID: <sashiko-outbox-225447@kernel.org> (raw)
In-Reply-To: <20261120150527.14649-2-shital.gandhi45@gmail.com>

Thank you for your contribution! Sashiko AI review found no new issues
in this patch, but noticed 1 related pre-existing issue it does not
introduce:
- [High] i40e: unpaired napi_disable() in i40e_vsi_open() [1]
--

commit e3081b5b3e5283a7fdd835e0d6be52ee866385e0
Author: Shitalkumar Gandhi <shital.gandhi45@gmail.com>

i40e: wait for one RCU grace period in i40e_down(), not one per queue

This commit moves the RCU wait in i40e_down() out of the per-queue loop
and replaces synchronize_rcu() with a single synchronize_net() call when
XDP is enabled.

> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
> index 98d2fcdcee68f..e0c76ba566ea5 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> @@ -7609,15 +7609,18 @@ void i40e_down(struct i40e_vsi *vsi)
>  		i40e_force_link_state(vsi->back, false);
>  	i40e_napi_disable_all(vsi);

[Severity: High]
This problem wasn't introduced by this patch, but can
i40e_napi_disable_all() hang here when i40e_vsi_open() fails in
i40e_up_complete() [1]?

If i40e_vsi_start_rings() fails in i40e_up_complete(), it returns before
i40e_napi_enable_all() runs:

drivers/net/ethernet/intel/i40e/i40e_main.c:i40e_up_complete() {
	...
	err = i40e_vsi_start_rings(vsi);
	if (err)
		return err;

	clear_bit(__I40E_VSI_DOWN, vsi->state);
	i40e_napi_enable_all(vsi);
	...
}

The err_up_complete error path in i40e_vsi_open() then calls i40e_down() ->
i40e_napi_disable_all() -> napi_disable() on NAPI instances where
NAPIF_STATE_SCHED and NAPIF_STATE_NPSVC were never cleared by
napi_enable(), sleeping forever while holding rtnl_lock().

[1] https://sashiko.dev/#/bug/linux-f4bedeae-9add-4cf7-9ab5-6f1f169023a5

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120150527.14649-1-shital.gandhi45@gmail.com?part=1

  reply	other threads:[~2026-11-20 15:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 15:05 [PATCH iwl-next 0/2] i40e, ice: one RCU grace period per XDP ring teardown Shitalkumar Gandhi
2026-11-20 15:05 ` [PATCH iwl-next 1/2] i40e: wait for one RCU grace period in i40e_down(), not one per queue Shitalkumar Gandhi
2026-11-20 15:17   ` sashiko-bot [this message]
2026-11-20 15:05 ` [PATCH iwl-next 2/2] ice: wait for one RCU grace period when destroying XDP rings Shitalkumar Gandhi
2026-11-20 15:13   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-225447@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=shital.gandhi45@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.