From: sashiko-bot@kernel.org
To: "Rodrigo Vivi" <rodrigo.vivi@intel.com>, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH] drm/xe/hwmon: Unregister hwmon before the device is unplugged
Date: Fri, 20 Nov 2026 15:38:13 +0000 [thread overview]
Message-ID: <sashiko-outbox-225473@kernel.org> (raw)
In-Reply-To: <20261120152753.1346010-2-rodrigo.vivi@intel.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/xe/hwmon: missing Fixes trailer for devm hwmon unplug race
fix
--
commit 665f57d7a31cd2bcb2429c94c413e7551d488e30
Author: Rodrigo Vivi <rodrigo.vivi@intel.com>
> drm/xe/hwmon: Unregister hwmon before the device is unplugged
>
> hwmon was registered with devm, so its sysfs attributes stayed
> reachable after drm_dev_unplug() until devres teardown. A reader in
> that window accesses an unplugged device, e.g. the PMT energy read
> on BMG.
>
> Unregister it explicitly in xe_device_remove() and in the probe error
> path, before the device is unplugged. Removing the attributes waits
> for in-flight reads, so none can run afterwards.
>
> Cc: Karthik Poosa <karthik.poosa@intel.com>
> Cc: Michael J. Ruhl <michael.j.ruhl@intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
[Severity: Low]
This fixes a device unplug race where hwmon attributes stay reachable
after drm_dev_unplug(). Should it include a Fixes tag for the commit
that introduced devm_hwmon_device_register_with_info() in
xe_hwmon_register()?
Fixes: fb1b70607f73 ("drm/xe/hwmon: Expose power attributes")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120152753.1346010-2-rodrigo.vivi@intel.com?part=1
next prev parent reply other threads:[~2026-11-20 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 15:27 [PATCH] drm/xe/hwmon: Unregister hwmon before the device is unplugged Rodrigo Vivi
2026-11-20 15:37 ` ✓ CI.KUnit: success for " Patchwork
2026-11-20 15:38 ` sashiko-bot [this message]
2026-11-20 16:10 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-20 16:25 ` [PATCH] " Ruhl, Michael J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-225473@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.