From: sashiko-bot@kernel.org
To: "Felix Gu" <ustc.gu@gmail.com>
Cc: linux-sunxi@lists.linux.dev
Subject: Re: [PATCH] spi: sun6i: Release TX DMA channel when RX is unavailable
Date: Fri, 20 Nov 2026 16:10:13 +0000 [thread overview]
Message-ID: <sashiko-outbox-225539@kernel.org> (raw)
In-Reply-To: <20261121-sun6i-v1-1-ce211aace0e8@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] spi: sun6i: missing Fixes trailer for commit 345980a3a5e5
--
commit a53da7aef94b96fc56cacd8a1daf4ca007f993f9
Author: Felix Gu <ustc.gu@gmail.com>
> spi: sun6i: Release TX DMA channel when RX is unavailable
>
> If requesting the RX DMA channel fails, the controller falls back to PIO
> because DMA is enabled only when both channels are available.
>
> Release the TX channel acquired earlier so it is not held unused until
> driver removal
>
> Signed-off-by: Felix Gu <ustc.gu@gmail.com>
[Severity: Low]
This fixes the PIO fallback path in sun6i_spi_probe(). Should this
include:
Fixes: 345980a3a5e5 ("spi: spi-sun6i: implement DMA-based transfer mode")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261121-sun6i-v1-1-ce211aace0e8@gmail.com?part=1
prev parent reply other threads:[~2026-11-20 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 16:05 [PATCH] spi: sun6i: Release TX DMA channel when RX is unavailable Felix Gu
2026-11-20 16:10 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-225539@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=sashiko-reviews@lists.linux.dev \
--cc=ustc.gu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.