All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Asaf Nuri Bertizlioğlu" <asafbertizlioglu@gmail.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (coretemp) Remove unused for_each_sibling() and name_attr
Date: Fri, 20 Nov 2026 17:02:23 +0000	[thread overview]
Message-ID: <sashiko-outbox-225616@kernel.org> (raw)
In-Reply-To: <20261120165926.579575-1-asafbertizlioglu@gmail.com>

> The for_each_sibling() macro lost its only user in commit
> e1b370b64031 ("hwmon: (coretemp) Simplify sibling management").
> 
> The name_attr member of struct platform_data has been unused since
> commit d72d19c26c41 ("hwmon: (coretemp) Convert to use
> devm_hwmon_device_register_with_groups"), which left the "name"
> attribute to the hwmon core.
> 
> Remove both. No functional change.
> 
> Built with CONFIG_SMP=y and CONFIG_SMP=n at W=1 with no new
> warnings. Apart from the struct platform_data allocation size,
> which shrinks from 88 to 56 bytes, the generated code is unchanged.
> 
> The unused definitions were found with an LLM-based coding assistant,
> which also drafted this changelog. Both findings were confirmed with
> gcc -Wunused-macros, git grep and the git history.
> 
> Signed-off-by: Asaf Nuri Bertizlioğlu <asafbertizlioglu@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120165926.579575-1-asafbertizlioglu@gmail.com?part=1


      reply	other threads:[~2026-11-20 17:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 16:59 [PATCH] hwmon: (coretemp) Remove unused for_each_sibling() and name_attr Asaf Nuri Bertizlioğlu
2026-11-20 17:02 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-225616@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=asafbertizlioglu@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.