From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56D4E60A263F for ; Fri, 20 Nov 2026 17:30:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=u3huD0yt; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Ak10GoM2 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=fm79jXC2lesiKe0qAbFUIQLJaP4qaiAPhsXd2Fgm2CQ=; b=u3huD0ytOYAqE0awVhvOr3FdFL +AO2AEhuUbZXqN/sTGNXvaOaWjMZJPs+pfhHMKPNH8FAxKFu2PFsTu15htpxC34/J/Hz+Wejt9via qaPLzwze6p2VX503yT+d1g/4LvN03SuD6R5LRRkPjxID7aejggwU1zdPws8XhcZwLJKyhX1dYVI6f Zrl3V5KVZNl08cK/Q0CCTqBst8EIyG2HxcSghG2S1ty0Qao2mhK2yaQF5VL8kW/KgBt+Y4xvpMg4B NfWQk/hK1bYABqrpjEiCWiedgsTujNNctcwkA2h/CsluGo+xiPZLN/BEln/x3kNEXTu3dG9+7F0rq H5+gC/cg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUSRQ-0000000Fhmi-45I9; Fri, 20 Nov 2026 17:30:29 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUSR7-0000000Fhd4-0T5e for linux-mtd@lists.infradead.org; Fri, 20 Nov 2026 17:30:14 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 6372E62C73; Fri, 20 Nov 2026 17:30:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 022061F000D1; Fri, 20 Nov 2026 17:30:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795195807; bh=7bQnDQQGsXh/GfQqynI9Dm1mxtj1RYtKX42i3WjK0mc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Ak10GoM21f09UMAhn9xS4VH3KYKUnQpdq4ly5HC3APsfU2fVM1lWOD9p10cFSqZLW AIFEA2iqY8/8f0EbuMkbTU/nfHjeT0lOkETNHBWnrSCju9p14KinKw4cDNpB569+4x 9D774GkyoqFCw4z4G0Dl545f+dXZKOhmkRZ9Ci0HdQA9ROgnoI0fa669aoWetma5kk Onlm74kHyq4n1tZKgmatH2HpN2U9PcYBKLOqV5QQOgQxL3kRVlQa2lVm/bb0/KbYHp JzjOsZfh+0qAtIpYwPkVxdAkdKC0SF3YRv29kNhd+UpEL66VeabmcUCxrXJTgOSast fEE+g7KOjKMHA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 10/11] mtd: spi-nand: Set the DQS spi-mem capability if available To: "Miquel Raynal" , "Mark Brown" , "Richard Weinberger" , "Vignesh Raghavendra" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Pratyush Yadav" , "Michael Walle" , "Takahiro Kuwano" Cc: "Thomas Petazzoni" , praneeth@ti.com, u-kumar1@ti.com, p-mantena@ti.com, a-dutta@ti.com, s-k6@ti.com, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org In-Reply-To: <20261120-winbond-nand-next-phy-tuning-v4-10-8c21e1f71f41@bootlin.com> References: <20261120-winbond-nand-next-phy-tuning-v4-0-8c21e1f71f41@bootlin.com> <20261120-winbond-nand-next-phy-tuning-v4-10-8c21e1f71f41@bootlin.com> Date: Fri, 20 Nov 2026 17:30:06 +0000 X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwKaXNzdWUgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gbXRkOiBzcGluYW5kOiBz cGlfbWVtX3NldF9kcXNfcGluX2F2YWlsYWJsZSgpIGNhbGxlZCBhZnRlcgogIFNTRFIgbmVnb3Rp YXRpb24KLS0KCmNvbW1pdCBkZWQxZjAxYjAwYTMzODM4M2VkNGU2MjIyOGY2YjQxNTg1NmM5ZGYz CkF1dGhvcjogTWlxdWVsIFJheW5hbCA8bWlxdWVsLnJheW5hbEBib290bGluLmNvbT4KCm10ZDog c3BpLW5hbmQ6IFNldCB0aGUgRFFTIHNwaS1tZW0gY2FwYWJpbGl0eSBpZiBhdmFpbGFibGUKClRo aXMgY29tbWl0IGFkZHMgdGhlIFNQSU5BTkRfSEFTX0RRUyBmbGFnIGFuZCBjYWxscwpzcGlfbWVt X3NldF9kcXNfcGluX2F2YWlsYWJsZSgpIGluIHNwaW5hbmRfbWF0Y2hfYW5kX2luaXQoKSB3aGVu IGEKbWF0Y2hlZCBTUEktTkFORCBjaGlwIHN1cHBvcnRzIERRUy4KCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvbXRkL25hbmQvc3BpL2NvcmUuYyBiL2RyaXZlcnMvbXRkL25hbmQvc3BpL2NvcmUuYwo+ IGluZGV4IGZlZTRhNDhiNGM3ZjMuLjZlMWI3OTc2ZDIzNzkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9tdGQvbmFuZC9zcGkvY29yZS5jCj4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9zcGkvY29yZS5j Cj4gQEAgLTE3OTcsNiArMTc5Nyw5IEBAIGludCBzcGluYW5kX21hdGNoX2FuZF9pbml0KHN0cnVj dCBzcGluYW5kX2RldmljZSAqc3BpbmFuZCwKPiAgCQkJfQo+ICAJCX0KPiAgCj4gKwkJaWYgKHNw aW5hbmQtPmZsYWdzICYgU1BJTkFORF9IQVNfRFFTKQo+ICsJCQlzcGlfbWVtX3NldF9kcXNfcGlu X2F2YWlsYWJsZShzcGluYW5kLT5zcGltZW0pOwo+ICsKPiAgCQkvKiBJL08gdmFyaWFudHMgc2Vs ZWN0aW9uIHdpdGggb2N0by1zcGkgRERSIGNvbW1hbmRzIChvcHRpb25hbCkgKi8KPiAgCj4gIAkJ cmV0ID0gc3BpbmFuZF9pbml0X29kdHJfaW5zdHJ1Y3Rpb25fc2V0KHNwaW5hbmQpOwoKW1NldmVy aXR5OiBNZWRpdW1dClNob3VsZCBzcGlfbWVtX3NldF9kcXNfcGluX2F2YWlsYWJsZSgpIGJlIGNh bGxlZCByaWdodCBhZnRlcgpzcGluYW5kLT5mbGFncyBpcyBpbml0aWFsaXplZCwgYmVmb3JlIFNT RFIgb3BlcmF0aW9uIHZhcmlhbnRzIGFyZQpzZWxlY3RlZD8KClBsYWNpbmcgaXQgaGVyZSBsZWF2 ZXMgc3BpbmFuZC0+c3BpbWVtLT5kcXNfcGluIGZhbHNlIHdoaWxlCnNwaW5hbmRfc2VsZWN0X29w X3ZhcmlhbnQoc3BpbmFuZCwgU1NEUiwgLi4uKSBhbmQKc3BpbmFuZF9zdXBwb3J0X3ZlbmRvcl9v cHMoc3BpbmFuZCwgaW5mbywgU1NEUikgcnVuLCB3aGljaCBhbHNvIGV2YWx1YXRlCjFTLWNvbW1h bmQgRFRSIHJlYWQgdmFyaWFudHMgc3VjaCBhcwpTUElOQU5EX1BBR0VfUkVBRF9GUk9NX0NBQ0hF XzFTXzFEXzhEX09QLgoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5k ZXYvIy9wYXRjaHNldC8yMDI2MTEyMC13aW5ib25kLW5hbmQtbmV4dC1waHktdHVuaW5nLXY0LTAt OGMyMWUxZjcxZjQxQGJvb3RsaW4uY29tP3BhcnQ9MTAKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBtYWls aW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795195808; b=BVpOM40ZLM9Rc0VxO62TdQojhrppYVnZDgESPeaTrvBqs3a7PYUzHkhH0ZT63BmYq+LF 7phIOAuPcRJh86KM3Twmh7L7D7j3ZQaBnMi/VNcxlhs0eSiFgNDxaIu7/+QjrTFi1c2Ea VzumsRqK4nMpEaXbx1uLhNmZslWytfuo2/kEVlw/EVatjru9NPDrEXuH0uASxYm5X4p4J R0wBKGZDssxBaR8Oy6opWRJnlqsnsQh/O/UENp/EUTST7xx0VTjfDvDcmX618qMNNH6LN irK2IEbDhQGPJKncTyjRW4ZMG84xpqJFve9Z940hRA35B4Yt8n0Xl6wT2eVErZN9LDw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795195808; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=7bQnDQQGsXh/GfQqynI9Dm1mxtj1RYtKX42i3WjK0mc=; b=XVqd9uzfXvYU8/UW11W6dv11ObXpwUuc/rCDO4U7p4J46mNDhaV2KUrOkhAxbqGIdisb rTBmtQ4sG5eMMmwQCU2vIREtTXPuoVFl9Bic7IJiQdTwZ6NQjI1RTMCqjeWn33td5+QFA SYpA9g53WTVa1O7Veb6n1pucBRFM5h61hj5G4k9SljbceTkMQumfqBWDzeukSFQc+6U76 2Lc80eV7aJyhw+3JzVIxPFCtpjGnegnARRXeAVdg2pRIN/fen0t8BOTmF089HAVyHrToX D5opzi6fpl3x34EA0JoHGeYYjaCMicNldq59bJtaTQbcGqvXper7s/i+LL9wOobLdtA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Ak10GoM2; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F3EC60A262E for ; Fri, 20 Nov 2026 17:30:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Ak10GoM2 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 022061F000D1; Fri, 20 Nov 2026 17:30:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795195807; bh=7bQnDQQGsXh/GfQqynI9Dm1mxtj1RYtKX42i3WjK0mc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Ak10GoM21f09UMAhn9xS4VH3KYKUnQpdq4ly5HC3APsfU2fVM1lWOD9p10cFSqZLW AIFEA2iqY8/8f0EbuMkbTU/nfHjeT0lOkETNHBWnrSCju9p14KinKw4cDNpB569+4x 9D774GkyoqFCw4z4G0Dl545f+dXZKOhmkRZ9Ci0HdQA9ROgnoI0fa669aoWetma5kk Onlm74kHyq4n1tZKgmatH2HpN2U9PcYBKLOqV5QQOgQxL3kRVlQa2lVm/bb0/KbYHp JzjOsZfh+0qAtIpYwPkVxdAkdKC0SF3YRv29kNhd+UpEL66VeabmcUCxrXJTgOSast fEE+g7KOjKMHA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 10/11] mtd: spi-nand: Set the DQS spi-mem capability if available Reply-To: sashiko-reviews@lists.linux.dev To: "Miquel Raynal" , "Mark Brown" , "Richard Weinberger" , "Vignesh Raghavendra" , "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Pratyush Yadav" , "Michael Walle" , "Takahiro Kuwano" Cc: "Thomas Petazzoni" , praneeth@ti.com, u-kumar1@ti.com, p-mantena@ti.com, a-dutta@ti.com, s-k6@ti.com, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org In-Reply-To: <20261120-winbond-nand-next-phy-tuning-v4-10-8c21e1f71f41@bootlin.com> References: <20261120-winbond-nand-next-phy-tuning-v4-0-8c21e1f71f41@bootlin.com> <20261120-winbond-nand-next-phy-tuning-v4-10-8c21e1f71f41@bootlin.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 20 Nov 2026 17:30:06 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Medium] mtd: spinand: spi_mem_set_dqs_pin_available() called after SSDR negotiation -- commit ded1f01b00a338383ed4e62228f6b415856c9df3 Author: Miquel Raynal mtd: spi-nand: Set the DQS spi-mem capability if available This commit adds the SPINAND_HAS_DQS flag and calls spi_mem_set_dqs_pin_available() in spinand_match_and_init() when a matched SPI-NAND chip supports DQS. > diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c > index fee4a48b4c7f3..6e1b7976d2379 100644 > --- a/drivers/mtd/nand/spi/core.c > +++ b/drivers/mtd/nand/spi/core.c > @@ -1797,6 +1797,9 @@ int spinand_match_and_init(struct spinand_device *s= pinand, > } > } > =20 > + if (spinand->flags & SPINAND_HAS_DQS) > + spi_mem_set_dqs_pin_available(spinand->spimem); > + > /* I/O variants selection with octo-spi DDR commands (optional) */ > =20 > ret =3D spinand_init_odtr_instruction_set(spinand); [Severity: Medium] Should spi_mem_set_dqs_pin_available() be called right after spinand->flags is initialized, before SSDR operation variants are selected? Placing it here leaves spinand->spimem->dqs_pin false while spinand_select_op_variant(spinand, SSDR, ...) and spinand_support_vendor_ops(spinand, info, SSDR) run, which also evaluate 1S-command DTR read variants such as SPINAND_PAGE_READ_FROM_CACHE_1S_1D_8D_OP. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261120-winbond-na= nd-next-phy-tuning-v4-0-8c21e1f71f41@bootlin.com?part=3D10