All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jim Cromie" <jim.cromie@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 2/5] drm: Fix incorrect CFLAGS-y spelling inside Makefile
Date: Fri, 20 Nov 2026 17:32:14 +0000	[thread overview]
Message-ID: <sashiko-outbox-225674@kernel.org> (raw)
In-Reply-To: <20261120-rd-mostly-v2-2-88056ede02a8@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm: redundant ccflags-y with subdir-ccflags-y duplicates
  compiler flag
--

commit 3641ab8573c265c9f30c513b01ff9a6dc232bced
Author: Jim Cromie <jim.cromie@gmail.com>

drm: Fix incorrect CFLAGS-y spelling inside Makefile

This commit replaces CFLAGS-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) with
ccflags-y and subdir-ccflags-y in drivers/gpu/drm/Makefile so that
-DDYNAMIC_DEBUG_MODULE is passed during compilation.

> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
> index 2c6bc093a923a..4a93c09f08d94 100644
> --- a/drivers/gpu/drm/Makefile
> +++ b/drivers/gpu/drm/Makefile
> @@ -3,7 +3,8 @@
>  # Makefile for the drm device driver.  This driver provides support for the
>  # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher.
>  
> -CFLAGS-$(CONFIG_DRM_USE_DYNAMIC_DEBUG)	+= -DDYNAMIC_DEBUG_MODULE
> +ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG)		+= -DDYNAMIC_DEBUG_MODULE
> +subdir-ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG)	+= -DDYNAMIC_DEBUG_MODULE

[Severity: Low]
Is ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) redundant when
subdir-ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) is also set?

In scripts/Makefile.build, subdir-ccflags-y is appended to KBUILD_CFLAGS
for both the current directory and its subdirectories:

scripts/Makefile.build {
    ...
    # flags that take effect in current and sub directories
    KBUILD_AFLAGS += $(subdir-asflags-y)
    KBUILD_CFLAGS += $(subdir-ccflags-y)
    ...
}

Setting both passes -DDYNAMIC_DEBUG_MODULE twice on the compiler command
line for every object built directly in drivers/gpu/drm/.  Keeping only
subdir-ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG), matching the rest of this
Makefile, covers both drivers/gpu/drm/ and its subdirectories.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-rd-mostly-v2-0-88056ede02a8@gmail.com?part=2

  reply	other threads:[~2026-11-20 17:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 17:18 [PATCH v2 0/5] drm/print,dyndbg: __drm_debug __read_mostly, uint shrink, build fixes Jim Cromie
2026-11-20 17:18 ` Jim Cromie via B4 Relay
2026-11-20 17:18 ` [PATCH v2 1/5] drm/print: Mark __drm_debug as __read_mostly Jim Cromie
2026-11-20 17:18   ` Jim Cromie via B4 Relay
2026-11-20 17:18 ` [PATCH v2 2/5] drm: Fix incorrect CFLAGS-y spelling inside Makefile Jim Cromie
2026-11-20 17:18   ` Jim Cromie via B4 Relay
2026-11-20 17:32   ` sashiko-bot [this message]
2026-11-20 17:18 ` [PATCH v2 3/5] drm: fix config dependent unused variable warning Jim Cromie
2026-11-20 17:18   ` Jim Cromie via B4 Relay
2026-11-20 17:33   ` sashiko-bot
2026-11-20 17:18 ` [PATCH v2 4/5] drm/print,dyndbg: restore __drm_debug to uint from ulong Jim Cromie
2026-11-20 17:18   ` Jim Cromie via B4 Relay
2026-11-20 17:18 ` [PATCH v2 5/5] drm-dyndbg: drop BROKEN on DRM_USE_DYNAMIC_DEBUG for testing (DONT_APPLY) Jim Cromie
2026-11-20 17:18   ` Jim Cromie via B4 Relay
2026-11-20 17:35   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-225674@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jim.cromie@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.