From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B486D606A6D1 for ; Fri, 20 Nov 2026 19:20:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=u6jJhBJ4; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=EVDbAutf DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=3cinXztJNzLqRRAqzP0Ng26oay1GEV37EOmQG2ZVd4Q=; b=u6jJhBJ43bf/xnxZ14gPNOZBed quHU4LeA6hI4IjhJZOzzWS/W9TXIa6/lTLt0Bb62kJMw1FTX6RDZxLhRuESW3Jh2ukUq0LqNno/dM 9G5pLoLH4d7yu8+rk/5zbhgbPj1HwEh+2P4naO7t0ycp6qBgkRReD9ZguzFWKyVYlAXJ3lq5N4SoR +gJ4w1VZky2up8/Rc83kNTsBik/0XQ/hw5yxQy78t+3Z2sZbNEHS2FLyNnnFlFFTbSeiMZeghw1xg ixNv7Ld+F2glzJBTKlAI05NhXdewvNgAR8KK+J2OIa8vnOC5djNircwppm8YfBEDODGYfjb1LEtjU j4ctF2bg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUUA5-0000000G3ij-1DQq; Fri, 20 Nov 2026 19:20:41 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUUA4-0000000G3i8-1iUW; Fri, 20 Nov 2026 19:20:40 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 1603543CEA; Fri, 20 Nov 2026 19:20:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6ABC31F000ED; Fri, 20 Nov 2026 19:20:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795202440; bh=vxlrH7ZyE4Vxgz8nt01JW/28BAYUCeqTyQt+hXyeCFI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=EVDbAutfcdKj6lUOz2AMjxnLptzDf9dj0f+SLHMWMwSo3TRTyP+W0h9BAJVeB54aI GncSb4UIO8Ghi2rQ6oX/lstFTNZIwStcBNTwY8HAR3hcyQA0r1nyiQb8GfpP12Vc0Q D3qI6uQn96pAmxAnV2M0qbTD9P3iNS+H5tBijDfMBmnXEym2k8b846LVwbBpQ4S8bb seWnpNbsR8AuKdDyDpDV9wQytZv8pM3s5PLdWim76CXy7AdlsYA6gOgpx+8cRBzrSX Ww/KmMyogRF45rc7HwzLAhWp7m/O9TqrMmq+5CxiKMiOnD+nQNu18G9KJH1qIGDVkL hJ0PdLBUGhREg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 08/11] drm/meson: dw-hdmi: Use the generic PHY framework for the HDMI TX PHY To: "Ronald Claveau" Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org, robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org, vkoul@kernel.org, olteanv@gmail.com In-Reply-To: <20261120-meson-drm-create-hdmitx-phy-v2-8-93d622d9bb07@aliel.fr> References: <20261120-meson-drm-create-hdmitx-phy-v2-0-93d622d9bb07@aliel.fr> <20261120-meson-drm-create-hdmitx-phy-v2-8-93d622d9bb07@aliel.fr> Date: Fri, 20 Nov 2026 19:20:39 +0000 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwKaXNzdWVzIHRvIGNvbnNpZGVyOgotIFtIaWdoXSBkcm0vbWVzb246IGR3LWhk bWk6IG1pc3NpbmcgUEhZIGluaXQgaW4gbWVzb25fZHdfaGRtaV9pbml0KCkKICBicmVha3MgQ0VD L0FSQwotIFtNZWRpdW1dIGRybS9tZXNvbjogZHctaGRtaTogcGh5X2luaXQoKSBsZWFrIG9uIGVy cm9yIHBhdGggaW4KICBkd19oZG1pX3BoeV9pbml0KCkKLS0KCmNvbW1pdCA5YzRlNTJiYmQzMDVm NjM3MWVlNjU0NWM0NzljOWE4NGU2ODQ1MzI0CkF1dGhvcjogUm9uYWxkIENsYXZlYXUgPGxpbnV4 LWtlcm5lbC1kZXZAYWxpZWwuZnI+Cgpkcm0vbWVzb246IGR3LWhkbWk6IFVzZSB0aGUgZ2VuZXJp YyBQSFkgZnJhbWV3b3JrIGZvciB0aGUgSERNSSBUWCBQSFkKClRoaXMgY29tbWl0IGNvbnZlcnRz IHRoZSBNZXNvbiBEVy1IRE1JIGRyaXZlciBmcm9tIGRpcmVjdCBISEkgcmVnaXN0ZXIKcHJvZ3Jh bW1pbmcgdG8gdGhlIGdlbmVyaWMgUEhZIEFQSSwgd2l0aCBhIGxlZ2FjeSBmYWxsYmFjayB3aGVu IHRoZSBEVApub2RlIGxhY2tzIGEgInBoeXMiIHByb3BlcnR5LgoKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL21lc29uL21lc29uX2R3X2hkbWkuYyBiL2RyaXZlcnMvZ3B1L2RybS9tZXNv bi9tZXNvbl9kd19oZG1pLmMKPiBpbmRleCAyMGE4MjE5MzZiM2FmLi4xY2ExY2U2MTczNTYzIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZXNvbi9tZXNvbl9kd19oZG1pLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vbWVzb24vbWVzb25fZHdfaGRtaS5jClsgLi4uIF0KPiBAQCAtMzY0 LDEwICsyNzYsMTggQEAgc3RhdGljIGludCBkd19oZG1pX3BoeV9pbml0KHN0cnVjdCBkd19oZG1p ICpoZG1pLCB2b2lkICpkYXRhLAo+ICAJdW5zaWduZWQgaW50IHdyX2NsayA9Cj4gIAkJcmVhZGxf cmVsYXhlZChwcml2LT5pb19iYXNlICsgX1JFRyhWUFVfSERNSV9TRVRUSU5HKSk7Cj4gIAlib29s IG1vZGVfaXNfNDIwID0gZmFsc2U7Cj4gKwl1bnNpZ25lZCBpbnQgcGl4ZWxfY2xvY2sgPSBtb2Rl LT5jbG9jazsKPiArCXVuaW9uIHBoeV9jb25maWd1cmVfb3B0cyBvcHRzID0ge307Cj4gKwlpbnQg cmV0Owo+ICAKPiAgCURSTV9ERUJVR19EUklWRVIoIlwiJXNcIiBkaXYlZFxuIiwgbW9kZS0+bmFt ZSwKPiAgCQkJIG1vZGUtPmNsb2NrID4gMzQwMDAwID8gNDAgOiAxMCk7Cj4gIAo+ICsJLyogU2V0 dXAgUEhZICovCj4gKwlyZXQgPSBwaHlfaW5pdChkd19oZG1pLT5waHkpOwo+ICsJaWYgKHJldCkK PiArCQlyZXR1cm4gcmV0Owo+ICsKPiAgCWlmIChkcm1fbW9kZV9pc180MjBfb25seShkaXNwbGF5 LCBtb2RlKSB8fAo+ICAJICAgICghaXNfaGRtaTJfc2luayAmJiBkcm1fbW9kZV9pc180MjBfYWxz byhkaXNwbGF5LCBtb2RlKSkgfHwKPiAgCSAgICBkd19oZG1pX2J1c19mbXRfaXNfNDIwKGhkbWkp KQo+IEBAIC0zOTIsMTkgKzMxMiwyMiBAQCBzdGF0aWMgaW50IGR3X2hkbWlfcGh5X2luaXQoc3Ry dWN0IGR3X2hkbWkgKmhkbWksIHZvaWQgKmRhdGEsCj4gIAlkd19oZG1pLT5kYXRhLT50b3Bfd3Jp dGUoZHdfaGRtaSwgSERNSVRYX1RPUF9UTURTX0NMS19QVFROX0NOVEwsIDB4Mik7Cj4gIAo+ICAJ LyogU2V0dXAgUEhZIHBhcmFtZXRlcnMgKi8KPiAtCW1lc29uX2hkbWlfcGh5X3NldHVwX21vZGUo ZHdfaGRtaSwgbW9kZSwgbW9kZV9pc180MjApOwo+IC0KPiAtCS8qIERpc2FibGUgY2xvY2ssIGZp Zm8sIGZpZm9fd3IgKi8KPiAtCXJlZ21hcF91cGRhdGVfYml0cyhwcml2LT5oaGksIEhISV9IRE1J X1BIWV9DTlRMMSwgMHhmLCAwKTsKPiArCWlmIChtb2RlX2lzXzQyMCkKPiArCQlwaXhlbF9jbG9j ayAvPSAyOwo+ICsJb3B0cy5oZG1pLnRtZHNfY2hhcl9yYXRlID0gKHU2NClwaXhlbF9jbG9jayAq IDEwMDA7Cj4gKwlvcHRzLmhkbWkuYnBjID0gODsKPiArCXJldCA9IHBoeV9jb25maWd1cmUoZHdf aGRtaS0+cGh5LCAmb3B0cyk7Cj4gKwlpZiAocmV0KQo+ICsJCXJldHVybiByZXQ7Cj4gIAo+ICAJ ZHdfaGRtaV9zZXRfaGlnaF90bWRzX2Nsb2NrX3JhdGlvKGhkbWksIGRpc3BsYXkpOwo+ICAKPiAg CW1zbGVlcCgxMDApOwo+ICAKPiAgCS8qIFJlc2V0IFBIWSAzIHRpbWVzIGluIGEgcm93ICovCj4g LQltZXNvbl9kd19oZG1pX3BoeV9yZXNldChkd19oZG1pKTsKPiAtCW1lc29uX2R3X2hkbWlfcGh5 X3Jlc2V0KGR3X2hkbWkpOwo+IC0JbWVzb25fZHdfaGRtaV9waHlfcmVzZXQoZHdfaGRtaSk7Cj4g KwlyZXQgPSBwaHlfcG93ZXJfb24oZHdfaGRtaS0+cGh5KTsKPiArCWlmIChyZXQpCj4gKwkJcmV0 dXJuIHJldDsKCltTZXZlcml0eTogTWVkaXVtXQpEbyB0aGUgZXJyb3IgcmV0dXJucyBmcm9tIHBo eV9jb25maWd1cmUoKSBhbmQgcGh5X3Bvd2VyX29uKCkgbGVhayBhCmR3X2hkbWktPnBoeS0+aW5p dF9jb3VudCByZWZlcmVuY2U/CgpXaGVuIGR3X2hkbWlfcGh5X2luaXQoKSBmYWlscywgZHdfaGRt aV9zZXR1cCgpIGxlYXZlcyBoZG1pLT5waHkuZW5hYmxlZApmYWxzZSwgc28gZHdfaGRtaV9wb3dl cm9mZigpIG5ldmVyIGNhbGxzIGR3X2hkbWlfcGh5X2Rpc2FibGUoKSB0byBiYWxhbmNlCnBoeV9p bml0KCkgd2l0aCBwaHlfZXhpdCgpLiAgQSBub24tVklDIERNVCBtb2RlIHdpdGggYSBwaXhlbCBj bG9jayBiZWxvdwoyNS4xNzUgTUh6IHBhc3NlcyBtZXNvbl9lbmNvZGVyX2hkbWlfbW9kZV92YWxp ZCgpIGJ1dCBpcyByZWplY3RlZCB3aXRoCi1FSU5WQUwgYnkgbWVzb25faGRtaV9waHlfY29uZmln dXJlKCkgLT4gbWVzb25faGRtaV9waHlfZmluZF9yYXRlKCksCnBlcm1hbmVudGx5IGVsZXZhdGlu ZyBpbml0X2NvdW50IHNvIHN1YnNlcXVlbnQgcGh5X2luaXQoKSBjYWxscyBza2lwCmhhcmR3YXJl IGluaXRpYWxpemF0aW9uLgoKWyAuLi4gXQoKPiBAQCAtNjIzLDEwICs1NDIsNiBAQCBzdGF0aWMg dm9pZCBtZXNvbl9kd19oZG1pX2luaXQoc3RydWN0IG1lc29uX2R3X2hkbWkgKm1lc29uX2R3X2hk bWkpCj4gIAkvKiBFbmFibGUgbm9ybWFsIG91dHB1dCB0byBQSFkgKi8KPiAgCW1lc29uX2R3X2hk bWktPmRhdGEtPnRvcF93cml0ZShtZXNvbl9kd19oZG1pLCBIRE1JVFhfVE9QX0JJU1RfQ05UTCwg QklUKDEyKSk7Cj4gIAo+IC0JLyogU2V0dXAgUEhZICovCj4gLQlyZWdtYXBfd3JpdGUocHJpdi0+ aGhpLCBISElfSERNSV9QSFlfQ05UTDEsIG1lc29uX2R3X2hkbWktPmRhdGEtPmNudGwxX2luaXQp Owo+IC0JcmVnbWFwX3dyaXRlKHByaXYtPmhoaSwgSEhJX0hETUlfUEhZX0NOVEwwLCBtZXNvbl9k d19oZG1pLT5kYXRhLT5jbnRsMF9pbml0KTsKPiAtCj4gIAkvKiBFbmFibGUgSERNSS1UWCBJbnRl cnJ1cHQgKi8KPiAgCW1lc29uX2R3X2hkbWktPmRhdGEtPnRvcF93cml0ZShtZXNvbl9kd19oZG1p LCBIRE1JVFhfVE9QX0lOVFJfU1RBVF9DTFIsCj4gIAkJCQkgICAgICAgSERNSVRYX1RPUF9JTlRS X0NPUkUpOwoKW1NldmVyaXR5OiBIaWdoXQpEb2VzIHJlbW92aW5nIHRoZSBpbml0aWFsIFBIWSBz ZXR1cCBmcm9tIG1lc29uX2R3X2hkbWlfaW5pdCgpIGxlYXZlIHRoZQpIRE1JIFRYIFBIWSB1bmlu aXRpYWxpemVkIHdoZW5ldmVyIG5vIEhETUkgdmlkZW8gbW9kZSBpcyBhY3RpdmU/CgptZXNvbl9k d19oZG1pX2luaXQoKSBwdWxzZXMgcmVzZXRfY29udHJvbF9yZXNldChtZXNvbl9kd19oZG1pLT5o ZG1pdHhfcGh5KQphdCBiaW5kIGFuZCBzeXN0ZW0gcmVzdW1lIHRpbWUsIHdoaWxlIG1lc29uX3Zl bmNfaW5pdCgpIHplcm9lcwpISElfSERNSV9QSFlfQ05UTDAuICBDb21taXRzIDA0NzAzYmZkN2Y5 OSAoImRybS9tZXNvbjogZHctaGRtaTogcG93ZXIgdXAKcGh5IG9uIGRldmljZSBpbml0IikgYW5k IDA4MDAxMDMzMTIxZCAoImRybS9tZXNvbjogZHctaGRtaTogYWRkIGJhbmRnYXAKc2V0dGluZyBm b3IgZzEyIikgcHJvZ3JhbW1lZCBISElfSERNSV9QSFlfQ05UTDEgYW5kIEhISV9IRE1JX1BIWV9D TlRMMApoZXJlIGJlY2F1c2UgQ0VDIGFuZCB0aGUgRzEyQSBBUkMvZUFSQyB1dGlsaXR5IHBpbiBu ZWVkIHRoZSBQSFkKaW5pdGlhbGl6ZWQgZXZlbiBiZWZvcmUgdGhlIGZpcnN0IEhETUkgbW9kZXNl dCBvciB3aGVuIGFub3RoZXIgZGlzcGxheQppbnRlcmZhY2UgaXMgdXNlZC4KCldpdGggcGh5X2lu aXQoKSBkZWZlcnJlZCB0byBkd19oZG1pX3BoeV9pbml0KCksIHdoaWNoIGR3X2hkbWlfc2V0dXAo KSBvbmx5CmNhbGxzIHdoZW4gZW5hYmxpbmcgYW4gYWN0aXZlIEhETUkgZGlzcGxheSBtb2RlIChh bmQgd2hpY2gKbWVzb25fZHdfaGRtaV9wbV9yZXN1bWUoKSAtPiBkd19oZG1pX3Jlc3VtZSgpIGRv ZXMgbm90IGNhbGwpLCB0aGUgUEhZCnN0YXlzIGluIGl0cyBwb3N0LXJlc2V0IHN0YXRlIGF0IGJv b3QgYW5kIGFmdGVyIHJlc3VtZSB3aGVuZXZlciBIRE1JCnZpZGVvIGlzIGluYWN0aXZlLgoKLS0g ClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2 MTEyMC1tZXNvbi1kcm0tY3JlYXRlLWhkbWl0eC1waHktdjItMC05M2Q2MjJkOWJiMDdAYWxpZWwu ZnI/cGFydD04CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hbWxvZ2ljIG1haWxpbmcgbGlzdApsaW51eC1hbWxvZ2ljQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h bWxvZ2ljCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7C55606A6F8 for ; Fri, 20 Nov 2026 19:20:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=EVDbAutf Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 31B2D112CD7; Fri, 20 Nov 2026 19:20:46 +0000 (UTC) Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D1D3112CD7 for ; Fri, 20 Nov 2026 19:20:40 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 1603543CEA; Fri, 20 Nov 2026 19:20:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6ABC31F000ED; Fri, 20 Nov 2026 19:20:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795202440; bh=vxlrH7ZyE4Vxgz8nt01JW/28BAYUCeqTyQt+hXyeCFI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=EVDbAutfcdKj6lUOz2AMjxnLptzDf9dj0f+SLHMWMwSo3TRTyP+W0h9BAJVeB54aI GncSb4UIO8Ghi2rQ6oX/lstFTNZIwStcBNTwY8HAR3hcyQA0r1nyiQb8GfpP12Vc0Q D3qI6uQn96pAmxAnV2M0qbTD9P3iNS+H5tBijDfMBmnXEym2k8b846LVwbBpQ4S8bb seWnpNbsR8AuKdDyDpDV9wQytZv8pM3s5PLdWim76CXy7AdlsYA6gOgpx+8cRBzrSX Ww/KmMyogRF45rc7HwzLAhWp7m/O9TqrMmq+5CxiKMiOnD+nQNu18G9KJH1qIGDVkL hJ0PdLBUGhREg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 08/11] drm/meson: dw-hdmi: Use the generic PHY framework for the HDMI TX PHY To: "Ronald Claveau" Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org, robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org, vkoul@kernel.org, olteanv@gmail.com In-Reply-To: <20261120-meson-drm-create-hdmitx-phy-v2-8-93d622d9bb07@aliel.fr> References: <20261120-meson-drm-create-hdmitx-phy-v2-0-93d622d9bb07@aliel.fr> <20261120-meson-drm-create-hdmitx-phy-v2-8-93d622d9bb07@aliel.fr> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 20 Nov 2026 19:20:39 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "dri-devel" X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: Thank you for your contribution! Sashiko AI review found 2 potential issues to consider: - [High] drm/meson: dw-hdmi: missing PHY init in meson_dw_hdmi_init() breaks CEC/ARC - [Medium] drm/meson: dw-hdmi: phy_init() leak on error path in dw_hdmi_phy_init() -- commit 9c4e52bbd305f6371ee6545c479c9a84e6845324 Author: Ronald Claveau drm/meson: dw-hdmi: Use the generic PHY framework for the HDMI TX PHY This commit converts the Meson DW-HDMI driver from direct HHI register programming to the generic PHY API, with a legacy fallback when the DT node lacks a "phys" property. > diff --git a/drivers/gpu/drm/meson/meson_dw_hdmi.c b/drivers/gpu/drm/meso= n/meson_dw_hdmi.c > index 20a821936b3af..1ca1ce6173563 100644 > --- a/drivers/gpu/drm/meson/meson_dw_hdmi.c > +++ b/drivers/gpu/drm/meson/meson_dw_hdmi.c [ ... ] > @@ -364,10 +276,18 @@ static int dw_hdmi_phy_init(struct dw_hdmi *hdmi, v= oid *data, > unsigned int wr_clk =3D > readl_relaxed(priv->io_base + _REG(VPU_HDMI_SETTING)); > bool mode_is_420 =3D false; > + unsigned int pixel_clock =3D mode->clock; > + union phy_configure_opts opts =3D {}; > + int ret; > =20 > DRM_DEBUG_DRIVER("\"%s\" div%d\n", mode->name, > mode->clock > 340000 ? 40 : 10); > =20 > + /* Setup PHY */ > + ret =3D phy_init(dw_hdmi->phy); > + if (ret) > + return ret; > + > if (drm_mode_is_420_only(display, mode) || > (!is_hdmi2_sink && drm_mode_is_420_also(display, mode)) || > dw_hdmi_bus_fmt_is_420(hdmi)) > @@ -392,19 +312,22 @@ static int dw_hdmi_phy_init(struct dw_hdmi *hdmi, v= oid *data, > dw_hdmi->data->top_write(dw_hdmi, HDMITX_TOP_TMDS_CLK_PTTN_CNTL, 0x2); > =20 > /* Setup PHY parameters */ > - meson_hdmi_phy_setup_mode(dw_hdmi, mode, mode_is_420); > - > - /* Disable clock, fifo, fifo_wr */ > - regmap_update_bits(priv->hhi, HHI_HDMI_PHY_CNTL1, 0xf, 0); > + if (mode_is_420) > + pixel_clock /=3D 2; > + opts.hdmi.tmds_char_rate =3D (u64)pixel_clock * 1000; > + opts.hdmi.bpc =3D 8; > + ret =3D phy_configure(dw_hdmi->phy, &opts); > + if (ret) > + return ret; > =20 > dw_hdmi_set_high_tmds_clock_ratio(hdmi, display); > =20 > msleep(100); > =20 > /* Reset PHY 3 times in a row */ > - meson_dw_hdmi_phy_reset(dw_hdmi); > - meson_dw_hdmi_phy_reset(dw_hdmi); > - meson_dw_hdmi_phy_reset(dw_hdmi); > + ret =3D phy_power_on(dw_hdmi->phy); > + if (ret) > + return ret; [Severity: Medium] Do the error returns from phy_configure() and phy_power_on() leak a dw_hdmi->phy->init_count reference? When dw_hdmi_phy_init() fails, dw_hdmi_setup() leaves hdmi->phy.enabled false, so dw_hdmi_poweroff() never calls dw_hdmi_phy_disable() to balance phy_init() with phy_exit(). A non-VIC DMT mode with a pixel clock below 25.175 MHz passes meson_encoder_hdmi_mode_valid() but is rejected with -EINVAL by meson_hdmi_phy_configure() -> meson_hdmi_phy_find_rate(), permanently elevating init_count so subsequent phy_init() calls skip hardware initialization. [ ... ] > @@ -623,10 +542,6 @@ static void meson_dw_hdmi_init(struct meson_dw_hdmi = *meson_dw_hdmi) > /* Enable normal output to PHY */ > meson_dw_hdmi->data->top_write(meson_dw_hdmi, HDMITX_TOP_BIST_CNTL, BIT= (12)); > =20 > - /* Setup PHY */ > - regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL1, meson_dw_hdmi->data->cntl1_= init); > - regmap_write(priv->hhi, HHI_HDMI_PHY_CNTL0, meson_dw_hdmi->data->cntl0_= init); > - > /* Enable HDMI-TX Interrupt */ > meson_dw_hdmi->data->top_write(meson_dw_hdmi, HDMITX_TOP_INTR_STAT_CLR, > HDMITX_TOP_INTR_CORE); [Severity: High] Does removing the initial PHY setup from meson_dw_hdmi_init() leave the HDMI TX PHY uninitialized whenever no HDMI video mode is active? meson_dw_hdmi_init() pulses reset_control_reset(meson_dw_hdmi->hdmitx_phy) at bind and system resume time, while meson_venc_init() zeroes HHI_HDMI_PHY_CNTL0. Commits 04703bfd7f99 ("drm/meson: dw-hdmi: power up phy on device init") and 08001033121d ("drm/meson: dw-hdmi: add bandgap setting for g12") programmed HHI_HDMI_PHY_CNTL1 and HHI_HDMI_PHY_CNTL0 here because CEC and the G12A ARC/eARC utility pin need the PHY initialized even before the first HDMI modeset or when another display interface is used. With phy_init() deferred to dw_hdmi_phy_init(), which dw_hdmi_setup() only calls when enabling an active HDMI display mode (and which meson_dw_hdmi_pm_resume() -> dw_hdmi_resume() does not call), the PHY stays in its post-reset state at boot and after resume whenever HDMI video is inactive. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261120-meson-drm-= create-hdmitx-phy-v2-0-93d622d9bb07@aliel.fr?part=3D8 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C836760A2600 for ; Fri, 20 Nov 2026 19:20:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=QldZxpi3; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=EVDbAutf DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=3PcJQyvReJGtYmyo5D8hbg297fsP1a/DI1ypR9Jtw8I=; b=QldZxpi3w6TcQCgLrPcpPG+TIU o5RvFYTlJ6EAmyhKNXsTddG8eZajk/IAFNVxRx3HWetTjsyEqQYFF+PHHY+4VpNqmAre4xQkv5Fdw a+MCIpMdw4q8tFj1JEYH5xyUvQd/a20t2xPn9j9KrGq0jznoyjvsonq07DSuHqek9hbfd8CqGQTEK H1o6YNZEJfurFXiswC0bIv5uSqu4nWHlki7DHfRnJKtFCXv3mfUfTmnhOB/dapdpMNMxzOYuTabGv 3msDWPaMob3zl4GrKkjFyGFW4tTF/NF7okXZ5OuPRati9xMy6OQcKZkwbWONzv/RT8HqFpv2OLRAz 3vL1fyUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUUA5-0000000G3in-244O; Fri, 20 Nov 2026 19:20:41 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUUA4-0000000G3i8-1iUW; Fri, 20 Nov 2026 19:20:40 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 1603543CEA; Fri, 20 Nov 2026 19:20:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6ABC31F000ED; Fri, 20 Nov 2026 19:20:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795202440; bh=vxlrH7ZyE4Vxgz8nt01JW/28BAYUCeqTyQt+hXyeCFI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=EVDbAutfcdKj6lUOz2AMjxnLptzDf9dj0f+SLHMWMwSo3TRTyP+W0h9BAJVeB54aI GncSb4UIO8Ghi2rQ6oX/lstFTNZIwStcBNTwY8HAR3hcyQA0r1nyiQb8GfpP12Vc0Q D3qI6uQn96pAmxAnV2M0qbTD9P3iNS+H5tBijDfMBmnXEym2k8b846LVwbBpQ4S8bb seWnpNbsR8AuKdDyDpDV9wQytZv8pM3s5PLdWim76CXy7AdlsYA6gOgpx+8cRBzrSX Ww/KmMyogRF45rc7HwzLAhWp7m/O9TqrMmq+5CxiKMiOnD+nQNu18G9KJH1qIGDVkL hJ0PdLBUGhREg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 08/11] drm/meson: dw-hdmi: Use the generic PHY framework for the HDMI TX PHY To: "Ronald Claveau" Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-phy@lists.infradead.org, dri-devel@lists.freedesktop.org, robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org, vkoul@kernel.org, olteanv@gmail.com In-Reply-To: <20261120-meson-drm-create-hdmitx-phy-v2-8-93d622d9bb07@aliel.fr> References: <20261120-meson-drm-create-hdmitx-phy-v2-0-93d622d9bb07@aliel.fr> <20261120-meson-drm-create-hdmitx-phy-v2-8-93d622d9bb07@aliel.fr> Date: Fri, 20 Nov 2026 19:20:39 +0000 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwKaXNzdWVzIHRvIGNvbnNpZGVyOgotIFtIaWdoXSBkcm0vbWVzb246IGR3LWhk bWk6IG1pc3NpbmcgUEhZIGluaXQgaW4gbWVzb25fZHdfaGRtaV9pbml0KCkKICBicmVha3MgQ0VD L0FSQwotIFtNZWRpdW1dIGRybS9tZXNvbjogZHctaGRtaTogcGh5X2luaXQoKSBsZWFrIG9uIGVy cm9yIHBhdGggaW4KICBkd19oZG1pX3BoeV9pbml0KCkKLS0KCmNvbW1pdCA5YzRlNTJiYmQzMDVm NjM3MWVlNjU0NWM0NzljOWE4NGU2ODQ1MzI0CkF1dGhvcjogUm9uYWxkIENsYXZlYXUgPGxpbnV4 LWtlcm5lbC1kZXZAYWxpZWwuZnI+Cgpkcm0vbWVzb246IGR3LWhkbWk6IFVzZSB0aGUgZ2VuZXJp YyBQSFkgZnJhbWV3b3JrIGZvciB0aGUgSERNSSBUWCBQSFkKClRoaXMgY29tbWl0IGNvbnZlcnRz IHRoZSBNZXNvbiBEVy1IRE1JIGRyaXZlciBmcm9tIGRpcmVjdCBISEkgcmVnaXN0ZXIKcHJvZ3Jh bW1pbmcgdG8gdGhlIGdlbmVyaWMgUEhZIEFQSSwgd2l0aCBhIGxlZ2FjeSBmYWxsYmFjayB3aGVu IHRoZSBEVApub2RlIGxhY2tzIGEgInBoeXMiIHByb3BlcnR5LgoKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL21lc29uL21lc29uX2R3X2hkbWkuYyBiL2RyaXZlcnMvZ3B1L2RybS9tZXNv bi9tZXNvbl9kd19oZG1pLmMKPiBpbmRleCAyMGE4MjE5MzZiM2FmLi4xY2ExY2U2MTczNTYzIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZXNvbi9tZXNvbl9kd19oZG1pLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vbWVzb24vbWVzb25fZHdfaGRtaS5jClsgLi4uIF0KPiBAQCAtMzY0 LDEwICsyNzYsMTggQEAgc3RhdGljIGludCBkd19oZG1pX3BoeV9pbml0KHN0cnVjdCBkd19oZG1p ICpoZG1pLCB2b2lkICpkYXRhLAo+ICAJdW5zaWduZWQgaW50IHdyX2NsayA9Cj4gIAkJcmVhZGxf cmVsYXhlZChwcml2LT5pb19iYXNlICsgX1JFRyhWUFVfSERNSV9TRVRUSU5HKSk7Cj4gIAlib29s IG1vZGVfaXNfNDIwID0gZmFsc2U7Cj4gKwl1bnNpZ25lZCBpbnQgcGl4ZWxfY2xvY2sgPSBtb2Rl LT5jbG9jazsKPiArCXVuaW9uIHBoeV9jb25maWd1cmVfb3B0cyBvcHRzID0ge307Cj4gKwlpbnQg cmV0Owo+ICAKPiAgCURSTV9ERUJVR19EUklWRVIoIlwiJXNcIiBkaXYlZFxuIiwgbW9kZS0+bmFt ZSwKPiAgCQkJIG1vZGUtPmNsb2NrID4gMzQwMDAwID8gNDAgOiAxMCk7Cj4gIAo+ICsJLyogU2V0 dXAgUEhZICovCj4gKwlyZXQgPSBwaHlfaW5pdChkd19oZG1pLT5waHkpOwo+ICsJaWYgKHJldCkK PiArCQlyZXR1cm4gcmV0Owo+ICsKPiAgCWlmIChkcm1fbW9kZV9pc180MjBfb25seShkaXNwbGF5 LCBtb2RlKSB8fAo+ICAJICAgICghaXNfaGRtaTJfc2luayAmJiBkcm1fbW9kZV9pc180MjBfYWxz byhkaXNwbGF5LCBtb2RlKSkgfHwKPiAgCSAgICBkd19oZG1pX2J1c19mbXRfaXNfNDIwKGhkbWkp KQo+IEBAIC0zOTIsMTkgKzMxMiwyMiBAQCBzdGF0aWMgaW50IGR3X2hkbWlfcGh5X2luaXQoc3Ry dWN0IGR3X2hkbWkgKmhkbWksIHZvaWQgKmRhdGEsCj4gIAlkd19oZG1pLT5kYXRhLT50b3Bfd3Jp dGUoZHdfaGRtaSwgSERNSVRYX1RPUF9UTURTX0NMS19QVFROX0NOVEwsIDB4Mik7Cj4gIAo+ICAJ LyogU2V0dXAgUEhZIHBhcmFtZXRlcnMgKi8KPiAtCW1lc29uX2hkbWlfcGh5X3NldHVwX21vZGUo ZHdfaGRtaSwgbW9kZSwgbW9kZV9pc180MjApOwo+IC0KPiAtCS8qIERpc2FibGUgY2xvY2ssIGZp Zm8sIGZpZm9fd3IgKi8KPiAtCXJlZ21hcF91cGRhdGVfYml0cyhwcml2LT5oaGksIEhISV9IRE1J X1BIWV9DTlRMMSwgMHhmLCAwKTsKPiArCWlmIChtb2RlX2lzXzQyMCkKPiArCQlwaXhlbF9jbG9j ayAvPSAyOwo+ICsJb3B0cy5oZG1pLnRtZHNfY2hhcl9yYXRlID0gKHU2NClwaXhlbF9jbG9jayAq IDEwMDA7Cj4gKwlvcHRzLmhkbWkuYnBjID0gODsKPiArCXJldCA9IHBoeV9jb25maWd1cmUoZHdf aGRtaS0+cGh5LCAmb3B0cyk7Cj4gKwlpZiAocmV0KQo+ICsJCXJldHVybiByZXQ7Cj4gIAo+ICAJ ZHdfaGRtaV9zZXRfaGlnaF90bWRzX2Nsb2NrX3JhdGlvKGhkbWksIGRpc3BsYXkpOwo+ICAKPiAg CW1zbGVlcCgxMDApOwo+ICAKPiAgCS8qIFJlc2V0IFBIWSAzIHRpbWVzIGluIGEgcm93ICovCj4g LQltZXNvbl9kd19oZG1pX3BoeV9yZXNldChkd19oZG1pKTsKPiAtCW1lc29uX2R3X2hkbWlfcGh5 X3Jlc2V0KGR3X2hkbWkpOwo+IC0JbWVzb25fZHdfaGRtaV9waHlfcmVzZXQoZHdfaGRtaSk7Cj4g KwlyZXQgPSBwaHlfcG93ZXJfb24oZHdfaGRtaS0+cGh5KTsKPiArCWlmIChyZXQpCj4gKwkJcmV0 dXJuIHJldDsKCltTZXZlcml0eTogTWVkaXVtXQpEbyB0aGUgZXJyb3IgcmV0dXJucyBmcm9tIHBo eV9jb25maWd1cmUoKSBhbmQgcGh5X3Bvd2VyX29uKCkgbGVhayBhCmR3X2hkbWktPnBoeS0+aW5p dF9jb3VudCByZWZlcmVuY2U/CgpXaGVuIGR3X2hkbWlfcGh5X2luaXQoKSBmYWlscywgZHdfaGRt aV9zZXR1cCgpIGxlYXZlcyBoZG1pLT5waHkuZW5hYmxlZApmYWxzZSwgc28gZHdfaGRtaV9wb3dl cm9mZigpIG5ldmVyIGNhbGxzIGR3X2hkbWlfcGh5X2Rpc2FibGUoKSB0byBiYWxhbmNlCnBoeV9p bml0KCkgd2l0aCBwaHlfZXhpdCgpLiAgQSBub24tVklDIERNVCBtb2RlIHdpdGggYSBwaXhlbCBj bG9jayBiZWxvdwoyNS4xNzUgTUh6IHBhc3NlcyBtZXNvbl9lbmNvZGVyX2hkbWlfbW9kZV92YWxp ZCgpIGJ1dCBpcyByZWplY3RlZCB3aXRoCi1FSU5WQUwgYnkgbWVzb25faGRtaV9waHlfY29uZmln dXJlKCkgLT4gbWVzb25faGRtaV9waHlfZmluZF9yYXRlKCksCnBlcm1hbmVudGx5IGVsZXZhdGlu ZyBpbml0X2NvdW50IHNvIHN1YnNlcXVlbnQgcGh5X2luaXQoKSBjYWxscyBza2lwCmhhcmR3YXJl IGluaXRpYWxpemF0aW9uLgoKWyAuLi4gXQoKPiBAQCAtNjIzLDEwICs1NDIsNiBAQCBzdGF0aWMg dm9pZCBtZXNvbl9kd19oZG1pX2luaXQoc3RydWN0IG1lc29uX2R3X2hkbWkgKm1lc29uX2R3X2hk bWkpCj4gIAkvKiBFbmFibGUgbm9ybWFsIG91dHB1dCB0byBQSFkgKi8KPiAgCW1lc29uX2R3X2hk bWktPmRhdGEtPnRvcF93cml0ZShtZXNvbl9kd19oZG1pLCBIRE1JVFhfVE9QX0JJU1RfQ05UTCwg QklUKDEyKSk7Cj4gIAo+IC0JLyogU2V0dXAgUEhZICovCj4gLQlyZWdtYXBfd3JpdGUocHJpdi0+ aGhpLCBISElfSERNSV9QSFlfQ05UTDEsIG1lc29uX2R3X2hkbWktPmRhdGEtPmNudGwxX2luaXQp Owo+IC0JcmVnbWFwX3dyaXRlKHByaXYtPmhoaSwgSEhJX0hETUlfUEhZX0NOVEwwLCBtZXNvbl9k d19oZG1pLT5kYXRhLT5jbnRsMF9pbml0KTsKPiAtCj4gIAkvKiBFbmFibGUgSERNSS1UWCBJbnRl cnJ1cHQgKi8KPiAgCW1lc29uX2R3X2hkbWktPmRhdGEtPnRvcF93cml0ZShtZXNvbl9kd19oZG1p LCBIRE1JVFhfVE9QX0lOVFJfU1RBVF9DTFIsCj4gIAkJCQkgICAgICAgSERNSVRYX1RPUF9JTlRS X0NPUkUpOwoKW1NldmVyaXR5OiBIaWdoXQpEb2VzIHJlbW92aW5nIHRoZSBpbml0aWFsIFBIWSBz ZXR1cCBmcm9tIG1lc29uX2R3X2hkbWlfaW5pdCgpIGxlYXZlIHRoZQpIRE1JIFRYIFBIWSB1bmlu aXRpYWxpemVkIHdoZW5ldmVyIG5vIEhETUkgdmlkZW8gbW9kZSBpcyBhY3RpdmU/CgptZXNvbl9k d19oZG1pX2luaXQoKSBwdWxzZXMgcmVzZXRfY29udHJvbF9yZXNldChtZXNvbl9kd19oZG1pLT5o ZG1pdHhfcGh5KQphdCBiaW5kIGFuZCBzeXN0ZW0gcmVzdW1lIHRpbWUsIHdoaWxlIG1lc29uX3Zl bmNfaW5pdCgpIHplcm9lcwpISElfSERNSV9QSFlfQ05UTDAuICBDb21taXRzIDA0NzAzYmZkN2Y5 OSAoImRybS9tZXNvbjogZHctaGRtaTogcG93ZXIgdXAKcGh5IG9uIGRldmljZSBpbml0IikgYW5k IDA4MDAxMDMzMTIxZCAoImRybS9tZXNvbjogZHctaGRtaTogYWRkIGJhbmRnYXAKc2V0dGluZyBm b3IgZzEyIikgcHJvZ3JhbW1lZCBISElfSERNSV9QSFlfQ05UTDEgYW5kIEhISV9IRE1JX1BIWV9D TlRMMApoZXJlIGJlY2F1c2UgQ0VDIGFuZCB0aGUgRzEyQSBBUkMvZUFSQyB1dGlsaXR5IHBpbiBu ZWVkIHRoZSBQSFkKaW5pdGlhbGl6ZWQgZXZlbiBiZWZvcmUgdGhlIGZpcnN0IEhETUkgbW9kZXNl dCBvciB3aGVuIGFub3RoZXIgZGlzcGxheQppbnRlcmZhY2UgaXMgdXNlZC4KCldpdGggcGh5X2lu aXQoKSBkZWZlcnJlZCB0byBkd19oZG1pX3BoeV9pbml0KCksIHdoaWNoIGR3X2hkbWlfc2V0dXAo KSBvbmx5CmNhbGxzIHdoZW4gZW5hYmxpbmcgYW4gYWN0aXZlIEhETUkgZGlzcGxheSBtb2RlIChh bmQgd2hpY2gKbWVzb25fZHdfaGRtaV9wbV9yZXN1bWUoKSAtPiBkd19oZG1pX3Jlc3VtZSgpIGRv ZXMgbm90IGNhbGwpLCB0aGUgUEhZCnN0YXlzIGluIGl0cyBwb3N0LXJlc2V0IHN0YXRlIGF0IGJv b3QgYW5kIGFmdGVyIHJlc3VtZSB3aGVuZXZlciBIRE1JCnZpZGVvIGlzIGluYWN0aXZlLgoKLS0g ClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2 MTEyMC1tZXNvbi1kcm0tY3JlYXRlLWhkbWl0eC1waHktdjItMC05M2Q2MjJkOWJiMDdAYWxpZWwu ZnI/cGFydD04CgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1waHkK