All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Elkin Cruz" <elkin@google.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_exar: check IS_ERR() on __xr17v35x_register_gpio()
Date: Fri, 20 Nov 2026 19:40:04 +0000	[thread overview]
Message-ID: <sashiko-outbox-225939@kernel.org> (raw)
In-Reply-To: <20261120192147.2869595-1-elkin@google.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] serial: 8250_exar: redundant fix aborts all UART ports in
  exar_pci_probe()
--

commit b311185ae98aa3c07a0e01dce285dd1024817852
Author: Elkin Cruz <elkin@google.com>

serial: 8250_exar: check IS_ERR() on __xr17v35x_register_gpio()

This commit checks IS_ERR() on the platform_device pointer returned by
__xr17v35x_register_gpio() in xr17v35x_register_gpio() and
iot2040_register_gpio(), propagating PTR_ERR(pdev) on failure.

> diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c
> index 42e55a8f8c69b..66858e383afcd 100644
> --- a/drivers/tty/serial/8250/8250_exar.c
> +++ b/drivers/tty/serial/8250/8250_exar.c
> @@ -1173,8 +1173,14 @@ static const struct software_node exar_gpio_node = {
>  static int xr17v35x_register_gpio(struct exar8250 *priv, struct pci_dev *pcidev,
>  				  struct uart_8250_port *port)
>  {
> -	if (pcidev->vendor == PCI_VENDOR_ID_EXAR)
> -		priv->gpio = __xr17v35x_register_gpio(pcidev, &exar_gpio_node);
> +	if (pcidev->vendor == PCI_VENDOR_ID_EXAR) {
> +		struct platform_device *pdev;
> +
> +		pdev = __xr17v35x_register_gpio(pcidev, &exar_gpio_node);
> +		if (IS_ERR(pdev))
> +			return PTR_ERR(pdev);
> +		priv->gpio = pdev;
> +	}
>  
>  	return 0;
>  }
> @@ -1286,13 +1292,17 @@ static int iot2040_register_gpio(struct exar8250 *priv,
>  				 struct uart_8250_port *port)
>  {
>  	u8 __iomem *p = port->port.membase;
> +	struct platform_device *pdev;
>  
>  	writeb(IOT2040_UARTS_DEFAULT_MODE, p + UART_EXAR_MPIOLVL_7_0);
>  	writeb(IOT2040_UARTS_GPIO_LO_MODE, p + UART_EXAR_MPIOSEL_7_0);
>  	writeb(IOT2040_UARTS_ENABLE, p + UART_EXAR_MPIOLVL_15_8);
>  	writeb(IOT2040_UARTS_GPIO_HI_MODE, p + UART_EXAR_MPIOSEL_15_8);
>  
> -	priv->gpio = __xr17v35x_register_gpio(pcidev, &iot2040_gpio_node);
> +	pdev = __xr17v35x_register_gpio(pcidev, &iot2040_gpio_node);
> +	if (IS_ERR(pdev))
> +		return PTR_ERR(pdev);
> +	priv->gpio = pdev;
>  
>  	return 0;
>  }

[Severity: Medium]
Should a failure in __xr17v35x_register_gpio() abort UART port registration
in exar_pci_probe()?

The error-pointer dereference in xr17v35x_unregister_gpio() mentioned in
the commit message was already fixed by 0353b5196588 ("serial: 8250_exar:
check priv->gpio properly"), which checks !IS_ERR_OR_NULL(priv->gpio).

Previously, GPIO platform-device registration failure was non-fatal so the
card's UART ports would still be registered.  Propagating PTR_ERR(pdev) from
xr17v35x_register_gpio() and iot2040_register_gpio() causes
pci_xr17v35x_setup() to fail on port 0, which breaks out of the port setup
loop in exar_pci_probe() at i == 0 and leaves the card with zero UART ports
registered while exar_pci_probe() still returns 0:

drivers/tty/serial/8250/8250_exar.c:exar_pci_probe() {
    ...
	for (i = 0; i < nr_ports && i < maxnr; i++) {
		rc = board->setup(priv, pcidev, &uart, i);
		if (rc) {
			dev_err_probe(&pcidev->dev, rc, "Failed to setup port %u\n", i);
			break;
		}
    ...
}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120192147.2869595-1-elkin@google.com?part=1

      reply	other threads:[~2026-11-20 19:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 19:21 [PATCH] serial: 8250_exar: check IS_ERR() on __xr17v35x_register_gpio() Elkin Cruz
2026-11-20 19:40 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-225939@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=elkin@google.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.