All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Mohammad Mosafer" <mohsafer@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH v3] usb: gadget: f_fs: fix use-after-free in ffs_closed() on umount
Date: Fri, 20 Nov 2026 19:40:19 +0000	[thread overview]
Message-ID: <sashiko-outbox-225940@kernel.org> (raw)
In-Reply-To: <20261120192415.335646-1-mohsafer@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] usb: gadget: f_fs: Fixes trailer cites 5920cda627688c instead of
  ecfbd7b9054b
--

commit cfe09aaba9522f24cae9e22dc082e6797e54adda
Author: Mohammad Mosafer <mohsafer@gmail.com>

> usb: gadget: f_fs: fix use-after-free in ffs_closed() on umount
>
> ffs_free_inst() releases the ffs_dev with ffs_release_dev() and only
> then re-acquires ffs_dev_lock to free it with _ffs_free_dev().  In
> between, the dev is still linked on the ffs_devices list while already
> marked unmounted, so a concurrent mount(2) of functionfs finds it by
> name in ffs_acquire_dev() and links a fresh ffs_data to the doomed dev
> (ffs_data->private_data = dev).  _ffs_free_dev() then kfrees the dev,
> and when that mount is torn down, ffs_closed() dereferences the stale
> ffs->private_data:
>
>   BUG: KASAN: slab-use-after-free in ffs_data_clear+0x438/0x530
>   Write of size 1 at addr ffff88810594664a by task repro/116
>     ffs_data_clear+0x438/0x530
>     ffs_fs_kill_sb+0x7b/0x510
>     deactivate_locked_super+0xa9/0x200
>     cleanup_mnt+0x255/0x380
>     ... reached via umount(2)
>   Freed by task 112:
>     kfree+0x127/0x3b0
>     ffs_free_inst+0x10c/0x1a0
>     usb_put_function_instance+0x8a/0xc0
>     configfs_rmdir+0x773/0x9c0
>   Allocated by task 113:
>     ffs_alloc_inst+0x109/0x360
>     function_make+0x138/0x330
>     configfs_mkdir+0x48b/0x1090
>
> Hold ffs_dev_lock across the release and the free so that a released
> dev is never findable, splitting ffs_release_dev() into a lock-assuming
> _ffs_release_dev() (matching the _ffs_* convention in this file) and
> enforcing its caller-holds-the-lock contract with lockdep_assert_held().
> For the same reason, re-read ffs->private_data under ffs_dev_lock in
> ffs_data_put(): the argument read there was unlocked, so a concurrent
> ffs_free_inst() could unlink and free the dev while the putter waited
> on the mutex, and the subsequent ffs_release_dev() would dereference
> the freed dev.  The now unreached ffs_release_dev() wrapper is dropped;
> its remaining callers use _ffs_release_dev() with the lock held.
>
> The race was reproduced with a multi-threaded harness racing configfs
> mkdir/rmdir of the ffs instance against mount/umount of functionfs on
> a KASAN kernel: the unpatched kernel reports the use-after-free
> reliably (2/2 runs), the patched kernel survives an extended soak with
> identical churn (2/2 runs clean).
>
> Reported-by: syzbot+6227549bd2c8a1ec8ba0@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=6227549bd2c8a1ec8ba0
> Fixes: 5920cda627688c ("usb: gadget: FunctionFS: convert to new function interface with backward compatibility")
> Signed-off-by: Mohammad Mosafer <mohsafer@gmail.com>

[Severity: Low]
In 5920cda62768 ("usb: gadget: FunctionFS: convert to new function
interface with backward compatibility"), ffs_free_inst() only acquired
ffs_dev_lock() once around ffs_free_dev(opts->dev) without calling
ffs_release_dev(), and ffs_release_dev() took struct ffs_data * and read
ffs_data->private_data under ffs_dev_lock().

Both the lock gap between ffs_release_dev() and _ffs_free_dev() in
ffs_free_inst() and the unlocked ffs->private_data read in
ffs_data_put() were introduced later by ecfbd7b9054b ("usb: gadget:
f_fs: Fix setting of device and driver data cross-references").

Should the Fixes tag reference that commit instead?

  Fixes: ecfbd7b9054b ("usb: gadget: f_fs: Fix setting of device and driver data cross-references")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120192415.335646-1-mohsafer@gmail.com?part=1

  reply	other threads:[~2026-11-20 19:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06 21:05 [PATCH] usb: gadget: f_fs: fix use-after-free in ffs_closed() on umount Mohammad Mosafer
2026-10-06 21:17 ` sashiko-bot
2026-10-06 21:49 ` [PATCH v2] " Mohammad Mosafer
2026-10-06 22:00   ` sashiko-bot
2026-11-20 10:18   ` Greg KH
2026-11-20 19:24     ` [PATCH v3] " Mohammad Mosafer
2026-11-20 19:40       ` sashiko-bot [this message]
2026-11-20 19:46         ` [PATCH v4] " Mohammad Mosafer
2026-11-20 19:52           ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-225940@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mohsafer@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.