From: sashiko-bot@kernel.org
To: "Jesus Narvaez" <jesus.narvaez@intel.com>,
intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v5 1/2] drm/xe: Add has_sem64 bit to graphics/media IP descriptors
Date: Fri, 20 Nov 2026 19:45:11 +0000 [thread overview]
Message-ID: <sashiko-outbox-225952@kernel.org> (raw)
In-Reply-To: <20261120191111.4097737-5-jesus.narvaez@intel.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/xe: missing has_sem64 flag in graphics_xe3p_xpc
descriptor
--
commit 6227ca14d3bce991c8f5af40550a547f1e3e27ff
Author: Tangudu Tilak Tirumalesh <tilak.tirumalesh.tangudu@intel.com>
drm/xe: Add has_sem64 bit to graphics/media IP descriptors
This commit adds a has_sem64 capability flag to graphics and media IP
descriptors for Xe3p platforms and clears gt->info.has_sem64 on both GTs in
xe_info_init() if the primary and media GTs do not both support it.
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index 3bd68ed9daa81..a7ceb570d89af 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -127,6 +127,7 @@ static const struct xe_graphics_desc graphics_xe3p_lpg = {
> .multi_queue_engine_class_mask = BIT(XE_ENGINE_CLASS_COPY) | BIT(XE_ENGINE_CLASS_COMPUTE),
> .num_geometry_xecore_fuse_regs = 3,
> .num_compute_xecore_fuse_regs = 3,
> + .has_sem64 = 1,
> };
>
> static const struct xe_graphics_desc graphics_xe3p_xpc = {
> @@ -153,11 +154,20 @@ static const struct xe_media_desc media_xelpmp = {
> .hw_engine_mask =
> GENMASK(XE_HW_ENGINE_VCS7, XE_HW_ENGINE_VCS0) |
> GENMASK(XE_HW_ENGINE_VECS3, XE_HW_ENGINE_VECS0) |
> - BIT(XE_HW_ENGINE_GSCCS0)
> + BIT(XE_HW_ENGINE_GSCCS0),
> +};
> +
> +static const struct xe_media_desc media_xe3p_lpm = {
> + .hw_engine_mask =
> + GENMASK(XE_HW_ENGINE_VCS7, XE_HW_ENGINE_VCS0) |
> + GENMASK(XE_HW_ENGINE_VECS3, XE_HW_ENGINE_VECS0) |
> + BIT(XE_HW_ENGINE_GSCCS0),
> + .has_sem64 = 1,
> };
>
> static const struct xe_media_desc media_xe3p_hpm = {
> .has_uncorrectable_error_reporting = 1,
> + .has_sem64 = 1,
> .hw_engine_mask =
> GENMASK(XE_HW_ENGINE_VCS7, XE_HW_ENGINE_VCS0) |
> GENMASK(XE_HW_ENGINE_VECS3, XE_HW_ENGINE_VECS0) |
[Severity: Medium]
Should graphics_xe3p_xpc also set .has_sem64 = 1?
alloc_primary_gt() scopes the stepping B0 check specifically to graphics IP
35.10, and media_xe3p_hpm (media IP 35.03) enables .has_sem64 = 1. Because
Xe3p_HPM is paired with Xe3p_XPC (graphics IP 35.11) and xe_info_init()
clears has_sem64 on both GTs unless both set it, leaving .has_sem64 unset on
graphics_xe3p_xpc keeps has_sem64 disabled across the entire device on
Xe3p_XPC and makes media_xe3p_hpm.has_sem64 ineffective.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120191111.4097737-4-jesus.narvaez@intel.com?part=1
next prev parent reply other threads:[~2026-11-20 19:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 19:11 [PATCH v5 0/2] drm/xe: Handle GuC semaphore instruction field check error Jesus Narvaez
2026-11-20 19:11 ` [PATCH v5 1/2] drm/xe: Add has_sem64 bit to graphics/media IP descriptors Jesus Narvaez
2026-11-20 19:45 ` sashiko-bot [this message]
2026-11-20 19:11 ` [PATCH v5 2/2] drm/xe/guc: Handle GuC semaphore instruction field check error Jesus Narvaez
2026-11-20 19:23 ` ✗ CI.checkpatch: warning for drm/xe: Handle GuC semaphore instruction field check error (rev2) Patchwork
2026-11-20 19:25 ` ✓ CI.KUnit: success " Patchwork
2026-11-20 20:08 ` ✓ Xe.CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-225952@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jesus.narvaez@intel.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.