From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795204293; b=KSHmPNY4vgp1VGdFuYJ+xPVXc7vqrtFrWmaAqx33Rd4bmwOdENre6711GbVx190ctAwv b59UNBQaPOkHR+K5q5RZv47TWojQuVaUXwV5KYmC4av0QrEmo2SJdyGkjouICCHuWvga/ 5tvS6ddR8/VsroLf5JD9qKSj/yeqDEaQGITAQaOPGce8X92CaVyIhwfw2HpW6YzBxh7Lt /fRzmycd34LIwqtZj1E24AaJT2nmU5G4TUyiVzidrDnfGsVUesUuXXWgkLeSnSjQz6bcP Ya0zODWPSgV+R3GWIOS31z4uzH6LLTj+ddVY99Hy1FAG74qpta+hBWv9c4EfDnwdyVA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795204293; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=tOB4l80V9TFbQI02qDkKkXDt7nkgkAi8I6tdnu19nho=; b=1VOJ0wVmMH6C0wYJ9BxxRZuTIP8ut8yD/tsQHHLxkH+ibiw682TFLgyZRy+SIGnuNOTI T70BXnX8eo3jOogfZPSbm7kZeRhEyVMPkHUi2y2MKTgcr+ZluTaAPl0npBgjFUbk1mT6x wduyHm6Ry6ZBTl3OOG2Qjz6ib/qWj6ABBXwmcMOFeEFElB2J+Yun4rVVeKKx4dSa+yY9v czmqbAxN4y5+65ELQoHy1EgIPqvOO4OA9u068AFVJjApGnN9ydpe45ccoYcjuz1grDZ+u l8O8bDJ6vHPC611jthCriSSn5/uq/VziA8FLfWYWAGc3ctLh5vdlfCQOOIMAgSk0zmg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=UbPe1MBa; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53B30606A6C9; Fri, 20 Nov 2026 19:51:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=UbPe1MBa Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DFB71F000E6; Fri, 20 Nov 2026 19:51:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795204292; bh=tOB4l80V9TFbQI02qDkKkXDt7nkgkAi8I6tdnu19nho=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=UbPe1MBaowHN0HV2748sbZkosOY5sp4BtGOMIXf/ohUdci22v1RoW3xtDxXssBVRz A690F6e6D2X405UQS+aTyb08Gl6msGd/MSfAmJmHaqmkJ+40GCwucsZc47dLsXX+OF 0FHWcoR6lFjQosq6SsmLb2rtWBbHgREb+2gCotTBxU0aGHdhcUC8hhlZ9yDiLtHBFL iVeMaIp0ycNSZtdxQXP/HElxDaJ37GS7CTd/C5/T13BEcjpW5vpi0fCMW0ht+jgssH AV7dV+3JqfYZpwXiOHqwMsugmFdz/sXAIc5bqEO4gBy87U3YNt1gkZHRyRrnkKCGA1 Mt7yJ14gM9mOg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 3/6] pmdomain: zte: Add a zx297520v3 power domain driver Reply-To: sashiko-reviews@lists.linux.dev To: =?utf-8?b?U3RlZmFuIETDtnNpbmdlcg==?= Cc: devicetree@vger.kernel.org, mfd@lists.linux.dev, linux-phy@lists.infradead.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com, lee@kernel.org In-Reply-To: <20261120-zx29usb-v1-3-b0433258e51b@gmail.com> References: <20261120-zx29usb-v1-0-b0433258e51b@gmail.com> <20261120-zx29usb-v1-3-b0433258e51b@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 20 Nov 2026 19:51:31 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 2 potential issues to consider: - [High] pmdomain: zte: child-to-parent device link deadlock in zx29_pd_probe() - [High] pmdomain: zte: wrong supplier device in zx29_pd_attach_dev() device link -- commit 65d36c75a56ee45de3b21629f8434fb30bf2339b Author: Stefan D=C3=B6singer pmdomain: zte: Add a zx297520v3 power domain driver This commit adds a power domain driver for the ZTE zx297520v3 SoC to control the power, reset, and bus isolation registers for the USB controller. > diff --git a/drivers/pmdomain/zte/zx297520v3-pm-domain.c b/drivers/pmdoma= in/zte/zx297520v3-pm-domain.c > new file mode 100644 > index 0000000000000..3df4cd5f1b229 > --- /dev/null > +++ b/drivers/pmdomain/zte/zx297520v3-pm-domain.c [ ... ] > +static int zx29_pd_attach_dev(struct generic_pm_domain *domain, struct d= evice *dev) > +{ > + /* The DT link to the consumer targets the (MFD) parent, which doesn't = prevent unbinding the > + * this driver or removing the module. Either would leave the consumer = with a dangling > + * reference. > + */ > + if (!device_link_add(dev, &domain->dev, DL_FLAG_AUTOREMOVE_CONSUMER)) > + return -ENOMEM; > + > + return 0; > +} [Severity: High] Should the device link supplier here be the zx297520v3-socsys-power platform device (&pdev->dev) rather than &domain->dev? &domain->dev is the internal genpd provider device deleted by of_genpd_del_provider(). Because no consumer link targets &pdev->dev, unbinding this driver starts devres teardown while consumers are still bound and only unbinds them inside zx29_pd_release_provider() -> of_genpd_del_provider() -> device_del(&gpd->dev) under gpd_list_lock and of_genpd_mutex. That inverts the normal lock order against a probing consumer that already holds device_lock(consumer) while calling dev_pm_domain_attach() -> genpd_dev_pm_attach(): CPU0 CPU1 ---- ---- lock(&consumer->mutex) lock(&gpd_list_lock) lock(&of_genpd_mutex) lock(&gpd_list_lock) lock(&consumer->mutex) *** DEADLOCK *** CPU0: really_probe(consumer) -> ... -> genpd_get_from_provider() CPU1: zx29_pd_release_provider() -> of_genpd_del_provider() -> device_del(&gpd->dev) -> ... -> device_links_unbind_consumers() In addition, if a consumer attaches via genpd_dev_pm_attach_by_id() or genpd_dev_pm_attach_by_name(), dev is a driverless virtual device on genpd_bus_type, so its link to &domain->dev stays in DL_STATE_AVAILABLE: device_links_unbind_consumers() never detaches it, device_links_driver_cleanup() hits WARN_ON(), and pm_genpd_remove() fails with -EBUSY right before devres frees zx29_pd, leaving a freed generic_pm_domain on gpd_list. [ ... ] > +static int zx29_pd_probe(struct platform_device *pdev) > +{ [ ... ] > + res =3D of_genpd_add_provider_onecell(of_node, zx29_pd_data); > + if (res) > + return dev_err_probe(dev, res, "Cannot register power domains\n"); > + > + device_link_add(dev, dev->parent, DL_FLAG_AUTOREMOVE_CONSUMER); > + > + dev_dbg(dev, "zx297520v3 power domain initialized.\n"); > + > + return devm_add_action_or_reset(dev, zx29_pd_release_provider, of_node); > +} [Severity: High] Can adding a managed device link from dev to dev->parent deadlock when zx297520v3_crm_probe() registers its MFD children after late_initcall (for example on module load or driver rebind)? zx297520v3_crm_probe() calls devm_mfd_add_devices() while really_probe() holds device_lock(dev->parent). Because of_genpd_add_provider_onecell() sets genpd_sync_state on dev->parent, finishing dev's probe queues sync_state on dev->parent and tries to lock dev->parent again on the same thread: really_probe(dev->parent) device_lock(dev->parent) zx297520v3_crm_probe() devm_mfd_add_devices() ... really_probe(dev) zx29_pd_probe() of_genpd_add_provider_onecell(dev->parent->of_node, ...) device_link_add(dev, dev->parent, DL_FLAG_AUTOREMOVE_CONSUMER) driver_bound(dev) device_links_driver_bound(dev) device_links_flush_sync_list(..., dev) device_lock(dev->parent) <-- self-deadlock Since dev is a child device registered via devm_mfd_add_devices() on dev->parent, the driver core already orders suspend/resume and removes dev when dev->parent unbinds without this link. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261120-zx29usb-v1= -0-b0433258e51b@gmail.com?part=3D3 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7237C606A335 for ; Fri, 20 Nov 2026 19:51:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=FQM3PebM; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=UbPe1MBa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=vwa99Eqf/uAS3yEq2ZG7+KHC6Ub+v8b4lrF9VQbc2V0=; b=FQM3PebMN/A8fPaEP5crtXUHgU FESXp+LnQoVy8RHb+LntOg2m13Z8nr5eIpJb6hpPVD74m1/1Qw8L3RIEyoIlb43VqTNn+TZ54FX7d E7TZOhYGh0LQ5XtwD7PA2Vsiad8NG/xNuu9fXoI/mWIWnjeh40vgvegj34Zk+zmyhQ8owAOsCFyKX n9/WMwLCecUlbIaH/BRehS6Wk8oAftzUH9oy41aKwjutPTRuJh5bhbYLDKOUfgU+uchdcaJqXcwrs gIg4OqpQGl6qPAfU2zTn/ve5Pgs/jY1/8UjSqsqaiphFAj8SFCxBja0ICFEiUwE1Hyl0rgK+8cLdN cAT5QL1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUUe2-0000000G8PK-0FwO; Fri, 20 Nov 2026 19:51:38 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUUdy-0000000G8ON-1DgB for linux-phy@lists.infradead.org; Fri, 20 Nov 2026 19:51:36 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 45B79625B9; Fri, 20 Nov 2026 19:51:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DFB71F000E6; Fri, 20 Nov 2026 19:51:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795204292; bh=tOB4l80V9TFbQI02qDkKkXDt7nkgkAi8I6tdnu19nho=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=UbPe1MBaowHN0HV2748sbZkosOY5sp4BtGOMIXf/ohUdci22v1RoW3xtDxXssBVRz A690F6e6D2X405UQS+aTyb08Gl6msGd/MSfAmJmHaqmkJ+40GCwucsZc47dLsXX+OF 0FHWcoR6lFjQosq6SsmLb2rtWBbHgREb+2gCotTBxU0aGHdhcUC8hhlZ9yDiLtHBFL iVeMaIp0ycNSZtdxQXP/HElxDaJ37GS7CTd/C5/T13BEcjpW5vpi0fCMW0ht+jgssH AV7dV+3JqfYZpwXiOHqwMsugmFdz/sXAIc5bqEO4gBy87U3YNt1gkZHRyRrnkKCGA1 Mt7yJ14gM9mOg== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH 3/6] pmdomain: zte: Add a zx297520v3 power domain driver To: =?utf-8?b?U3RlZmFuIETDtnNpbmdlcg==?= Cc: devicetree@vger.kernel.org, mfd@lists.linux.dev, linux-phy@lists.infradead.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com, lee@kernel.org In-Reply-To: <20261120-zx29usb-v1-3-b0433258e51b@gmail.com> References: <20261120-zx29usb-v1-0-b0433258e51b@gmail.com> <20261120-zx29usb-v1-3-b0433258e51b@gmail.com> Date: Fri, 20 Nov 2026 19:51:31 +0000 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwKaXNzdWVzIHRvIGNvbnNpZGVyOgotIFtIaWdoXSBwbWRvbWFpbjogenRlOiBj aGlsZC10by1wYXJlbnQgZGV2aWNlIGxpbmsgZGVhZGxvY2sgaW4KICB6eDI5X3BkX3Byb2JlKCkK LSBbSGlnaF0gcG1kb21haW46IHp0ZTogd3Jvbmcgc3VwcGxpZXIgZGV2aWNlIGluIHp4MjlfcGRf YXR0YWNoX2RldigpCiAgZGV2aWNlIGxpbmsKLS0KCmNvbW1pdCA2NWQzNmM3NWE1NmVlNDVkZTNi MjE2MjlmODQzNGZiMzBiZjIzMzliCkF1dGhvcjogU3RlZmFuIETDtnNpbmdlciA8c3RlZmFuZG9l c2luZ2VyQGdtYWlsLmNvbT4KCnBtZG9tYWluOiB6dGU6IEFkZCBhIHp4Mjk3NTIwdjMgcG93ZXIg ZG9tYWluIGRyaXZlcgoKVGhpcyBjb21taXQgYWRkcyBhIHBvd2VyIGRvbWFpbiBkcml2ZXIgZm9y IHRoZSBaVEUgengyOTc1MjB2MyBTb0MgdG8KY29udHJvbCB0aGUgcG93ZXIsIHJlc2V0LCBhbmQg YnVzIGlzb2xhdGlvbiByZWdpc3RlcnMgZm9yIHRoZSBVU0IKY29udHJvbGxlci4KCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvcG1kb21haW4venRlL3p4Mjk3NTIwdjMtcG0tZG9tYWluLmMgYi9kcml2 ZXJzL3BtZG9tYWluL3p0ZS96eDI5NzUyMHYzLXBtLWRvbWFpbi5jCj4gbmV3IGZpbGUgbW9kZSAx MDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAwLi4zZGY0Y2Q1ZjFiMjI5Cj4gLS0tIC9kZXYvbnVs bAo+ICsrKyBiL2RyaXZlcnMvcG1kb21haW4venRlL3p4Mjk3NTIwdjMtcG0tZG9tYWluLmMKClsg Li4uIF0KCj4gK3N0YXRpYyBpbnQgengyOV9wZF9hdHRhY2hfZGV2KHN0cnVjdCBnZW5lcmljX3Bt X2RvbWFpbiAqZG9tYWluLCBzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gK3sKPiArCS8qIFRoZSBEVCBs aW5rIHRvIHRoZSBjb25zdW1lciB0YXJnZXRzIHRoZSAoTUZEKSBwYXJlbnQsIHdoaWNoIGRvZXNu J3QgcHJldmVudCB1bmJpbmRpbmcgdGhlCj4gKwkgKiB0aGlzIGRyaXZlciBvciByZW1vdmluZyB0 aGUgbW9kdWxlLiBFaXRoZXIgd291bGQgbGVhdmUgdGhlIGNvbnN1bWVyIHdpdGggYSBkYW5nbGlu Zwo+ICsJICogcmVmZXJlbmNlLgo+ICsJICovCj4gKwlpZiAoIWRldmljZV9saW5rX2FkZChkZXYs ICZkb21haW4tPmRldiwgRExfRkxBR19BVVRPUkVNT1ZFX0NPTlNVTUVSKSkKPiArCQlyZXR1cm4g LUVOT01FTTsKPiArCj4gKwlyZXR1cm4gMDsKPiArfQoKW1NldmVyaXR5OiBIaWdoXQpTaG91bGQg dGhlIGRldmljZSBsaW5rIHN1cHBsaWVyIGhlcmUgYmUgdGhlIHp4Mjk3NTIwdjMtc29jc3lzLXBv d2VyCnBsYXRmb3JtIGRldmljZSAoJnBkZXYtPmRldikgcmF0aGVyIHRoYW4gJmRvbWFpbi0+ZGV2 PwoKJmRvbWFpbi0+ZGV2IGlzIHRoZSBpbnRlcm5hbCBnZW5wZCBwcm92aWRlciBkZXZpY2UgZGVs ZXRlZCBieQpvZl9nZW5wZF9kZWxfcHJvdmlkZXIoKS4gIEJlY2F1c2Ugbm8gY29uc3VtZXIgbGlu ayB0YXJnZXRzICZwZGV2LT5kZXYsCnVuYmluZGluZyB0aGlzIGRyaXZlciBzdGFydHMgZGV2cmVz IHRlYXJkb3duIHdoaWxlIGNvbnN1bWVycyBhcmUgc3RpbGwKYm91bmQgYW5kIG9ubHkgdW5iaW5k cyB0aGVtIGluc2lkZSB6eDI5X3BkX3JlbGVhc2VfcHJvdmlkZXIoKSAtPgpvZl9nZW5wZF9kZWxf cHJvdmlkZXIoKSAtPiBkZXZpY2VfZGVsKCZncGQtPmRldikgdW5kZXIgZ3BkX2xpc3RfbG9jayBh bmQKb2ZfZ2VucGRfbXV0ZXguCgpUaGF0IGludmVydHMgdGhlIG5vcm1hbCBsb2NrIG9yZGVyIGFn YWluc3QgYSBwcm9iaW5nIGNvbnN1bWVyIHRoYXQgYWxyZWFkeQpob2xkcyBkZXZpY2VfbG9jayhj b25zdW1lcikgd2hpbGUgY2FsbGluZyBkZXZfcG1fZG9tYWluX2F0dGFjaCgpIC0+CmdlbnBkX2Rl dl9wbV9hdHRhY2goKToKCkNQVTAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBDUFUxCi0t LS0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtLS0tCmxvY2soJmNvbnN1bWVyLT5tdXRl eCkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxvY2soJmdwZF9saXN0X2xvY2sp CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsb2NrKCZvZl9nZW5wZF9tdXRleCkK bG9jaygmZ3BkX2xpc3RfbG9jaykKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxv Y2soJmNvbnN1bWVyLT5tdXRleCkKCiAqKiogREVBRExPQ0sgKioqCgpDUFUwOiByZWFsbHlfcHJv YmUoY29uc3VtZXIpIC0+IC4uLiAtPiBnZW5wZF9nZXRfZnJvbV9wcm92aWRlcigpCkNQVTE6IHp4 MjlfcGRfcmVsZWFzZV9wcm92aWRlcigpIC0+IG9mX2dlbnBkX2RlbF9wcm92aWRlcigpIC0+CiAg ICAgIGRldmljZV9kZWwoJmdwZC0+ZGV2KSAtPiAuLi4gLT4gZGV2aWNlX2xpbmtzX3VuYmluZF9j b25zdW1lcnMoKQoKSW4gYWRkaXRpb24sIGlmIGEgY29uc3VtZXIgYXR0YWNoZXMgdmlhIGdlbnBk X2Rldl9wbV9hdHRhY2hfYnlfaWQoKSBvcgpnZW5wZF9kZXZfcG1fYXR0YWNoX2J5X25hbWUoKSwg ZGV2IGlzIGEgZHJpdmVybGVzcyB2aXJ0dWFsIGRldmljZSBvbgpnZW5wZF9idXNfdHlwZSwgc28g aXRzIGxpbmsgdG8gJmRvbWFpbi0+ZGV2IHN0YXlzIGluIERMX1NUQVRFX0FWQUlMQUJMRToKZGV2 aWNlX2xpbmtzX3VuYmluZF9jb25zdW1lcnMoKSBuZXZlciBkZXRhY2hlcyBpdCwKZGV2aWNlX2xp bmtzX2RyaXZlcl9jbGVhbnVwKCkgaGl0cyBXQVJOX09OKCksIGFuZCBwbV9nZW5wZF9yZW1vdmUo KSBmYWlscwp3aXRoIC1FQlVTWSByaWdodCBiZWZvcmUgZGV2cmVzIGZyZWVzIHp4MjlfcGQsIGxl YXZpbmcgYSBmcmVlZApnZW5lcmljX3BtX2RvbWFpbiBvbiBncGRfbGlzdC4KClsgLi4uIF0KCj4g K3N0YXRpYyBpbnQgengyOV9wZF9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ ICt7CgpbIC4uLiBdCgo+ICsJcmVzID0gb2ZfZ2VucGRfYWRkX3Byb3ZpZGVyX29uZWNlbGwob2Zf bm9kZSwgengyOV9wZF9kYXRhKTsKPiArCWlmIChyZXMpCj4gKwkJcmV0dXJuIGRldl9lcnJfcHJv YmUoZGV2LCByZXMsICJDYW5ub3QgcmVnaXN0ZXIgcG93ZXIgZG9tYWluc1xuIik7Cj4gKwo+ICsJ ZGV2aWNlX2xpbmtfYWRkKGRldiwgZGV2LT5wYXJlbnQsIERMX0ZMQUdfQVVUT1JFTU9WRV9DT05T VU1FUik7Cj4gKwo+ICsJZGV2X2RiZyhkZXYsICJ6eDI5NzUyMHYzIHBvd2VyIGRvbWFpbiBpbml0 aWFsaXplZC5cbiIpOwo+ICsKPiArCXJldHVybiBkZXZtX2FkZF9hY3Rpb25fb3JfcmVzZXQoZGV2 LCB6eDI5X3BkX3JlbGVhc2VfcHJvdmlkZXIsIG9mX25vZGUpOwo+ICt9CgpbU2V2ZXJpdHk6IEhp Z2hdCkNhbiBhZGRpbmcgYSBtYW5hZ2VkIGRldmljZSBsaW5rIGZyb20gZGV2IHRvIGRldi0+cGFy ZW50IGRlYWRsb2NrIHdoZW4KengyOTc1MjB2M19jcm1fcHJvYmUoKSByZWdpc3RlcnMgaXRzIE1G RCBjaGlsZHJlbiBhZnRlciBsYXRlX2luaXRjYWxsCihmb3IgZXhhbXBsZSBvbiBtb2R1bGUgbG9h ZCBvciBkcml2ZXIgcmViaW5kKT8KCnp4Mjk3NTIwdjNfY3JtX3Byb2JlKCkgY2FsbHMgZGV2bV9t ZmRfYWRkX2RldmljZXMoKSB3aGlsZSByZWFsbHlfcHJvYmUoKQpob2xkcyBkZXZpY2VfbG9jayhk ZXYtPnBhcmVudCkuICBCZWNhdXNlIG9mX2dlbnBkX2FkZF9wcm92aWRlcl9vbmVjZWxsKCkKc2V0 cyBnZW5wZF9zeW5jX3N0YXRlIG9uIGRldi0+cGFyZW50LCBmaW5pc2hpbmcgZGV2J3MgcHJvYmUg cXVldWVzCnN5bmNfc3RhdGUgb24gZGV2LT5wYXJlbnQgYW5kIHRyaWVzIHRvIGxvY2sgZGV2LT5w YXJlbnQgYWdhaW4gb24gdGhlIHNhbWUKdGhyZWFkOgoKcmVhbGx5X3Byb2JlKGRldi0+cGFyZW50 KQogIGRldmljZV9sb2NrKGRldi0+cGFyZW50KQogIHp4Mjk3NTIwdjNfY3JtX3Byb2JlKCkKICAg IGRldm1fbWZkX2FkZF9kZXZpY2VzKCkKICAgICAgLi4uCiAgICAgICAgcmVhbGx5X3Byb2JlKGRl dikKICAgICAgICAgIHp4MjlfcGRfcHJvYmUoKQogICAgICAgICAgICBvZl9nZW5wZF9hZGRfcHJv dmlkZXJfb25lY2VsbChkZXYtPnBhcmVudC0+b2Zfbm9kZSwgLi4uKQogICAgICAgICAgICBkZXZp Y2VfbGlua19hZGQoZGV2LCBkZXYtPnBhcmVudCwgRExfRkxBR19BVVRPUkVNT1ZFX0NPTlNVTUVS KQogICAgICAgICAgZHJpdmVyX2JvdW5kKGRldikKICAgICAgICAgICAgZGV2aWNlX2xpbmtzX2Ry aXZlcl9ib3VuZChkZXYpCiAgICAgICAgICAgICAgZGV2aWNlX2xpbmtzX2ZsdXNoX3N5bmNfbGlz dCguLi4sIGRldikKICAgICAgICAgICAgICAgIGRldmljZV9sb2NrKGRldi0+cGFyZW50KSAgPC0t IHNlbGYtZGVhZGxvY2sKClNpbmNlIGRldiBpcyBhIGNoaWxkIGRldmljZSByZWdpc3RlcmVkIHZp YSBkZXZtX21mZF9hZGRfZGV2aWNlcygpIG9uCmRldi0+cGFyZW50LCB0aGUgZHJpdmVyIGNvcmUg YWxyZWFkeSBvcmRlcnMgc3VzcGVuZC9yZXN1bWUgYW5kIHJlbW92ZXMgZGV2CndoZW4gZGV2LT5w YXJlbnQgdW5iaW5kcyB3aXRob3V0IHRoaXMgbGluay4KCi0tIApTYXNoaWtvIEFJIHJldmlldyDC tyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjExMjAtengyOXVzYi12MS0wLWIw NDMzMjU4ZTUxYkBnbWFpbC5jb20/cGFydD0zCgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdAps aW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK