From: sashiko-bot@kernel.org
To: "Bartosz Golaszewski" <bartosz.golaszewski@oss.qualcomm.com>,
"Thara Gopinath" <thara.gopinath@gmail.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"Stanimir Varbanov" <svarbanov@mm-sol.com>,
"Eneas U de Queiroz" <cotequeiroz@gmail.com>,
"Kuldeep Singh" <kuldeep.singh@oss.qualcomm.com>,
"Eric Biggers" <ebiggers@kernel.org>,
"Demi Marie Obenour" <demiobenour@gmail.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Abel Vesa" <abelvesa@kernel.org>
Cc: linux-crypto@vger.kernel.org, brgl@kernel.org,
"Pankaj Patil" <pankaj.patil@oss.qualcomm.com>,
"Abel Vesa" <abel.vesa@oss.qualcomm.com>
Subject: Re: [PATCH v12 2/4] soc: qcom: add core driver for the Qualcomm Crypto Engine
Date: Fri, 20 Nov 2026 19:52:21 +0000 [thread overview]
Message-ID: <sashiko-outbox-225968@kernel.org> (raw)
In-Reply-To: <20261120-qce-fix-self-tests-v12-2-b5a2a44bc5ae@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] soc: qcom: missing Kconfig dependency and default for
QCOM_CRYPTO_CORE
--
commit 102209faf0f22bae7835821ad72826313dbef2e2
Author: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
soc: qcom: add core driver for the Qualcomm Crypto Engine
This commit adds the core platform driver for the Qualcomm Crypto Engine
to bind to the QCE devicetree node, manage interconnect scaling via
runtime PM, and register the crypto auxiliary device.
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index 535c8619197b3..67d54d5211ff2 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -121,6 +121,17 @@ config QCOM_PMIC_GLINK
> Say yes here to support USB-C and battery status on modern Qualcomm
> platforms.
>
> +config QCOM_CRYPTO_CORE
> + tristate "Qualcomm Crypto Engine core driver"
> + depends on PM
> + select AUXILIARY_BUS
> + help
> + Core driver for the Qualcomm Crypto Engine. Say yes here to enable
> + the top-level driver that binds to the devicetree node representing
> + the QCE, registers the sub-devices implementing actual QCE
> + functionalities and sets up runtime PM allowing the interconnects to
> + scale down.
[Severity: Medium]
Should QCOM_CRYPTO_CORE have a default (or be depended on or selected by
CRYPTO_DEV_QCE) so that existing configs with CONFIG_CRYPTO_DEV_QCE
enabled keep working after commit "crypto: qce - convert to auxiliary
bus"?
Without a default or a dependency from CRYPTO_DEV_QCE, updating an
existing config leaves CONFIG_QCOM_CRYPTO_CORE disabled, so nothing
binds to the QCE devicetree node or creates the qce.crypto auxiliary
device that the crypto driver now binds to.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-qce-fix-self-tests-v12-0-b5a2a44bc5ae@oss.qualcomm.com?part=2
next prev parent reply other threads:[~2026-11-20 19:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 19:34 [PATCH v12 0/4] crypto: qce - Split the crypto driver into core and crypto parts Bartosz Golaszewski
2026-11-20 19:34 ` [PATCH v12 1/4] crypto: qce - convert to auxiliary bus Bartosz Golaszewski
2026-11-20 19:34 ` [PATCH v12 2/4] soc: qcom: add core driver for the Qualcomm Crypto Engine Bartosz Golaszewski
2026-11-20 19:52 ` sashiko-bot [this message]
2026-11-20 19:34 ` [PATCH v12 3/4] arm64: defconfig: update the Qualcomm Crypto Engine entry Bartosz Golaszewski
2026-11-20 19:34 ` [PATCH v12 4/4] arm: multi_v7_defconfig: " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-225968@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=abel.vesa@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=cotequeiroz@gmail.com \
--cc=davem@davemloft.net \
--cc=demiobenour@gmail.com \
--cc=ebiggers@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=konradybcio@kernel.org \
--cc=kuldeep.singh@oss.qualcomm.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=pankaj.patil@oss.qualcomm.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=svarbanov@mm-sol.com \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.