All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
Cc: linux-rt-devel@lists.linux.dev, tj@kernel.org,
	hannes@cmpxchg.org, mkoutny@suse.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 26/40] sched/deadline: Replenish a throttled task boosted while asleep
Date: Fri, 20 Nov 2026 21:22:27 +0000	[thread overview]
Message-ID: <sashiko-outbox-226168@kernel.org> (raw)
In-Reply-To: <9c0cc7d7c43e0562a9fc9f363898178b36c6e9c2.1795207232.git.mathieu.desnoyers@efficios.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] sched/deadline: missing dl_note_donor_refill() in
  replenish_dl_entity()
- [Medium] sched/deadline: dl_task_timer() refills sleeping task from
  donor parameters
--

commit c9c72591d4a367d03f9bada51027022e7fbe7e42
Author: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

sched/deadline: Replenish a throttled task boosted while asleep

This commit lets dl_task_timer() replenish a throttled task that was PI
boosted while sleeping instead of returning early before clearing
dl_throttled.

> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index 2912d13b60d60..9a4639ae676a4 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -1705,10 +1705,13 @@ static enum hrtimer_restart dl_task_timer(struct hrtimer *timer)
>  	}
>  
>  	/*
> -	 * The task might have been boosted by someone else and might be in the
> -	 * boosting/deboosting path, its not throttled.
> +	 * A boost overrides the throttle. enqueue_task_dl() lifts it when the
> +	 * boost enqueues the task, or when the task wakes up boosted. So a
> +	 * queued task needs nothing here. A boost of a sleeping task does not
> +	 * enqueue it, and it can end before the wakeup. Nothing would lift the
> +	 * throttle then. So let a sleeping task reach the !queued case below.
>  	 */
> -	if (is_dl_boosted(dl_se) && task_on_rq_queued(p))
> +	if (is_dl_boosted(dl_se) && task_on_rq_queued(p))
>  		goto unlock;

[Severity: Medium]
Can replenish_dl_entity() leave dl_se->dl_donor_refill unset when a
sleeping SCHED_DEADLINE task's donor has its parameters cleared before
dl_task_timer() fires?

If the donor leaves SCHED_DEADLINE and reaches its 0-lag time before the
rt_mutex chain walk finishes deboosting the sleeping owner,
replenish_dl_entity() takes the cleared-parameter branch:

kernel/sched/deadline.c:replenish_dl_entity() {
	if (unlikely(!runtime || !deadline || !period)) {
		WARN_ON_ONCE(!is_dl_boosted(dl_se));
		if (!dl_se->dl_deadline) {
			dl_se->deadline = rq_clock(rq);
			dl_se->runtime = 0;
			dl_note_donor_refill(dl_se);
		}
		if (dl_se->runtime < 0 || dl_se->dl_yielded)
			dl_se->runtime = 0;
		dl_se->dl_yielded = 0;
		dl_se->dl_throttled = 0;
		return;
	}

Because a SCHED_DEADLINE owner has dl_se->dl_deadline != 0, it skips
dl_note_donor_refill(dl_se) while zeroing runtime and clearing
dl_throttled.  When dl_deboost() then runs, dl_se->dl_donor_refill is 0, so
it does not start a new period of the task's own reservation, leaving the
owner with runtime == 0 and a stale past deadline that prevents remaining
deadline waiters from re-boosting it.  Calling dl_note_donor_refill(dl_se)
and updating dl_se->deadline unconditionally in the cleared-parameter branch
would ensure dl_deboost() resets the owner's reservation.

[Severity: Medium]
Does calling replenish_dl_entity() from dl_task_timer() refill a sleeping
task's pre-boost runtime debt using the donor's parameters?

A boosted task is never throttled with dl_timer armed while boosted, so a
task reaching dl_task_timer() with is_dl_boosted(dl_se) &&
!task_on_rq_queued(p) was throttled on its own reservation as it went to
sleep and has consumed no runtime while boosted.  However,
replenish_dl_entity() reads runtime and period from pi_of(dl_se) and calls
dl_note_donor_refill(dl_se):

kernel/sched/deadline.c:replenish_dl_entity() {
	if (dl_se->runtime <= 0)
		dl_note_donor_refill(dl_se);

	while (dl_se->runtime <= 0) {
		dl_se->deadline += period;
		dl_se->runtime += runtime;
	}

If the sleeping owner overran its own large runtime and is boosted by a
waiter with a small dl_runtime, the loop pays back the owner's pre-boost
overrun in increments of the donor's runtime and period, pushing
dl_se->deadline multiple donor periods into the future so the owner runs
with a far-future deadline upon wakeup instead of the donor's urgent
deadline.  Conversely, if the waiter times out before the owner wakes up,
dl_deboost() sees dl_se->dl_donor_refill set, grants a fresh full period
that erases the owner's pre-boost overrun, and cancels inactive_timer early
to drop running_bw before the true 0-lag time.  In addition, with later
commit "sched/deadline: Boost an owner that cannot run on its own
reservation", dl_boost_start() saves the throttled sleeping task's
negative own_runtime and expired own_deadline with dl_boost_held = 1, and
dl_deboost() restores those unreplenished values after dl_task_timer() has
already cleared dl_throttled.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1795207232.git.mathieu.desnoyers@efficios.com?part=26

  reply	other threads:[~2026-11-20 21:22 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 20:41 [PATCH v10 00/40] sched/deadline: bandwidth accounting fixes and selftests Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 01/40] sched/deadline: Keep departing bandwidth across a root domain rebuild Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 02/40] sched/deadline: Rebuild the root domains' accounting from the task list Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 03/40] sched/deadline: Record the root domain holding a task's bandwidth Mathieu Desnoyers
2026-11-20 21:18   ` sashiko-bot
2026-11-20 20:41 ` [PATCH v10 04/40] sched/deadline: Leave a dying task out of a rebuild of the accounting Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 05/40] selftests/sched: Test SCHED_DEADLINE bandwidth across a root domain rebuild Mathieu Desnoyers
2026-11-20 21:12   ` sashiko-bot
2026-11-20 20:41 ` [PATCH v10 06/40] selftests/sched: Test the root domain rebuild in deadline_bw_test Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 07/40] sched/deadline: Move a task's bandwidth only where room was made Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 08/40] cgroup/cpuset: Wait for an attach before rebuilding the sched domains Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 09/40] sched: Make deadline policy and affinity changes wait for a cpuset attach Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 10/40] cgroup/cpuset: Give back the bandwidth an attach did not move Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 11/40] cgroup/cpuset: Reserve the bandwidth in the root domain a task moves to Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 12/40] selftests/sched: Test cpuset moves in deadline_bw_test Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 13/40] sched/deadline: Make a rebuild count a task in the root domain it runs in Mathieu Desnoyers
2026-11-20 21:11   ` sashiko-bot
2026-11-20 20:41 ` [PATCH v10 14/40] sched/deadline: Move a task's bandwidth to " Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 15/40] sched/deadline: Keep a task in the root domain that counts its bandwidth Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 16/40] sched/deadline: Keep the last CPU a task has in its root domain Mathieu Desnoyers
2026-11-20 21:19   ` sashiko-bot
2026-11-20 20:41 ` [PATCH v10 17/40] cgroup/cpuset: Refuse to take a deadline task out of " Mathieu Desnoyers
2026-11-20 21:22   ` sashiko-bot
2026-11-20 20:41 ` [PATCH v10 18/40] selftests/sched: Test the root domain of a task in deadline_bw_test Mathieu Desnoyers
2026-11-20 20:54   ` sashiko-bot
2026-11-20 20:41 ` [PATCH v10 19/40] sched/deadline: Count only active CPUs when spreading extra_bw Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 20/40] sched/deadline: Do not truncate a bandwidth to 32 bits in __dl_add/sub() Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 21/40] rtmutex: Continue the chain walk when a waiter's deadline donor changes Mathieu Desnoyers
2026-11-20 20:41 ` [PATCH v10 22/40] rtmutex: Do not stop the chain walk at an owner whose top waiter changed Mathieu Desnoyers
2026-11-20 20:42 ` [PATCH v10 23/40] sched/deadline: Hold a reference on the deadline donor of a boosted task Mathieu Desnoyers
2026-11-20 20:42 ` [PATCH v10 24/40] selftests/sched: Test the rtmutex chain walk in deadline_bw_test Mathieu Desnoyers
2026-11-20 21:06   ` sashiko-bot
2026-11-20 20:42 ` [PATCH v10 25/40] sched/deadline: Reset the donor's runtime at a deboost in the class Mathieu Desnoyers
2026-11-20 20:42 ` [PATCH v10 26/40] sched/deadline: Replenish a throttled task boosted while asleep Mathieu Desnoyers
2026-11-20 21:22   ` sashiko-bot [this message]
2026-11-20 20:42 ` [PATCH v10 27/40] sched/deadline: Count the bandwidth a boosted task is given Mathieu Desnoyers
2026-11-20 20:42 ` [PATCH v10 28/40] sched/deadline: Start a period for a task that enters the class blocked Mathieu Desnoyers
2026-11-20 21:21   ` sashiko-bot
2026-11-20 20:42 ` [PATCH v10 29/40] sched/deadline: Start a period at a deboost out of the class Mathieu Desnoyers
2026-11-20 20:42 ` [PATCH v10 30/40] sched/deadline: Start a period for a task requeued onto an rt_mutex Mathieu Desnoyers
2026-11-20 21:24   ` sashiko-bot
2026-11-20 20:42 ` [PATCH v10 31/40] selftests/sched: Test deadline boosts in deadline_bw_test Mathieu Desnoyers
2026-11-20 21:08   ` sashiko-bot
2026-11-20 20:42 ` [PATCH v10 32/40] sched/deadline: Cancel the replenishment timer with the parameters Mathieu Desnoyers
2026-11-20 20:42 ` [PATCH v10 33/40] sched/deadline: Cap the runtime left of a constrained task at dl_runtime Mathieu Desnoyers
2026-11-20 20:42 ` [PATCH v10 34/40] sched/deadline: Check the runtime of a task that comes back runnable Mathieu Desnoyers
2026-11-20 20:42 ` [PATCH v10 35/40] sched/deadline: Check the runtime of a task whose parameters change Mathieu Desnoyers
2026-11-20 20:42 ` [PATCH v10 36/40] sched/deadline: Reschedule a running task throttled at its enqueue Mathieu Desnoyers
2026-11-20 20:42 ` [PATCH v10 37/40] sched/deadline: Keep the start of the period across a change of dl_deadline Mathieu Desnoyers
2026-11-20 21:21   ` sashiko-bot
2026-11-20 20:42 ` [PATCH v10 38/40] sched/deadline: Boost an owner that cannot run on its own reservation Mathieu Desnoyers
2026-11-20 20:42 ` [PATCH v10 39/40] selftests/sched: Test parameter changes in deadline_bw_test Mathieu Desnoyers
2026-11-20 20:42 ` [PATCH v10 40/40] selftests/sched: Share the helpers of the deadline tests Mathieu Desnoyers
2026-11-20 21:15   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-226168@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mkoutny@suse.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.