All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Apurv Mishra" <Apurv.Mishra@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdkfd: Don't require a VM for the profiler PMC lock
Date: Fri, 20 Nov 2026 21:58:18 +0000	[thread overview]
Message-ID: <sashiko-outbox-226214@kernel.org> (raw)
In-Reply-To: <20261120214925.211726-1-Apurv.Mishra@amd.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/amdkfd: missing Fixes trailer for commit 8a2a98891184
--

commit 28d61bf0c9928d470a0760fe0edf0322918e49c9
Author: Apurv Mishra <Apurv.Mishra@amd.com>

> drm/amdkfd: Don't require a VM for the profiler PMC lock
>
> The profiler PMC requests now go through kfd_bind_process_to_device() for a
> runtime PM reference, but that also requires a VM on the GPU. A process
> that takes the lock before AMDKFD_IOC_ACQUIRE_VM, as rocprofiler-sdk can,
> now gets -ENODEV.
>
> Take only the runtime PM reference, through a new
> kfd_process_device_runtime_get() method that kfd_bind_process_to_device()
> uses as well.
>
> Signed-off-by: Apurv Mishra <Apurv.Mishra@amd.com>

[Severity: Low]
This fixes the -ENODEV failure introduced when profile_lock_device() and
kfd_profiler_perfmon_clk() began calling kfd_bind_process_to_device().
Should the commit message include a Fixes tag?

  Fixes: 8a2a98891184 ("drm/amdkfd: Force perfmon clock on for profiler PMC requests")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120214925.211726-1-Apurv.Mishra@amd.com?part=1

      reply	other threads:[~2026-11-20 21:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 21:49 [PATCH] drm/amdkfd: Don't require a VM for the profiler PMC lock Apurv Mishra
2026-11-20 21:58 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-226214@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Apurv.Mishra@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.