From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795214678; b=sLZUez4StwkUchQC/uOjGxPyaEk/5P7Iqyo4vD/+PCgnaoyKMCA0+N4Hwkwtu5xsZIU3 QFixBNAhKN3GSOh8GiNG6ivmsZezZ76DXHxz7WWCjlfAck8XvVsUir4wz+j6driHzTcUR 5J7lfDKzagE/gwr9yr1c+Mf5AiT5E1i+nj2t1WVOdSKxFGVfUkjHrqdQYnhLeDp3XJEt7 pDpZMvt8xQzhsL8uMP0amj99U4qAFR0QpIw67+kZLXPdyxtEPL2zGlQ2H5L32K9jnv0+k Ah31Uwd4vC8AAVWVhCiQmhjNjqC0mx9606FtEA022Yqls0Ap6fwMgOd0DxVqFietQVQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795214678; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=pSzNYLdaadW2jyufCcL13Oj3VYC0HwF6Ept2g9RqzPg=; b=Ye4bHpmkr2jxHlOlHVBmh65xe4AcgGsprZf7StGXHqckxK0w2Iwtl0NZen/PlX09paI2 A3etnZdxzrMgjaaoQpq5hYZo/KxzaZ876M9fTh6YWnt5Z5s6sOEGliagcjggtIppNbBZ/ F3ZuUimA1chdXGEcdAofPOmfxZ336JG5ZAX9JPGxykdr5kr2NySTXgXyAHtpQ+ptg+TpL 0XHkZLY+6f/5S3piE78pdbegiWvKPsH45g5CazXHFfOMCkOaIYCCGwNIzJVSXuX+ifhlQ Xj+PsVDndgordkn8HlluHMNIcOhc02eXqtQCRcRTH+mHpodp3TaEpC+fGMiiAhd1E8g== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Qup3hZLM; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E0B7606A699 for ; Fri, 20 Nov 2026 22:44:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Qup3hZLM Received: by smtp.kernel.org (Postfix) with ESMTPSA id C860C1F000C6; Fri, 20 Nov 2026 22:44:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795214677; bh=pSzNYLdaadW2jyufCcL13Oj3VYC0HwF6Ept2g9RqzPg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Qup3hZLMjJGy5Lby+02cC0Ks/w7DT7TF3QjQNKtLYIrpYBfrZFUyGinpDBZuHfkAi goJrpXp+gmkyCkj2JGhkb1jpnlX++Ja7j/A0y3YyPT1+NmGWQHVbUctnH/DTeGipYr cGfwI4AoENAdwdU0aF5VIdJLrOXZ8+3U76DRE12JxoCHMAbfJD27kbX9glPmUmwoVv x4pgmw3sdleN3TVxBg/sktHSOTGoErQgtvQ/2hZ+V6tNnxeys73mlAdroPHMmL/o2s CKQbuo4r4FV4JwF2Idjbka4Xb0uMahKxADIfW4RwvlkUYkwS2MkHZ17TDxpTswtEwA +ubPXlAFfK0LQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [RFC PATCH v4 05/14] rootns: Add ROOTNS_WAIT ioctl Reply-To: sashiko-reviews@lists.linux.dev To: "Jarkko Sakkinen" Cc: linux-mm@kvack.org, linux-security-module@vger.kernel.org, "Albert Ou" , "Alexander Gordeev" , "Alexander Viro" , "Alexandre Ghiti" , "Andreas Larsson" , "Andrew Morton" , "Andy Lutomirski" , "Andy Lutomirski" , "Anna-Maria Behnsen" , "Arnd Bergmann" , "Ben Segall" , "Borislav Petkov" , "Casey Schaufler" , "Catalin Marinas" , "Christian Borntraeger" , "Christian Brauner" , =?utf-8?b?Q2hyaXN0b3BoZSBMZXJveSAoQ1Mg?= =?utf-8?b?R1JPVVAp?= , "Chris Zankel" , "Dave Hansen" , "David Hildenbrand" , "David Howells" , "Davidlohr Bueso" , "David S. Miller" , "Dietmar Eggemann" , "Frederic Weisbecker" , "Geert Uytterhoeven" , "Hallgrimur H. Gunnarsson" , "Heiko Carstens" , "Helge Deller" , "H. Peter Anvin" , "Ingo Molnar" , "James E.J. Bottomley" , "Jan Kara" , "John Johansen" , "John Paul Adrian Glaubitz" , "Jonathan Corbet" , "Josef Bacik" , "Juri Lelli" , "Kees Cook" , "K Prateek Nayak" , "Liam R. Howlett" , "Lorenzo Stoakes" , "Madhavan Srinivasan" , "Magnus Lindholm" , "Manfred Spraul" , "Mark Rutland" , "Matt Turner" , "Max Filippov" , "Mel Gorman" , "Michael Ellerman" , "Michal Hocko" , "Michal Simek" , "Mike Rapoport" , "Neal Gompa" , "Nicholas Piggin" , "Palmer Dabbelt" , "Paul Moore" , "Paul Walmsley" , "Pavel Tikhomirov" , "Peter Zijlstra" , "Randy Dunlap" , "Richard Henderson" , "Rich Felker" , =?utf-8?b?Uml0ZXNoIEhhcmphbmkgKElCTSk=?= , "Russell King" , "Serge Hallyn" , "Shrikanth Hegde" , "Shuah Khan" , "Steven Rostedt" , "Suren Baghdasaryan" , "Sven Schnelle" , "Thomas Bogendoerfer" , "Thomas Gleixner" , "Valentin Schneider" , "Vasily Gorbik" , "Vincent Guittot" , "Vincenzo Frascino" , "Vlastimil Babka" , "Will Deacon" , "Yoshinori Sato" , "Zygmunt Krynicki" In-Reply-To: <20261119224312.1037966-6-jarkko@kernel.org> References: <20261119224312.1037966-1-jarkko@kernel.org> <20261119224312.1037966-6-jarkko@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 20 Nov 2026 22:44:33 +0000 X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Medium] rootns: delayed PID namespace visibility check in rootns_wait() -- commit 68c6e4532ee164e48940d00824536de847b1c5d0 Author: Jarkko Sakkinen rootns: Add ROOTNS_WAIT ioctl This commit adds the ROOTNS_WAIT ioctl to wait for a root namespace's init thread group to exit and retrieve its wait status and TGID. > diff --git a/kernel/rootns.c b/kernel/rootns.c > index d9ef68d603a24..5f03b6ba4a543 100644 > --- a/kernel/rootns.c > +++ b/kernel/rootns.c > @@ -115,6 +115,45 @@ static long rootns_get_nsfd(struct rootns *rootns, u= nsigned long nstype) > return nsproxy_open_namespace(rootns->ns, rootns->user_ns, nstype); > } > =20 > +static long rootns_wait(struct rootns *rootns, void __user *uarg) > +{ > + struct pid_namespace *pid_ns =3D task_active_pid_ns(current); > + struct rootns_wait_args args; > + long ret; > + > + if (!uarg) > + return -EINVAL; > + if (copy_from_user(&args, uarg, sizeof(args))) > + return -EFAULT; > + if (args.flags & ~WNOHANG) > + return -EINVAL; > + if (READ_ONCE(rootns->state) =3D=3D ROOTNS_INIT) > + return -ECHILD; > + > + if (!(args.flags & WNOHANG)) { > + ret =3D wait_event_freezable(rootns->waitq, > + READ_ONCE(rootns->state) =3D=3D ROOTNS_DEAD || > + READ_ONCE(rootns->state) =3D=3D ROOTNS_INIT); > + if (ret) > + return ret; > + } > + > + scoped_guard(spinlock, &rootns->lock) { > + if (rootns->state =3D=3D ROOTNS_INIT) > + return -ECHILD; > + if (rootns->state !=3D ROOTNS_DEAD) > + return 0; > + ret =3D pid_nr_ns(rootns->init_pid, pid_ns); > + if (ret <=3D 0) > + return -ECHILD; [Severity: Medium] Should rootns_wait() check whether the rootns PID namespace is visible in pid_ns before waiting or returning 0 for WNOHANG? Because pid_nr_ns() is only checked after rootns->state reaches ROOTNS_DEAD, a caller in a non-ancestor PID namespace gets 0 instead of -ECHILD when calling ROOTNS_WAIT with WNOHANG on a running rootns, and a blocking call sleeps in wait_event_freezable() until init exits before failing with -ECHILD. Checking pidns_is_ancestor(rootns->ns->pid_ns_for_children, pid_ns) upfront (as in rootns_get_nsfd()) would reject invisible targets immediately. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261119224312.1037= 966-1-jarkko@kernel.org?part=3D5