All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Arnaldo Carvalho de Melo" <acme@kernel.org>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v10 07/16] perf tests: Exercise the x86 operand parser
Date: Sat, 21 Nov 2026 03:29:02 +0000	[thread overview]
Message-ID: <sashiko-outbox-226583@kernel.org> (raw)
In-Reply-To: <20261121032052.1392234-8-acme@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] perf tests: check_movabs() fails when built without
  HAVE_LIBDW_SUPPORT
--

commit 74653224cba4e46d55b956a2e180f6f29cb4d93b
Author: Arnaldo Carvalho de Melo <acme@redhat.com>

perf tests: Exercise the x86 operand parser

This commit adds a unit test for the x86 operand parser covering absolute
addressing, immediate operands, direct branch targets, and movabs
instructions.

> diff --git a/tools/perf/tests/annotate-ops.c b/tools/perf/tests/annotate-ops.c
> new file mode 100644
> index 0000000000000..1c73433fbac67
> --- /dev/null
> +++ b/tools/perf/tests/annotate-ops.c
[ ... ]
> +static int check_movabs(const struct arch *arch, const char *name, const char *ops)
> +{
> +	struct disasm_line dl = { .ins = { .name = name } };
> +	struct annotated_insn_loc loc;
> +	int ret = TEST_FAIL;
> +
> +	dl.ops.raw = strdup(ops);
> +	if (dl.ops.raw == NULL)
> +		return TEST_FAIL;
> +
> +	dl.ins.ops = ins__find(arch, name, &dl);
> +	if (dl.ins.ops != &mov_ops || dl.ins.ops->parse(arch, &dl.ops, NULL, &dl) < 0) {
> +		pr_debug("'%s %s': not parsed as a mov\n", name, ops);
> +		goto out;
> +	}
> +
> +	if (annotate_get_insn_location(arch, &dl, &loc) == 0 &&
> +	    !loc.ops[INSN_OP_SOURCE].mem_ref && loc.ops[INSN_OP_SOURCE].imm &&
> +	    loc.ops[INSN_OP_TARGET].reg1 != -1)
> +		ret = TEST_OK;
> +	else
> +		pr_debug("'%s %s': not an immediate to a register\n", name, ops);

[Severity: Medium]
Will check_movabs() fail when perf is built without HAVE_LIBDW_SUPPORT
(for example with NO_LIBDW=1)?

extract_op_location_x86() resolves %r15 via arch__dwarf_regnum() ->
get_dwarf_regnum(), which is a stub returning -1 in
tools/perf/util/include/dwarf-regs.h when HAVE_LIBDW_SUPPORT is not
defined, leaving loc.ops[INSN_OP_TARGET].reg1 at -1 while the test suite is
built and registered unconditionally.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261121032052.1392234-1-acme@kernel.org?part=7

  reply	other threads:[~2026-11-21  3:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21  3:20 [PATCH v10 00/16] perf coverage: A harness for perf, and the fixes it found Arnaldo Carvalho de Melo
2026-11-21  3:20 ` [PATCH v10 01/16] perf build: Link the GTK UI with EXTRA_CFLAGS Arnaldo Carvalho de Melo
2026-11-21  3:20 ` [PATCH v10 02/16] perf annotate: Handle absolute addressing in data type profiling Arnaldo Carvalho de Melo
2026-11-21  3:20 ` [PATCH v10 03/16] perf annotate: Print the stats after the annotations Arnaldo Carvalho de Melo
2026-11-21  3:20 ` [PATCH v10 04/16] perf build: Record the features checked outside FEATURE_TESTS Arnaldo Carvalho de Melo
2026-11-21  3:20 ` [PATCH v10 05/16] perf annotate-x86: Parse movabs like a mov Arnaldo Carvalho de Melo
2026-11-21  3:20 ` [PATCH v10 06/16] perf annotate-data: Count flexible array accesses for the whole struct Arnaldo Carvalho de Melo
2026-11-21  3:20 ` [PATCH v10 07/16] perf tests: Exercise the x86 operand parser Arnaldo Carvalho de Melo
2026-11-21  3:29   ` sashiko-bot [this message]
2026-11-21  3:20 ` [PATCH v10 08/16] perf tests: Exercise DW_OP_addrx global variables Arnaldo Carvalho de Melo
2026-11-21  3:20 ` [PATCH v10 09/16] perf tests: Exercise the flexible array member path Arnaldo Carvalho de Melo
2026-11-21  3:20 ` [PATCH v10 10/16] perf tests: Exercise data type resolution from a register Arnaldo Carvalho de Melo
2026-11-21  3:20 ` [PATCH v10 11/16] perf tests: Exercise the annotate stats output Arnaldo Carvalho de Melo
2026-11-21  3:30   ` sashiko-bot
2026-11-21  3:20 ` [PATCH v10 12/16] perf tests: Fix the Intel PT virtual LBR check Arnaldo Carvalho de Melo
2026-11-21  3:20 ` [PATCH v10 13/16] perf test: Drop samples without an IP in the dlfilter test Arnaldo Carvalho de Melo
2026-11-21  3:20 ` [PATCH v10 14/16] perf test: Skip the LBR inline unwinding check when unsupported Arnaldo Carvalho de Melo
2026-11-21  3:20 ` [PATCH v10 15/16] perf scripts: Add a coverage harness for perf Arnaldo Carvalho de Melo
2026-11-21  3:36   ` sashiko-bot
2026-11-21  3:20 ` [PATCH v10 16/16] perf scripts: Add a coverage table Arnaldo Carvalho de Melo
2026-11-21  3:34   ` sashiko-bot
2026-11-21  3:36 ` [PATCH v10 00/16] perf coverage: A harness for perf, and the fixes it found sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-226583@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=acme@kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.