All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Alfonso Villalobos Ulate" <alfonsocvu@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] thunderbolt: Re-add host router DP IN adapters after DPRX failure
Date: Sat, 21 Nov 2026 07:25:42 +0000	[thread overview]
Message-ID: <sashiko-outbox-226770@kernel.org> (raw)
In-Reply-To: <20261121070804.26185-1-alfonsocvu@gmail.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] thunderbolt: missing tb_exit_redrive() in
  tb_add_dp_resources() leaks RPM ref
- [Medium] thunderbolt: list_add_tail() in tb_dp_resource_available()
  breaks DP IN order
--

commit 4eedd8886dc180b45204d935f18725051dd0e6a0
Author: Alfonso Villalobos Ulate <alfonsocvu@gmail.com>

thunderbolt: Re-add host router DP IN adapters after DPRX failure

This commit re-checks host router DP IN adapters when a new DP OUT adapter
becomes available or a device router is scanned, keeping host DP IN
adapters ordered by adapter number on tcm->dp_resources.

> diff --git a/drivers/thunderbolt/tb.c b/drivers/thunderbolt/tb.c
> index 418ad0a61a5de..1f3dea836067e 100644
> --- a/drivers/thunderbolt/tb.c
> +++ b/drivers/thunderbolt/tb.c
> @@ -109,6 +109,29 @@ static void tb_queue_hotplug(struct tb *tb, u64 route, u8 port, bool unplug)
>  
>  /* enumeration & hot plug handling */
>  
> +/*
> + * Insert a host router DP IN adapter so that host DP IN adapters stay
> + * in adapter number order. A DP IN that is re-added after it was
> + * dropped (for example because DPRX negotiation failed) then gets
> + * paired with the same DP OUT as before, instead of swapping DP OUT
> + * adapters (and therefore monitors) with the other host DP IN.
> + */
> +static void tb_add_host_dp_in(struct tb_cm *tcm, struct tb_port *port)
> +{
> +	struct tb_port *p;
> +
> +	list_for_each_entry(p, &tcm->dp_resources, list) {
> +		if (tb_port_is_dpin(p) && !tb_route(p->sw) &&
> +		    p->port > port->port) {
> +			/* Insert before the first higher numbered one */
> +			list_add_tail(&port->list, &p->list);
> +			return;
> +		}
> +	}
> +
> +	list_add_tail(&port->list, &tcm->dp_resources);
> +}
> +
>  static void tb_add_dp_resources(struct tb_switch *sw)
>  {
>  	struct tb_cm *tcm = tb_priv(sw->tb);
> @@ -118,6 +141,9 @@ static void tb_add_dp_resources(struct tb_switch *sw)
>  		if (!tb_port_is_dpin(port))
>  			continue;
>  
> +		if (!list_empty(&port->list))
> +			continue;
> +
>  		if (!tb_switch_query_dp_resource(sw, port))
>  			continue;
>  
> @@ -130,7 +156,7 @@ static void tb_add_dp_resources(struct tb_switch *sw)
>  		if (tb_route(sw))
>  			list_add(&port->list, &tcm->dp_resources);
>  		else
> -			list_add_tail(&port->list, &tcm->dp_resources);
> +			tb_add_host_dp_in(tcm, port);
>  
>  		tb_port_dbg(port, "DP IN resource available\n");
>  	}

[Severity: Medium]
Does re-adding a host router DP IN port through tb_add_dp_resources() leak
the runtime PM reference on sw->dev when the port was in redrive mode?

On host routers with QUIRK_KEEP_POWER_IN_DP_REDRIVE, tb_enter_redrive()
sets port->redrive and calls pm_runtime_get(&sw->dev).  When
tb_add_dp_resources(tb->root_switch) now runs at runtime from
tb_scan_port() or tb_dp_resource_available(), it adds the host DP IN port
to tcm->dp_resources without calling tb_exit_redrive(port).  Any later
tb_dp_resource_available() call for that DP IN port then returns early
because the port is already on tcm->dp_resources (or already enabled by
tb_tunnel_dp()), leaving port->redrive set and preventing the host router
from suspending.

[ ... ]

> @@ -2234,6 +2272,14 @@ static void tb_dp_resource_available(struct tb *tb, struct tb_port *port)
>  	list_add_tail(&port->list, &tcm->dp_resources);
>  	tb_exit_redrive(port);
>  
> +	/*
> +	 * Host router DP IN adapters removed because DPRX negotiation
> +	 * failed never get a hotplug event of their own. Give them
> +	 * another chance now that a DP OUT became available.
> +	 */
> +	if (tb_port_is_dpout(port))
> +		tb_add_dp_resources(tb->root_switch);
> +
>  	/* Look for suitable DP IN <-> DP OUT pairs now */
>  	tb_tunnel_dp(tb);
>  }

[Severity: Medium]
Should tb_dp_resource_available() also use tb_add_host_dp_in() when adding
a host router DP IN port?

When a lower-numbered host DP IN port becomes available via hotplug in
tb_dp_resource_available() (such as when exiting redrive mode or after
resume) while a higher-numbered host DP IN port is already on
tcm->dp_resources, list_add_tail() places the lower-numbered port after
the higher-numbered one, breaking the adapter ordering that
tb_add_host_dp_in() maintains.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261121070804.26185-1-alfonsocvu@gmail.com?part=1

      reply	other threads:[~2026-11-21  7:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21  7:08 [PATCH] thunderbolt: Re-add host router DP IN adapters after DPRX failure Alfonso Villalobos Ulate
2026-11-21  7:25 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-226770@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=alfonsocvu@gmail.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.