From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795248083; b=oQOpFFvM6JwTN1KMkimltOidvhzoN+04hhT0Ky8VXcmr1N00ZrFGm5eTTmXwbJMLT+VY dY50Z5OGXg5fcqELQyuUJEKnykWBcl6xpy79qJsb5bkXsB/xB83BZ2ljKTiQ//C1E6pZ/ +cf2JEVc4QgU+O4KWGZCpgnaZb4WgLVPjImuF5QnH75rq2F7Zi7BOumKMel8mQ3qU8Kzq t6hdz+ISIapMkE+IGM3/qR6ua9YQVVVF/tvXzx8y6Ln2zpZNfFRQHSRz2C2wsgDjIBAGc Q/nvf83xhJsOfI2J+CfzqtpQvzPt4HDeEk9kH8cZ7fiSSFGebp9DBD8uyO/9Ke7dQFA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795248083; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=/nBFQZEJTSgaKpZnb3TrHVbaCxmksYr/v0Om85PtszQ=; b=w67x8+GI87QrRmZU/3rYZtVpv6oEIBtBAKAMi40yjM//6mJfBGJK9GoSD9ydRp7DtGE/ xBhzB01W4l9fIC0awbJqDGwOzQXzj8tg6A/5tOdnBA0Uvpgi9aPd4452sjOH80cZvEK/4 Ifeo7mrYf44V6EUlpMQyvaAjSxKNieaMh47mxtrCYZ0YQUhVkexRXkFxy8bs/8wn3kglS safIduwhanStG8lWAtYiuXVz4o7oLDtrLDIdHjlOIfviMAzPfYZj8Xg7shqhZ4KylmP5D 2ZitFw/15PxkQTxP5jFpa3SlInQxcs8Nw43X8+bv/Kqd0194aRb1UteeyXvNv/XCDJQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=doU5WfRu; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E9EE606A320; Sat, 21 Nov 2026 08:01:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=doU5WfRu Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9566B1F000C4; Sat, 21 Nov 2026 08:01:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795248083; bh=/nBFQZEJTSgaKpZnb3TrHVbaCxmksYr/v0Om85PtszQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=doU5WfRuRItUWINkETRxe211mtgU7E7hyrpX4ipDCYohHZ6Iu7F4qxin2F2AsPJBL 98c34PQmK1nYOFqLHTmXAp/6aWxnpKsiTyxq0Ayp64Rb/Hdep96D/+wnCkCUnPlSZZ 2UWFb7XJ/P3Sb3Lv3HvEDDJln0DfJ1134NNbXUOgdEkOfPXMEjlT+r27hoYq02e1YA wx5+8FMQEaE4Q/FY5K0vYop2d3BKQ//ah35vbtRP0REX+jr+qTSRwMZ4bD/t2UFRGt ACg2ZfKh8lfypRt//z3D1+WY4rd8DYnvPUBdEBOPSl5UA8sIFWGwLuQJgdb6I7Gy0Z WsghsAfJHwk1w== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 09/17] drm/spacemit: add Saturn DPU hardware backend Reply-To: sashiko-reviews@lists.linux.dev To: "Cody Kang" Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261121-k3-display-v3-9-ec419e8e96b8@gmail.com> References: <20261121-k3-display-v3-0-ec419e8e96b8@gmail.com> <20261121-k3-display-v3-9-ec419e8e96b8@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 21 Nov 2026 08:01:22 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 4 potential issues to consider: - [High] drm/spacemit: vfp underflow in saturn_init_tmg() when front porch < 7 - [High] drm/spacemit: unmasked IRQ dispatch and premature vblank event in ISR - [Medium] drm/spacemit: stale underrun IRQ and ur_mask_armed race on CFG_RDY - [Medium] drm/spacemit: race on cfg_rdy_timer and INT_CFG_RDY in spacemit_dpu_run() -- commit feb91f776850387e06b93738a2a9ed3971674069 Author: Cody Kang drm/spacemit: add Saturn DPU hardware backend This commit adds the Saturn DPU hardware backend, covering clock setup, scene control and timing generator programming, RDMA channel and composer configuration, line-buffer sizing, and interrupt handling. > diff --git a/drivers/gpu/drm/spacemit/dpu/dpu_saturn.c b/drivers/gpu/drm/= spacemit/dpu/dpu_saturn.c > new file mode 100644 > index 0000000000000..704e64fb9ec7e > --- /dev/null > +++ b/drivers/gpu/drm/spacemit/dpu/dpu_saturn.c > @@ -0,0 +1,353 @@ [ ... ] > +/* Complete a commit whose lists the engine will not confirm any more. */ > +void spacemit_dpu_complete_event(struct spacemit_crtc *a_crtc) > +{ > + struct drm_crtc *crtc =3D &a_crtc->crtc; > + struct drm_pending_vblank_event *event; > + unsigned long flags; > + > + spin_lock_irqsave(&crtc->dev->event_lock, flags); > + event =3D a_crtc->event; > + a_crtc->event =3D NULL; > + if (event) > + drm_crtc_send_vblank_event(crtc, event); > + spin_unlock_irqrestore(&crtc->dev->event_lock, flags); > + > + if (event) > + drm_crtc_vblank_put(crtc); > +} > + > +void spacemit_cfg_rdy_timer_handler(struct timer_list *t) > +{ > + struct spacemit_crtc *a_crtc =3D timer_container_of(a_crtc, t, > + cfg_rdy_timer); > + > + drm_err_ratelimited(a_crtc->crtc.dev, "CFG_RDY handshake timeout\n"); > + /* A CFG_RDY that still comes belongs to no commit any more. */ > + saturn_hee_enable_irq(a_crtc, INT_CFG_RDY, false); > + spacemit_dpu_complete_event(a_crtc); > +} [ ... ] > +/* Returns false when none of the pending status bits was this CRTC's. */ > +bool spacemit_dpu_online_isr(struct spacemit_crtc *a_crtc) > +{ > + u32 irq_raw, irq_bit, irq_ur_bit, handled; > + struct spacemit_drm_private *priv =3D a_crtc->crtc.dev->dev_private; > + struct spacemit_hw_device *hwdev =3D priv->hwdev; > + > + irq_raw =3D saturn_hee_get_int_sts(hwdev); > + irq_bit =3D saturn_hee_get_irq_bit(INT_UNDERRUN); > + irq_ur_bit =3D irq_raw & irq_bit; > + handled =3D irq_ur_bit; > + if (irq_ur_bit && !a_crtc->ur_reported) { > + saturn_hee_clr_int_sts(a_crtc, irq_ur_bit); > + drm_err_ratelimited(a_crtc->crtc.dev, "underrun\n"); > + a_crtc->ur_reported =3D true; > + } > + irq_bit =3D saturn_hee_get_irq_bit(INT_CFG_RDY); > + if (irq_raw & irq_bit) { > + saturn_hee_clr_int_sts(a_crtc, irq_bit); > + timer_delete(&a_crtc->cfg_rdy_timer); > + a_crtc->ur_reported =3D false; > + saturn_hee_enable_irq(a_crtc, INT_CFG_RDY, false); > + handled |=3D irq_bit; > + > + /* The lists are taken: the next vblank completes the commit. */ > + spin_lock(&a_crtc->crtc.dev->event_lock); > + if (a_crtc->event) { > + drm_crtc_arm_vblank_event(&a_crtc->crtc, a_crtc->event); > + a_crtc->event =3D NULL; > + } > + spin_unlock(&a_crtc->crtc.dev->event_lock); > + } > + irq_bit =3D saturn_hee_get_irq_bit(INT_VSYNC); > + if (irq_raw & irq_bit) { > + saturn_hee_clr_int_sts(a_crtc, irq_bit); > + drm_crtc_handle_vblank(&a_crtc->crtc); > + handled |=3D irq_bit; > + } > + irq_bit =3D saturn_hee_get_irq_bit(INT_REST) | irq_ur_bit; > + if (irq_raw & irq_bit) { > + saturn_hee_clr_int_sts(a_crtc, irq_bit); > + handled |=3D irq_raw & irq_bit; > + } > + > + return handled; > +} [Severity: High] Can spacemit_dpu_online_isr() complete a commit's vblank event a frame early when INT_CFG_RDY and INT_VSYNC are both set in irq_raw? As noted in saturn_hee_irq_enable() and spacemit_dpu_run(), DPU_ONLINE_IRQ_STS latches status bits even while their mask bits in DPU_ONLINE_IRQ_MSK are cleared, yet saturn_hee_enable_irq() unmasks interrupts without clearing DPU_ONLINE_IRQ_STS first and spacemit_dpu_online_isr() does not mask irq_raw against DPU_ONLINE_IRQ_MSK. When INT_CFG_RDY fires while INT_VSYNC is also set (either from a frame boundary or latched while vblank was masked), the INT_CFG_RDY branch calls drm_crtc_arm_vblank_event() and the following INT_VSYNC branch immediately calls drm_crtc_handle_vblank() in the same ISR invocation. That delivers the flip event before the next vblank and unblocks drm_atomic_helper_wait_for_flip_done() early, allowing the next commit to overwrite the active command list slot. > + > +void spacemit_dpu_run(struct drm_crtc *crtc, struct drm_atomic_commit *s= tate) > +{ > + struct spacemit_crtc *a_crtc =3D to_spacemit_crtc(crtc); > + struct spacemit_drm_private *priv =3D a_crtc->crtc.dev->dev_private; > + struct spacemit_hw_device *hwdev =3D priv->hwdev; > + > + saturn_hee_conf_dpuctrl(crtc, state); > + > + /* flush all config register writes before CFG_RDY is raised */ > + mb(); > + > + /* Ack first: one left by a commit that timed out is not this one's. */ > + saturn_hee_clr_int_sts(a_crtc, saturn_hee_get_irq_bit(INT_CFG_RDY)); > + saturn_hee_enable_irq(a_crtc, INT_CFG_RDY, true); > + > + mod_timer(&a_crtc->cfg_rdy_timer, > + jiffies + msecs_to_jiffies(SATURN_CFG_RDY_TIMEOUT_MS)); > + saturn_hee_cfg_ready(a_crtc, hwdev); > + > + if (unlikely(a_crtc->is_1st_f)) { > + drm_dbg(a_crtc->crtc.dev, "DPU start\n"); > + a_crtc->is_1st_f =3D false; > + saturn_hee_sw_start(a_crtc, hwdev); > + } > +} [Severity: Medium] Can spacemit_cfg_rdy_timer_handler() race with spacemit_dpu_online_isr() and spacemit_dpu_run() to complete the next commit's vblank event early or leave INT_CFG_RDY masked? CPU0 () CPU1 spacemit_cfg_rdy_timer_handler() drm_err_ratelimited(...) spacemit_dpu_online_isr() timer_delete(&a_crtc->cfg_rdy_timer) drm_crtc_arm_vblank_event(...) drm_crtc_handle_vblank(...) spacemit_crtc_atomic_flush() a_crtc->event =3D new_event spacemit_dpu_run() saturn_hee_enable_irq(..., true) saturn_hee_enable_irq(..., false) spacemit_dpu_complete_event() drm_crtc_send_vblank_event() <-- completes new commit early timer_delete() in spacemit_dpu_online_isr() does not wait for an in-flight spacemit_cfg_rdy_timer_handler(), so the timer callback can mask the next commit's INT_CFG_RDY and complete its a_crtc->event before the hardware consumes its command lists. In addition, spacemit_dpu_run() unmasks INT_CFG_RDY before mod_timer() and saturn_hee_cfg_ready(). If a late CFG_RDY from a previously timed-out commit arrives right after saturn_hee_enable_irq(a_crtc, INT_CFG_RDY, true), spacemit_dpu_online_isr() runs timer_delete() before the timer is armed, masks INT_CFG_RDY, and arms a_crtc->event before both_cfg_rdy is written for the new commit. > diff --git a/drivers/gpu/drm/spacemit/dpu/dpu_saturn_hee.c b/drivers/gpu/= drm/spacemit/dpu/dpu_saturn_hee.c > new file mode 100644 > index 0000000000000..1a194fe7cc7ba > --- /dev/null > +++ b/drivers/gpu/drm/spacemit/dpu/dpu_saturn_hee.c > @@ -0,0 +1,670 @@ [ ... ] > +void saturn_hee_enable_irq(struct spacemit_crtc *a_crtc, > + enum spacemit_dpu_irq irq_id, bool enable) > +{ > + saturn_enable_irq_mask(a_crtc, enable, > + DPU_INT_BASE_ADDR + DPU_ONLINE_IRQ_MSK, > + saturn_hee_get_irq_bit(irq_id)); > +} > + > +void saturn_hee_cfg_ready(struct spacemit_crtc *a_crtc, > + struct spacemit_hw_device *hwdev) > +{ > + u32 base =3D DPU_SCENE_CTL_ADDR(COMPOSER1); > + > + saturn_hee_enable_irq(a_crtc, INT_UNDERRUN, true); > + a_crtc->ur_mask_armed =3D true; > + dpu_write(hwdev, DPU_CTL_REG, base, both_cfg_rdy, 1); > +} [Severity: Medium] Does enabling INT_UNDERRUN in saturn_hee_cfg_ready() before setting a_crtc->ur_mask_armed and without clearing DPU_ONLINE_IRQ_STS race with spacemit_dpu_online_isr()? saturn_hee_cfg_ready() saturn_hee_enable_irq(a_crtc, INT_UNDERRUN, true) spacemit_dpu_online_isr() saturn_hee_clr_int_sts(a_crtc, ...) if (... && a_crtc->ur_mask_armed) <-- still false; stays unmasked a_crtc->ur_mask_armed =3D true After an underrun, INT_UNDERRUN is masked for the rest of the frame while the hardware continues latching DPU_INT_FRM_TIMING_UNFLOW in DPU_ONLINE_IRQ_STS. When the next commit calls saturn_hee_cfg_ready(), unmasking INT_UNDERRUN without clearing DPU_ONLINE_IRQ_STS immediately triggers spacemit_dpu_online_isr(). If the interrupt arrives before a_crtc->ur_mask_armed =3D true (which also happens in saturn_hee_irq_enable()), saturn_hee_clr_int_sts() sees ur_mask_armed =3D=3D false and leaves INT_UNDERRUN unmasked; if it arrives after ur_mask_armed =3D true but before INT_CFG_RDY clears ur_reported, the bottom saturn_hee_clr_int_sts() call in spacemit_dpu_online_isr() immediately masks INT_UNDERRUN again before the new commit takes effect. > + > +void saturn_hee_sw_start(struct spacemit_crtc *a_crtc, > + struct spacemit_hw_device *hwdev) > +{ > + u32 base; > + > + base =3D DPU_SCENE_CTL_ADDR(COMPOSER1); > + dpu_write_reg(hwdev, DPU_CTL_REG, base, sw_start, 1); > +} > + > +static void saturn_init_tmg(struct spacemit_crtc *a_crtc, > + const struct drm_display_mode *mode) > +{ > + u32 base =3D TMG0_BASE_ADDR; > + struct spacemit_drm_private *priv =3D a_crtc->crtc.dev->dev_private; > + struct spacemit_hw_device *hwdev =3D priv->hwdev; > + u16 vfp, vbp, vsync, hfp, hbp, hsync; > + void __iomem *tmg_addr; > + u32 value; > + > + tmg_addr =3D hwdev->base + TMG0_BASE_ADDR; > + > + hsync =3D mode->hsync_end - mode->hsync_start; > + hbp =3D mode->htotal - mode->hsync_end; > + hfp =3D mode->hsync_start - mode->hdisplay; > + vsync =3D mode->vsync_end - mode->vsync_start; > + vbp =3D mode->vtotal - mode->vsync_end; > + vfp =3D mode->vsync_start - mode->vdisplay; > + drm_dbg(a_crtc->crtc.dev, "timing " DRM_MODE_FMT "\n", DRM_MODE_ARG(mod= e)); > + > + dpu_write(hwdev, TMG_REG, base, disp_ready_man_en, 0); > + dpu_write(hwdev, TMG_REG, base, background_r, 0); > + dpu_write(hwdev, TMG_REG, base, background_g, 0x0); > + dpu_write(hwdev, TMG_REG, base, background_b, 0xff); > + dpu_write(hwdev, TMG_REG, base, eof_1st_ln_dly_num, vfp - 7); > + dpu_write(hwdev, TMG_REG, base, eof_2nd_ln_dly_num, vfp - 6); > + dpu_write(hwdev, TMG_REG, base, split_en, 0); > + dpu_write(hwdev, TMG_REG, base, cmd_screen, 0); > + dpu_write(hwdev, TMG_REG, base, cmd_wait_en, 0); > + dpu_write(hwdev, TMG_REG, base, cmd_wait_te, 0); > + dpu_write(hwdev, TMG_REG, base, sof_pre_ln_num, 0); > + dpu_write(hwdev, TMG_REG, base, hfp, hfp); > + dpu_write(hwdev, TMG_REG, base, hbp, hbp); > + dpu_write(hwdev, TMG_REG, base, vfp, vfp); > + dpu_write(hwdev, TMG_REG, base, vbp, vbp); > + dpu_write(hwdev, TMG_REG, base, hsync_width, hsync); > + dpu_write(hwdev, TMG_REG, base, vsync_width, vsync); > + dpu_write(hwdev, TMG_REG, base, hsp, 1); > + dpu_write(hwdev, TMG_REG, base, vsp, 1); > + dpu_write(hwdev, TMG_REG, base, h_active, mode->hdisplay); > + dpu_write(hwdev, TMG_REG, base, v_active, mode->vdisplay); > + dpu_write(hwdev, TMG_REG, base, fm_timing_en, 1); > + /* The pipeline always hands RGB888 to the DP/eDP encoder. */ > + dpu_write(hwdev, TMG_REG, base, user, OUTFMT_RGB888); > + > + value =3D readl(tmg_addr + 4 * dpu_field_word(TMG_REG, vfp)); > + value &=3D ~dpu_field_mask(TMG_REG, vfp); > + value |=3D vfp; > + writel(value, tmg_addr + 4 * dpu_field_word(TMG_REG, vfp)); [Severity: High] Does vfp - 7 and vfp - 6 underflow when the display mode's vertical front porch is smaller than 7 lines? Standard modes such as 1920x1080@60Hz (vdisplay =3D 1080, vsync_start =3D 1084, so vfp =3D 4) have vfp < 7, which wraps the 16-bit eof_1st_ln_dly_num and eof_2nd_ln_dly_num fields to 0xfff9..0xffff, exceeding vtotal so the EOF line-delay counters cannot fire within the frame. Also, the raw readl()/writel() sequence at the end of saturn_init_tmg() redundantly rewrites the same vfp field that dpu_write(hwdev, TMG_REG, base, vfp, vfp) just programmed above. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261121-k3-display= -v3-0-ec419e8e96b8@gmail.com?part=3D9 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01E6E606A320 for ; Sat, 21 Nov 2026 08:01:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=K4gJKMPI; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=doU5WfRu DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=v6vil2si1bparZdXonbdsMQt36F9t0u3ytnsCWQ1tzc=; b=K4gJKMPIjqndf9l+AMPuyHjYP7 F2NIeIHRaUpiSRMzrlBQMQRnCz6kmf/lQeVRAyzbKgjJLWA+xrF1SGRNCw8NcoE9rbN84/MQjIaTd JRWQUtg95IdwbJ3n8E2Fodo/5dfc1OysrABYKzFNZBFq4q+dUkHlXS2tVvf3zVP64tk13B1reS5Rt I+YIedStAm9AYYBwcwN+xpIjVd1GoDv89jjnSaMuT0jAevDPVVs7z1ZUxr8cRzofrwf3V3DViZgNm TORDUaTKu5QIjRu+DIBTYTw7u055FsRbhIYEcyCxSg18ZMSAvLbCEWg85/jzqrqa0n2NcTLrTx078 v6i2IaUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUg2I-0000000GuTx-37ZU; Sat, 21 Nov 2026 08:01:26 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUg2H-0000000GuTo-1fjZ for linux-phy@lists.infradead.org; Sat, 21 Nov 2026 08:01:25 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 5C0D960D54; Sat, 21 Nov 2026 08:01:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9566B1F000C4; Sat, 21 Nov 2026 08:01:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795248083; bh=/nBFQZEJTSgaKpZnb3TrHVbaCxmksYr/v0Om85PtszQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=doU5WfRuRItUWINkETRxe211mtgU7E7hyrpX4ipDCYohHZ6Iu7F4qxin2F2AsPJBL 98c34PQmK1nYOFqLHTmXAp/6aWxnpKsiTyxq0Ayp64Rb/Hdep96D/+wnCkCUnPlSZZ 2UWFb7XJ/P3Sb3Lv3HvEDDJln0DfJ1134NNbXUOgdEkOfPXMEjlT+r27hoYq02e1YA wx5+8FMQEaE4Q/FY5K0vYop2d3BKQ//ah35vbtRP0REX+jr+qTSRwMZ4bD/t2UFRGt ACg2ZfKh8lfypRt//z3D1+WY4rd8DYnvPUBdEBOPSl5UA8sIFWGwLuQJgdb6I7Gy0Z WsghsAfJHwk1w== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 09/17] drm/spacemit: add Saturn DPU hardware backend To: "Cody Kang" Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261121-k3-display-v3-9-ec419e8e96b8@gmail.com> References: <20261121-k3-display-v3-0-ec419e8e96b8@gmail.com> <20261121-k3-display-v3-9-ec419e8e96b8@gmail.com> Date: Sat, 21 Nov 2026 08:01:22 +0000 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg NCBwb3RlbnRpYWwKaXNzdWVzIHRvIGNvbnNpZGVyOgotIFtIaWdoXSBkcm0vc3BhY2VtaXQ6IHZm cCB1bmRlcmZsb3cgaW4gc2F0dXJuX2luaXRfdG1nKCkgd2hlbiBmcm9udAogIHBvcmNoIDwgNwot IFtIaWdoXSBkcm0vc3BhY2VtaXQ6IHVubWFza2VkIElSUSBkaXNwYXRjaCBhbmQgcHJlbWF0dXJl IHZibGFuayBldmVudAogIGluIElTUgotIFtNZWRpdW1dIGRybS9zcGFjZW1pdDogc3RhbGUgdW5k ZXJydW4gSVJRIGFuZCB1cl9tYXNrX2FybWVkIHJhY2Ugb24KICBDRkdfUkRZCi0gW01lZGl1bV0g ZHJtL3NwYWNlbWl0OiByYWNlIG9uIGNmZ19yZHlfdGltZXIgYW5kIElOVF9DRkdfUkRZIGluCiAg c3BhY2VtaXRfZHB1X3J1bigpCi0tCgpjb21taXQgZmViOTFmNzc2ODUwMzg3ZTA2YjkzNzM4YTJh OWVkMzk3MTY3NDA2OQpBdXRob3I6IENvZHkgS2FuZyA8Y29keWthbmdAdnNpdC5haT4KCmRybS9z cGFjZW1pdDogYWRkIFNhdHVybiBEUFUgaGFyZHdhcmUgYmFja2VuZAoKVGhpcyBjb21taXQgYWRk cyB0aGUgU2F0dXJuIERQVSBoYXJkd2FyZSBiYWNrZW5kLCBjb3ZlcmluZyBjbG9jayBzZXR1cCwK c2NlbmUgY29udHJvbCBhbmQgdGltaW5nIGdlbmVyYXRvciBwcm9ncmFtbWluZywgUkRNQSBjaGFu bmVsIGFuZCBjb21wb3Nlcgpjb25maWd1cmF0aW9uLCBsaW5lLWJ1ZmZlciBzaXppbmcsIGFuZCBp bnRlcnJ1cHQgaGFuZGxpbmcuCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vc3BhY2Vt aXQvZHB1L2RwdV9zYXR1cm4uYyBiL2RyaXZlcnMvZ3B1L2RybS9zcGFjZW1pdC9kcHUvZHB1X3Nh dHVybi5jCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAwLi43MDRl NjRmYjllYzdlCj4gLS0tIC9kZXYvbnVsbAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9zcGFjZW1p dC9kcHUvZHB1X3NhdHVybi5jCj4gQEAgLTAsMCArMSwzNTMgQEAKClsgLi4uIF0KCj4gKy8qIENv bXBsZXRlIGEgY29tbWl0IHdob3NlIGxpc3RzIHRoZSBlbmdpbmUgd2lsbCBub3QgY29uZmlybSBh bnkgbW9yZS4gKi8KPiArdm9pZCBzcGFjZW1pdF9kcHVfY29tcGxldGVfZXZlbnQoc3RydWN0IHNw YWNlbWl0X2NydGMgKmFfY3J0YykKPiArewo+ICsJc3RydWN0IGRybV9jcnRjICpjcnRjID0gJmFf Y3J0Yy0+Y3J0YzsKPiArCXN0cnVjdCBkcm1fcGVuZGluZ192YmxhbmtfZXZlbnQgKmV2ZW50Owo+ ICsJdW5zaWduZWQgbG9uZyBmbGFnczsKPiArCj4gKwlzcGluX2xvY2tfaXJxc2F2ZSgmY3J0Yy0+ ZGV2LT5ldmVudF9sb2NrLCBmbGFncyk7Cj4gKwlldmVudCA9IGFfY3J0Yy0+ZXZlbnQ7Cj4gKwlh X2NydGMtPmV2ZW50ID0gTlVMTDsKPiArCWlmIChldmVudCkKPiArCQlkcm1fY3J0Y19zZW5kX3Zi bGFua19ldmVudChjcnRjLCBldmVudCk7Cj4gKwlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZjcnRj LT5kZXYtPmV2ZW50X2xvY2ssIGZsYWdzKTsKPiArCj4gKwlpZiAoZXZlbnQpCj4gKwkJZHJtX2Ny dGNfdmJsYW5rX3B1dChjcnRjKTsKPiArfQo+ICsKPiArdm9pZCBzcGFjZW1pdF9jZmdfcmR5X3Rp bWVyX2hhbmRsZXIoc3RydWN0IHRpbWVyX2xpc3QgKnQpCj4gK3sKPiArCXN0cnVjdCBzcGFjZW1p dF9jcnRjICphX2NydGMgPSB0aW1lcl9jb250YWluZXJfb2YoYV9jcnRjLCB0LAo+ICsJCQkJCQkJ ICBjZmdfcmR5X3RpbWVyKTsKPiArCj4gKwlkcm1fZXJyX3JhdGVsaW1pdGVkKGFfY3J0Yy0+Y3J0 Yy5kZXYsICJDRkdfUkRZIGhhbmRzaGFrZSB0aW1lb3V0XG4iKTsKPiArCS8qIEEgQ0ZHX1JEWSB0 aGF0IHN0aWxsIGNvbWVzIGJlbG9uZ3MgdG8gbm8gY29tbWl0IGFueSBtb3JlLiAqLwo+ICsJc2F0 dXJuX2hlZV9lbmFibGVfaXJxKGFfY3J0YywgSU5UX0NGR19SRFksIGZhbHNlKTsKPiArCXNwYWNl bWl0X2RwdV9jb21wbGV0ZV9ldmVudChhX2NydGMpOwo+ICt9CgpbIC4uLiBdCgo+ICsvKiBSZXR1 cm5zIGZhbHNlIHdoZW4gbm9uZSBvZiB0aGUgcGVuZGluZyBzdGF0dXMgYml0cyB3YXMgdGhpcyBD UlRDJ3MuICovCj4gK2Jvb2wgc3BhY2VtaXRfZHB1X29ubGluZV9pc3Ioc3RydWN0IHNwYWNlbWl0 X2NydGMgKmFfY3J0YykKPiArewo+ICsJdTMyIGlycV9yYXcsIGlycV9iaXQsIGlycV91cl9iaXQs IGhhbmRsZWQ7Cj4gKwlzdHJ1Y3Qgc3BhY2VtaXRfZHJtX3ByaXZhdGUgKnByaXYgPSBhX2NydGMt PmNydGMuZGV2LT5kZXZfcHJpdmF0ZTsKPiArCXN0cnVjdCBzcGFjZW1pdF9od19kZXZpY2UgKmh3 ZGV2ID0gcHJpdi0+aHdkZXY7Cj4gKwo+ICsJaXJxX3JhdyA9IHNhdHVybl9oZWVfZ2V0X2ludF9z dHMoaHdkZXYpOwo+ICsJaXJxX2JpdCA9IHNhdHVybl9oZWVfZ2V0X2lycV9iaXQoSU5UX1VOREVS UlVOKTsKPiArCWlycV91cl9iaXQgPSBpcnFfcmF3ICYgaXJxX2JpdDsKPiArCWhhbmRsZWQgPSBp cnFfdXJfYml0Owo+ICsJaWYgKGlycV91cl9iaXQgJiYgIWFfY3J0Yy0+dXJfcmVwb3J0ZWQpIHsK PiArCQlzYXR1cm5faGVlX2Nscl9pbnRfc3RzKGFfY3J0YywgaXJxX3VyX2JpdCk7Cj4gKwkJZHJt X2Vycl9yYXRlbGltaXRlZChhX2NydGMtPmNydGMuZGV2LCAidW5kZXJydW5cbiIpOwo+ICsJCWFf Y3J0Yy0+dXJfcmVwb3J0ZWQgPSB0cnVlOwo+ICsJfQo+ICsJaXJxX2JpdCA9IHNhdHVybl9oZWVf Z2V0X2lycV9iaXQoSU5UX0NGR19SRFkpOwo+ICsJaWYgKGlycV9yYXcgJiBpcnFfYml0KSB7Cj4g KwkJc2F0dXJuX2hlZV9jbHJfaW50X3N0cyhhX2NydGMsIGlycV9iaXQpOwo+ICsJCXRpbWVyX2Rl bGV0ZSgmYV9jcnRjLT5jZmdfcmR5X3RpbWVyKTsKPiArCQlhX2NydGMtPnVyX3JlcG9ydGVkID0g ZmFsc2U7Cj4gKwkJc2F0dXJuX2hlZV9lbmFibGVfaXJxKGFfY3J0YywgSU5UX0NGR19SRFksIGZh bHNlKTsKPiArCQloYW5kbGVkIHw9IGlycV9iaXQ7Cj4gKwo+ICsJCS8qIFRoZSBsaXN0cyBhcmUg dGFrZW46IHRoZSBuZXh0IHZibGFuayBjb21wbGV0ZXMgdGhlIGNvbW1pdC4gKi8KPiArCQlzcGlu X2xvY2soJmFfY3J0Yy0+Y3J0Yy5kZXYtPmV2ZW50X2xvY2spOwo+ICsJCWlmIChhX2NydGMtPmV2 ZW50KSB7Cj4gKwkJCWRybV9jcnRjX2FybV92YmxhbmtfZXZlbnQoJmFfY3J0Yy0+Y3J0YywgYV9j cnRjLT5ldmVudCk7Cj4gKwkJCWFfY3J0Yy0+ZXZlbnQgPSBOVUxMOwo+ICsJCX0KPiArCQlzcGlu X3VubG9jaygmYV9jcnRjLT5jcnRjLmRldi0+ZXZlbnRfbG9jayk7Cj4gKwl9Cj4gKwlpcnFfYml0 ID0gc2F0dXJuX2hlZV9nZXRfaXJxX2JpdChJTlRfVlNZTkMpOwo+ICsJaWYgKGlycV9yYXcgJiBp cnFfYml0KSB7Cj4gKwkJc2F0dXJuX2hlZV9jbHJfaW50X3N0cyhhX2NydGMsIGlycV9iaXQpOwo+ ICsJCWRybV9jcnRjX2hhbmRsZV92YmxhbmsoJmFfY3J0Yy0+Y3J0Yyk7Cj4gKwkJaGFuZGxlZCB8 PSBpcnFfYml0Owo+ICsJfQo+ICsJaXJxX2JpdCA9IHNhdHVybl9oZWVfZ2V0X2lycV9iaXQoSU5U X1JFU1QpIHwgaXJxX3VyX2JpdDsKPiArCWlmIChpcnFfcmF3ICYgaXJxX2JpdCkgewo+ICsJCXNh dHVybl9oZWVfY2xyX2ludF9zdHMoYV9jcnRjLCBpcnFfYml0KTsKPiArCQloYW5kbGVkIHw9IGly cV9yYXcgJiBpcnFfYml0Owo+ICsJfQo+ICsKPiArCXJldHVybiBoYW5kbGVkOwo+ICt9CgpbU2V2 ZXJpdHk6IEhpZ2hdCkNhbiBzcGFjZW1pdF9kcHVfb25saW5lX2lzcigpIGNvbXBsZXRlIGEgY29t bWl0J3MgdmJsYW5rIGV2ZW50IGEgZnJhbWUKZWFybHkgd2hlbiBJTlRfQ0ZHX1JEWSBhbmQgSU5U X1ZTWU5DIGFyZSBib3RoIHNldCBpbiBpcnFfcmF3PwoKQXMgbm90ZWQgaW4gc2F0dXJuX2hlZV9p cnFfZW5hYmxlKCkgYW5kIHNwYWNlbWl0X2RwdV9ydW4oKSwKRFBVX09OTElORV9JUlFfU1RTIGxh dGNoZXMgc3RhdHVzIGJpdHMgZXZlbiB3aGlsZSB0aGVpciBtYXNrIGJpdHMgaW4KRFBVX09OTElO RV9JUlFfTVNLIGFyZSBjbGVhcmVkLCB5ZXQgc2F0dXJuX2hlZV9lbmFibGVfaXJxKCkgdW5tYXNr cwppbnRlcnJ1cHRzIHdpdGhvdXQgY2xlYXJpbmcgRFBVX09OTElORV9JUlFfU1RTIGZpcnN0IGFu ZApzcGFjZW1pdF9kcHVfb25saW5lX2lzcigpIGRvZXMgbm90IG1hc2sgaXJxX3JhdyBhZ2FpbnN0 CkRQVV9PTkxJTkVfSVJRX01TSy4gIFdoZW4gSU5UX0NGR19SRFkgZmlyZXMgd2hpbGUgSU5UX1ZT WU5DIGlzIGFsc28gc2V0CihlaXRoZXIgZnJvbSBhIGZyYW1lIGJvdW5kYXJ5IG9yIGxhdGNoZWQg d2hpbGUgdmJsYW5rIHdhcyBtYXNrZWQpLCB0aGUKSU5UX0NGR19SRFkgYnJhbmNoIGNhbGxzIGRy bV9jcnRjX2FybV92YmxhbmtfZXZlbnQoKSBhbmQgdGhlIGZvbGxvd2luZwpJTlRfVlNZTkMgYnJh bmNoIGltbWVkaWF0ZWx5IGNhbGxzIGRybV9jcnRjX2hhbmRsZV92YmxhbmsoKSBpbiB0aGUgc2Ft ZQpJU1IgaW52b2NhdGlvbi4gIFRoYXQgZGVsaXZlcnMgdGhlIGZsaXAgZXZlbnQgYmVmb3JlIHRo ZSBuZXh0IHZibGFuayBhbmQKdW5ibG9ja3MgZHJtX2F0b21pY19oZWxwZXJfd2FpdF9mb3JfZmxp cF9kb25lKCkgZWFybHksIGFsbG93aW5nIHRoZSBuZXh0CmNvbW1pdCB0byBvdmVyd3JpdGUgdGhl IGFjdGl2ZSBjb21tYW5kIGxpc3Qgc2xvdC4KCj4gKwo+ICt2b2lkIHNwYWNlbWl0X2RwdV9ydW4o c3RydWN0IGRybV9jcnRjICpjcnRjLCBzdHJ1Y3QgZHJtX2F0b21pY19jb21taXQgKnN0YXRlKQo+ ICt7Cj4gKwlzdHJ1Y3Qgc3BhY2VtaXRfY3J0YyAqYV9jcnRjID0gdG9fc3BhY2VtaXRfY3J0Yyhj cnRjKTsKPiArCXN0cnVjdCBzcGFjZW1pdF9kcm1fcHJpdmF0ZSAqcHJpdiA9IGFfY3J0Yy0+Y3J0 Yy5kZXYtPmRldl9wcml2YXRlOwo+ICsJc3RydWN0IHNwYWNlbWl0X2h3X2RldmljZSAqaHdkZXYg PSBwcml2LT5od2RldjsKPiArCj4gKwlzYXR1cm5faGVlX2NvbmZfZHB1Y3RybChjcnRjLCBzdGF0 ZSk7Cj4gKwo+ICsJLyogZmx1c2ggYWxsIGNvbmZpZyByZWdpc3RlciB3cml0ZXMgYmVmb3JlIENG R19SRFkgaXMgcmFpc2VkICovCj4gKwltYigpOwo+ICsKPiArCS8qIEFjayBmaXJzdDogb25lIGxl ZnQgYnkgYSBjb21taXQgdGhhdCB0aW1lZCBvdXQgaXMgbm90IHRoaXMgb25lJ3MuICovCj4gKwlz YXR1cm5faGVlX2Nscl9pbnRfc3RzKGFfY3J0Yywgc2F0dXJuX2hlZV9nZXRfaXJxX2JpdChJTlRf Q0ZHX1JEWSkpOwo+ICsJc2F0dXJuX2hlZV9lbmFibGVfaXJxKGFfY3J0YywgSU5UX0NGR19SRFks IHRydWUpOwo+ICsKPiArCW1vZF90aW1lcigmYV9jcnRjLT5jZmdfcmR5X3RpbWVyLAo+ICsJCSAg amlmZmllcyArIG1zZWNzX3RvX2ppZmZpZXMoU0FUVVJOX0NGR19SRFlfVElNRU9VVF9NUykpOwo+ ICsJc2F0dXJuX2hlZV9jZmdfcmVhZHkoYV9jcnRjLCBod2Rldik7Cj4gKwo+ICsJaWYgKHVubGlr ZWx5KGFfY3J0Yy0+aXNfMXN0X2YpKSB7Cj4gKwkJZHJtX2RiZyhhX2NydGMtPmNydGMuZGV2LCAi RFBVIHN0YXJ0XG4iKTsKPiArCQlhX2NydGMtPmlzXzFzdF9mID0gZmFsc2U7Cj4gKwkJc2F0dXJu X2hlZV9zd19zdGFydChhX2NydGMsIGh3ZGV2KTsKPiArCX0KPiArfQoKW1NldmVyaXR5OiBNZWRp dW1dCkNhbiBzcGFjZW1pdF9jZmdfcmR5X3RpbWVyX2hhbmRsZXIoKSByYWNlIHdpdGggc3BhY2Vt aXRfZHB1X29ubGluZV9pc3IoKQphbmQgc3BhY2VtaXRfZHB1X3J1bigpIHRvIGNvbXBsZXRlIHRo ZSBuZXh0IGNvbW1pdCdzIHZibGFuayBldmVudCBlYXJseSBvcgpsZWF2ZSBJTlRfQ0ZHX1JEWSBt YXNrZWQ/CgpDUFUwICg8c29mdGlycT4pICAgICAgICAgICAgICAgICAgQ1BVMQpzcGFjZW1pdF9j ZmdfcmR5X3RpbWVyX2hhbmRsZXIoKQogIGRybV9lcnJfcmF0ZWxpbWl0ZWQoLi4uKQogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgPGhhcmRpcnE+CiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBzcGFjZW1pdF9kcHVfb25saW5lX2lzcigpCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHRpbWVyX2RlbGV0ZSgmYV9jcnRjLT5jZmdfcmR5X3RpbWVyKQog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkcm1fY3J0Y19hcm1fdmJsYW5rX2V2 ZW50KC4uLikKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZHJtX2NydGNfaGFu ZGxlX3ZibGFuayguLi4pCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzcGFjZW1p dF9jcnRjX2F0b21pY19mbHVzaCgpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGFfY3J0Yy0+ZXZlbnQgPSBuZXdfZXZlbnQKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgc3BhY2VtaXRfZHB1X3J1bigpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgc2F0dXJuX2hlZV9lbmFibGVfaXJxKC4uLiwgdHJ1ZSkKICBzYXR1cm5faGVlX2VuYWJs ZV9pcnEoLi4uLCBmYWxzZSkKICBzcGFjZW1pdF9kcHVfY29tcGxldGVfZXZlbnQoKQogICAgZHJt X2NydGNfc2VuZF92YmxhbmtfZXZlbnQoKSAgPC0tIGNvbXBsZXRlcyBuZXcgY29tbWl0IGVhcmx5 Cgp0aW1lcl9kZWxldGUoKSBpbiBzcGFjZW1pdF9kcHVfb25saW5lX2lzcigpIGRvZXMgbm90IHdh aXQgZm9yIGFuIGluLWZsaWdodApzcGFjZW1pdF9jZmdfcmR5X3RpbWVyX2hhbmRsZXIoKSwgc28g dGhlIHRpbWVyIGNhbGxiYWNrIGNhbiBtYXNrIHRoZSBuZXh0CmNvbW1pdCdzIElOVF9DRkdfUkRZ IGFuZCBjb21wbGV0ZSBpdHMgYV9jcnRjLT5ldmVudCBiZWZvcmUgdGhlIGhhcmR3YXJlCmNvbnN1 bWVzIGl0cyBjb21tYW5kIGxpc3RzLgoKSW4gYWRkaXRpb24sIHNwYWNlbWl0X2RwdV9ydW4oKSB1 bm1hc2tzIElOVF9DRkdfUkRZIGJlZm9yZSBtb2RfdGltZXIoKSBhbmQKc2F0dXJuX2hlZV9jZmdf cmVhZHkoKS4gIElmIGEgbGF0ZSBDRkdfUkRZIGZyb20gYSBwcmV2aW91c2x5IHRpbWVkLW91dApj b21taXQgYXJyaXZlcyByaWdodCBhZnRlciBzYXR1cm5faGVlX2VuYWJsZV9pcnEoYV9jcnRjLCBJ TlRfQ0ZHX1JEWSwKdHJ1ZSksIHNwYWNlbWl0X2RwdV9vbmxpbmVfaXNyKCkgcnVucyB0aW1lcl9k ZWxldGUoKSBiZWZvcmUgdGhlIHRpbWVyIGlzCmFybWVkLCBtYXNrcyBJTlRfQ0ZHX1JEWSwgYW5k IGFybXMgYV9jcnRjLT5ldmVudCBiZWZvcmUgYm90aF9jZmdfcmR5IGlzCndyaXR0ZW4gZm9yIHRo ZSBuZXcgY29tbWl0LgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3NwYWNlbWl0L2Rw dS9kcHVfc2F0dXJuX2hlZS5jIGIvZHJpdmVycy9ncHUvZHJtL3NwYWNlbWl0L2RwdS9kcHVfc2F0 dXJuX2hlZS5jCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAwLi4x YTE5NGZlN2NjN2JhCj4gLS0tIC9kZXYvbnVsbAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9zcGFj ZW1pdC9kcHUvZHB1X3NhdHVybl9oZWUuYwo+IEBAIC0wLDAgKzEsNjcwIEBACgpbIC4uLiBdCgo+ ICt2b2lkIHNhdHVybl9oZWVfZW5hYmxlX2lycShzdHJ1Y3Qgc3BhY2VtaXRfY3J0YyAqYV9jcnRj LAo+ICsJCQkgICBlbnVtIHNwYWNlbWl0X2RwdV9pcnEgaXJxX2lkLCBib29sIGVuYWJsZSkKPiAr ewo+ICsJc2F0dXJuX2VuYWJsZV9pcnFfbWFzayhhX2NydGMsIGVuYWJsZSwKPiArCQkJICAgICAg IERQVV9JTlRfQkFTRV9BRERSICsgRFBVX09OTElORV9JUlFfTVNLLAo+ICsJCQkgICAgICAgc2F0 dXJuX2hlZV9nZXRfaXJxX2JpdChpcnFfaWQpKTsKPiArfQo+ICsKPiArdm9pZCBzYXR1cm5faGVl X2NmZ19yZWFkeShzdHJ1Y3Qgc3BhY2VtaXRfY3J0YyAqYV9jcnRjLAo+ICsJCQkgIHN0cnVjdCBz cGFjZW1pdF9od19kZXZpY2UgKmh3ZGV2KQo+ICt7Cj4gKwl1MzIgYmFzZSA9IERQVV9TQ0VORV9D VExfQUREUihDT01QT1NFUjEpOwo+ICsKPiArCXNhdHVybl9oZWVfZW5hYmxlX2lycShhX2NydGMs IElOVF9VTkRFUlJVTiwgdHJ1ZSk7Cj4gKwlhX2NydGMtPnVyX21hc2tfYXJtZWQgPSB0cnVlOwo+ ICsJZHB1X3dyaXRlKGh3ZGV2LCBEUFVfQ1RMX1JFRywgYmFzZSwgYm90aF9jZmdfcmR5LCAxKTsK PiArfQoKW1NldmVyaXR5OiBNZWRpdW1dCkRvZXMgZW5hYmxpbmcgSU5UX1VOREVSUlVOIGluIHNh dHVybl9oZWVfY2ZnX3JlYWR5KCkgYmVmb3JlIHNldHRpbmcKYV9jcnRjLT51cl9tYXNrX2FybWVk IGFuZCB3aXRob3V0IGNsZWFyaW5nIERQVV9PTkxJTkVfSVJRX1NUUyByYWNlIHdpdGgKc3BhY2Vt aXRfZHB1X29ubGluZV9pc3IoKT8KCnNhdHVybl9oZWVfY2ZnX3JlYWR5KCkKICBzYXR1cm5faGVl X2VuYWJsZV9pcnEoYV9jcnRjLCBJTlRfVU5ERVJSVU4sIHRydWUpCiAgPGhhcmRpcnE+CiAgICBz cGFjZW1pdF9kcHVfb25saW5lX2lzcigpCiAgICAgIHNhdHVybl9oZWVfY2xyX2ludF9zdHMoYV9j cnRjLCAuLi4pCiAgICAgICAgaWYgKC4uLiAmJiBhX2NydGMtPnVyX21hc2tfYXJtZWQpICA8LS0g c3RpbGwgZmFsc2U7IHN0YXlzIHVubWFza2VkCiAgYV9jcnRjLT51cl9tYXNrX2FybWVkID0gdHJ1 ZQoKQWZ0ZXIgYW4gdW5kZXJydW4sIElOVF9VTkRFUlJVTiBpcyBtYXNrZWQgZm9yIHRoZSByZXN0 IG9mIHRoZSBmcmFtZSB3aGlsZQp0aGUgaGFyZHdhcmUgY29udGludWVzIGxhdGNoaW5nIERQVV9J TlRfRlJNX1RJTUlOR19VTkZMT1cgaW4KRFBVX09OTElORV9JUlFfU1RTLiAgV2hlbiB0aGUgbmV4 dCBjb21taXQgY2FsbHMgc2F0dXJuX2hlZV9jZmdfcmVhZHkoKSwKdW5tYXNraW5nIElOVF9VTkRF UlJVTiB3aXRob3V0IGNsZWFyaW5nIERQVV9PTkxJTkVfSVJRX1NUUyBpbW1lZGlhdGVseQp0cmln Z2VycyBzcGFjZW1pdF9kcHVfb25saW5lX2lzcigpLiAgSWYgdGhlIGludGVycnVwdCBhcnJpdmVz IGJlZm9yZQphX2NydGMtPnVyX21hc2tfYXJtZWQgPSB0cnVlICh3aGljaCBhbHNvIGhhcHBlbnMg aW4Kc2F0dXJuX2hlZV9pcnFfZW5hYmxlKCkpLCBzYXR1cm5faGVlX2Nscl9pbnRfc3RzKCkgc2Vl cyB1cl9tYXNrX2FybWVkID09CmZhbHNlIGFuZCBsZWF2ZXMgSU5UX1VOREVSUlVOIHVubWFza2Vk OyBpZiBpdCBhcnJpdmVzIGFmdGVyCnVyX21hc2tfYXJtZWQgPSB0cnVlIGJ1dCBiZWZvcmUgSU5U X0NGR19SRFkgY2xlYXJzIHVyX3JlcG9ydGVkLCB0aGUgYm90dG9tCnNhdHVybl9oZWVfY2xyX2lu dF9zdHMoKSBjYWxsIGluIHNwYWNlbWl0X2RwdV9vbmxpbmVfaXNyKCkgaW1tZWRpYXRlbHkKbWFz a3MgSU5UX1VOREVSUlVOIGFnYWluIGJlZm9yZSB0aGUgbmV3IGNvbW1pdCB0YWtlcyBlZmZlY3Qu Cgo+ICsKPiArdm9pZCBzYXR1cm5faGVlX3N3X3N0YXJ0KHN0cnVjdCBzcGFjZW1pdF9jcnRjICph X2NydGMsCj4gKwkJCSBzdHJ1Y3Qgc3BhY2VtaXRfaHdfZGV2aWNlICpod2RldikKPiArewo+ICsJ dTMyIGJhc2U7Cj4gKwo+ICsJYmFzZSA9IERQVV9TQ0VORV9DVExfQUREUihDT01QT1NFUjEpOwo+ ICsJZHB1X3dyaXRlX3JlZyhod2RldiwgRFBVX0NUTF9SRUcsIGJhc2UsIHN3X3N0YXJ0LCAxKTsK PiArfQo+ICsKPiArc3RhdGljIHZvaWQgc2F0dXJuX2luaXRfdG1nKHN0cnVjdCBzcGFjZW1pdF9j cnRjICphX2NydGMsCj4gKwkJCSAgICBjb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9k ZSkKPiArewo+ICsJdTMyIGJhc2UgPSBUTUcwX0JBU0VfQUREUjsKPiArCXN0cnVjdCBzcGFjZW1p dF9kcm1fcHJpdmF0ZSAqcHJpdiA9IGFfY3J0Yy0+Y3J0Yy5kZXYtPmRldl9wcml2YXRlOwo+ICsJ c3RydWN0IHNwYWNlbWl0X2h3X2RldmljZSAqaHdkZXYgPSBwcml2LT5od2RldjsKPiArCXUxNiB2 ZnAsIHZicCwgdnN5bmMsIGhmcCwgaGJwLCBoc3luYzsKPiArCXZvaWQgX19pb21lbSAqdG1nX2Fk ZHI7Cj4gKwl1MzIgdmFsdWU7Cj4gKwo+ICsJdG1nX2FkZHIgPSBod2Rldi0+YmFzZSArIFRNRzBf QkFTRV9BRERSOwo+ICsKPiArCWhzeW5jID0gbW9kZS0+aHN5bmNfZW5kIC0gbW9kZS0+aHN5bmNf c3RhcnQ7Cj4gKwloYnAgPSBtb2RlLT5odG90YWwgLSBtb2RlLT5oc3luY19lbmQ7Cj4gKwloZnAg PSBtb2RlLT5oc3luY19zdGFydCAtIG1vZGUtPmhkaXNwbGF5Owo+ICsJdnN5bmMgPSBtb2RlLT52 c3luY19lbmQgLSBtb2RlLT52c3luY19zdGFydDsKPiArCXZicCA9IG1vZGUtPnZ0b3RhbCAtIG1v ZGUtPnZzeW5jX2VuZDsKPiArCXZmcCA9IG1vZGUtPnZzeW5jX3N0YXJ0IC0gbW9kZS0+dmRpc3Bs YXk7Cj4gKwlkcm1fZGJnKGFfY3J0Yy0+Y3J0Yy5kZXYsICJ0aW1pbmcgIiBEUk1fTU9ERV9GTVQg IlxuIiwgRFJNX01PREVfQVJHKG1vZGUpKTsKPiArCj4gKwlkcHVfd3JpdGUoaHdkZXYsIFRNR19S RUcsIGJhc2UsIGRpc3BfcmVhZHlfbWFuX2VuLCAwKTsKPiArCWRwdV93cml0ZShod2RldiwgVE1H X1JFRywgYmFzZSwgYmFja2dyb3VuZF9yLCAwKTsKPiArCWRwdV93cml0ZShod2RldiwgVE1HX1JF RywgYmFzZSwgYmFja2dyb3VuZF9nLCAweDApOwo+ICsJZHB1X3dyaXRlKGh3ZGV2LCBUTUdfUkVH LCBiYXNlLCBiYWNrZ3JvdW5kX2IsIDB4ZmYpOwo+ICsJZHB1X3dyaXRlKGh3ZGV2LCBUTUdfUkVH LCBiYXNlLCBlb2ZfMXN0X2xuX2RseV9udW0sIHZmcCAtIDcpOwo+ICsJZHB1X3dyaXRlKGh3ZGV2 LCBUTUdfUkVHLCBiYXNlLCBlb2ZfMm5kX2xuX2RseV9udW0sIHZmcCAtIDYpOwo+ICsJZHB1X3dy aXRlKGh3ZGV2LCBUTUdfUkVHLCBiYXNlLCBzcGxpdF9lbiwgMCk7Cj4gKwlkcHVfd3JpdGUoaHdk ZXYsIFRNR19SRUcsIGJhc2UsIGNtZF9zY3JlZW4sIDApOwo+ICsJZHB1X3dyaXRlKGh3ZGV2LCBU TUdfUkVHLCBiYXNlLCBjbWRfd2FpdF9lbiwgMCk7Cj4gKwlkcHVfd3JpdGUoaHdkZXYsIFRNR19S RUcsIGJhc2UsIGNtZF93YWl0X3RlLCAwKTsKPiArCWRwdV93cml0ZShod2RldiwgVE1HX1JFRywg YmFzZSwgc29mX3ByZV9sbl9udW0sIDApOwo+ICsJZHB1X3dyaXRlKGh3ZGV2LCBUTUdfUkVHLCBi YXNlLCBoZnAsIGhmcCk7Cj4gKwlkcHVfd3JpdGUoaHdkZXYsIFRNR19SRUcsIGJhc2UsIGhicCwg aGJwKTsKPiArCWRwdV93cml0ZShod2RldiwgVE1HX1JFRywgYmFzZSwgdmZwLCB2ZnApOwo+ICsJ ZHB1X3dyaXRlKGh3ZGV2LCBUTUdfUkVHLCBiYXNlLCB2YnAsIHZicCk7Cj4gKwlkcHVfd3JpdGUo aHdkZXYsIFRNR19SRUcsIGJhc2UsIGhzeW5jX3dpZHRoLCBoc3luYyk7Cj4gKwlkcHVfd3JpdGUo aHdkZXYsIFRNR19SRUcsIGJhc2UsIHZzeW5jX3dpZHRoLCB2c3luYyk7Cj4gKwlkcHVfd3JpdGUo aHdkZXYsIFRNR19SRUcsIGJhc2UsIGhzcCwgMSk7Cj4gKwlkcHVfd3JpdGUoaHdkZXYsIFRNR19S RUcsIGJhc2UsIHZzcCwgMSk7Cj4gKwlkcHVfd3JpdGUoaHdkZXYsIFRNR19SRUcsIGJhc2UsIGhf YWN0aXZlLCBtb2RlLT5oZGlzcGxheSk7Cj4gKwlkcHVfd3JpdGUoaHdkZXYsIFRNR19SRUcsIGJh c2UsIHZfYWN0aXZlLCBtb2RlLT52ZGlzcGxheSk7Cj4gKwlkcHVfd3JpdGUoaHdkZXYsIFRNR19S RUcsIGJhc2UsIGZtX3RpbWluZ19lbiwgMSk7Cj4gKwkvKiBUaGUgcGlwZWxpbmUgYWx3YXlzIGhh bmRzIFJHQjg4OCB0byB0aGUgRFAvZURQIGVuY29kZXIuICovCj4gKwlkcHVfd3JpdGUoaHdkZXYs IFRNR19SRUcsIGJhc2UsIHVzZXIsIE9VVEZNVF9SR0I4ODgpOwo+ICsKPiArCXZhbHVlID0gcmVh ZGwodG1nX2FkZHIgKyA0ICogZHB1X2ZpZWxkX3dvcmQoVE1HX1JFRywgdmZwKSk7Cj4gKwl2YWx1 ZSAmPSB+ZHB1X2ZpZWxkX21hc2soVE1HX1JFRywgdmZwKTsKPiArCXZhbHVlIHw9IHZmcDsKPiAr CXdyaXRlbCh2YWx1ZSwgdG1nX2FkZHIgKyA0ICogZHB1X2ZpZWxkX3dvcmQoVE1HX1JFRywgdmZw KSk7CgpbU2V2ZXJpdHk6IEhpZ2hdCkRvZXMgdmZwIC0gNyBhbmQgdmZwIC0gNiB1bmRlcmZsb3cg d2hlbiB0aGUgZGlzcGxheSBtb2RlJ3MgdmVydGljYWwgZnJvbnQKcG9yY2ggaXMgc21hbGxlciB0 aGFuIDcgbGluZXM/CgpTdGFuZGFyZCBtb2RlcyBzdWNoIGFzIDE5MjB4MTA4MEA2MEh6ICh2ZGlz cGxheSA9IDEwODAsIHZzeW5jX3N0YXJ0ID0KMTA4NCwgc28gdmZwID0gNCkgaGF2ZSB2ZnAgPCA3 LCB3aGljaCB3cmFwcyB0aGUgMTYtYml0IGVvZl8xc3RfbG5fZGx5X251bQphbmQgZW9mXzJuZF9s bl9kbHlfbnVtIGZpZWxkcyB0byAweGZmZjkuLjB4ZmZmZiwgZXhjZWVkaW5nIHZ0b3RhbCBzbyB0 aGUKRU9GIGxpbmUtZGVsYXkgY291bnRlcnMgY2Fubm90IGZpcmUgd2l0aGluIHRoZSBmcmFtZS4g IEFsc28sIHRoZSByYXcKcmVhZGwoKS93cml0ZWwoKSBzZXF1ZW5jZSBhdCB0aGUgZW5kIG9mIHNh dHVybl9pbml0X3RtZygpIHJlZHVuZGFudGx5CnJld3JpdGVzIHRoZSBzYW1lIHZmcCBmaWVsZCB0 aGF0IGRwdV93cml0ZShod2RldiwgVE1HX1JFRywgYmFzZSwgdmZwLCB2ZnApCmp1c3QgcHJvZ3Jh bW1lZCBhYm92ZS4KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2 LyMvcGF0Y2hzZXQvMjAyNjExMjEtazMtZGlzcGxheS12My0wLWVjNDE5ZThlOTZiOEBnbWFpbC5j b20/cGFydD05CgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1waHkK