From: sashiko-bot@kernel.org
To: "Tariq Toukan" <tariqt@nvidia.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next V2 1/5] net/mlx5: E-switch, add match-metadata allocator for nested VF/SF eswitches
Date: Sat, 21 Nov 2026 08:02:30 +0000 [thread overview]
Message-ID: <sashiko-outbox-226812@kernel.org> (raw)
In-Reply-To: <20261120075959.2533702-2-tariqt@nvidia.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] net/mlx5: inverted virt-LAG check in
mlx5_esw_match_metadata_alloc()
--
commit a97c2078b8815e78906668a4a9a37e37bc914d39
Author: Shay Drory <shayd@nvidia.com>
net/mlx5: E-switch, add match-metadata allocator for nested VF/SF eswitches
This commit adds a match-metadata allocator for nested (virt LAG) VF/SF
eswitches that splits the source-port metadata into an 8-bit LAG slot
index and an 8-bit vport ID.
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> index 1323114ce7f93..3c1355f910906 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> @@ -3650,6 +3650,48 @@ static u32 mlx5_esw_match_metadata_reserved(struct mlx5_eswitch *esw)
> return MLX5_ESW_METADATA_RSVD_UPLINK;
> }
>
> +/* Nested (virt LAG) source-port metadata layout: the upper ESW_NESTED_IDX_BITS
> + * hold the VF/SF's slot in the LAG and the lower ESW_NESTED_VPORT_BITS hold a
> + * vport id unique within its eswitch. The two fields still sum to
> + * ESW_SOURCE_PORT_METADATA_BITS. The LAG slot (0-254, per the xa_alloc() limit
> + * in mlx5_ldev_add_mdev()) fits in ESW_NESTED_IDX_BITS; slots 0xf0 and up would
> + * drive the PFNUM bits to the 0xf reserved by internal port offload, so only
> + * 0-239 are used.
> + */
> +#define ESW_NESTED_VPORT_BITS 8
> +#define ESW_NESTED_IDX_BITS (ESW_SOURCE_PORT_METADATA_BITS - ESW_NESTED_VPORT_BITS)
> +
> +static u32 mlx5_nested_esw_match_metadata_alloc(struct mlx5_eswitch *esw)
> +{
> + u32 vport_end_ida = (1 << ESW_NESTED_VPORT_BITS) - 1;
> + u32 max_idx = (1 << ESW_NESTED_IDX_BITS) -
> + (1 << (ESW_NESTED_IDX_BITS - ESW_PFNUM_BITS)) - 1;
> + int idx;
> + int id;
> +
> + idx = mlx5_lag_get_member_idx(esw->dev);
> + if (idx < 0 || idx > max_idx)
> + return 0;
> +
> + /* Use only non-zero id's (2-255). */
> + id = ida_alloc_range(&esw->offloads.vport_metadata_ida,
> + MLX5_ESW_METADATA_RSVD_UPLINK + 1,
> + vport_end_ida, GFP_KERNEL);
> + if (id < 0)
> + return 0;
> + id = (idx << ESW_NESTED_VPORT_BITS) | id;
> + return id;
> +}
> +
> +static void mlx5_nested_esw_match_metadata_free(struct mlx5_eswitch *esw,
> + u32 metadata)
> +{
> + u32 vport_bit_mask = (1 << ESW_NESTED_VPORT_BITS) - 1;
> +
> + /* Metadata holds only ESW_NESTED_VPORT_BITS of actual ida id. */
> + ida_free(&esw->offloads.vport_metadata_ida, metadata & vport_bit_mask);
> +}
> +
> u32 mlx5_esw_match_metadata_alloc(struct mlx5_eswitch *esw)
> {
> u32 vport_end_ida = (1 << ESW_VPORT_BITS) - 1;
> @@ -3658,6 +3700,9 @@ u32 mlx5_esw_match_metadata_alloc(struct mlx5_eswitch *esw)
> int pf_num;
> int id;
>
> + if (!mlx5_core_is_pf(esw->dev) && !mlx5_virt_lag_nonmember(esw->dev))
> + return mlx5_nested_esw_match_metadata_alloc(esw);
> +
> /* Only 4 bits of pf_num */
> pf_num = mlx5_sd_pf_num_get(esw->dev);
> if (pf_num < 0 || pf_num > max_pf_num)
> @@ -3678,6 +3723,9 @@ void mlx5_esw_match_metadata_free(struct mlx5_eswitch *esw, u32 metadata)
> {
> u32 vport_bit_mask = (1 << ESW_VPORT_BITS) - 1;
>
> + if (!mlx5_core_is_pf(esw->dev) && !mlx5_virt_lag_nonmember(esw->dev))
> + return mlx5_nested_esw_match_metadata_free(esw, metadata);
> +
> /* Metadata contains only 12 bits of actual ida id */
> ida_free(&esw->offloads.vport_metadata_ida, metadata & vport_bit_mask);
> }
[Severity: High]
As reported by Shay Drory on v1 [1], does negating
mlx5_virt_lag_nonmember(esw->dev) route non-PF eswitches that do not
support virt LAG into mlx5_nested_esw_match_metadata_alloc()?
drivers/net/ethernet/mellanox/mlx5/core/lag/lag.h:mlx5_virt_lag_nonmember() {
return mlx5_virt_lag_is_supported(dev) && !mlx5_lag_dev(dev);
}
When mlx5_virt_lag_is_supported(esw->dev) is false on a standalone VF or
SF eswitch manager, mlx5_lag_dev(esw->dev) is NULL and
mlx5_virt_lag_nonmember(esw->dev) returns false. That dispatches
mlx5_esw_match_metadata_alloc() to mlx5_nested_esw_match_metadata_alloc(),
where mlx5_lag_get_member_idx(esw->dev) returns -ENOENT and metadata
allocation returns 0, causing esw_offloads_vport_metadata_setup() to fail
with -ENOSPC when enabling switchdev mode.
Should mlx5_esw_match_metadata_alloc() and mlx5_esw_match_metadata_free()
check mlx5_lag_dev(esw->dev) instead of !mlx5_virt_lag_nonmember(esw->dev)?
[1] https://lore.kernel.org/r/20261110093136.377962-1-shayd@nvidia.com
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120075959.2533702-1-tariqt@nvidia.com?part=1
next prev parent reply other threads:[~2026-11-21 8:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 7:59 [PATCH net-next V2 0/5] net/mlx5: LAG over VFs/SFs (virtual LAG) Tariq Toukan
2026-11-20 7:59 ` [PATCH net-next V2 1/5] net/mlx5: E-switch, add match-metadata allocator for nested VF/SF eswitches Tariq Toukan
2026-11-21 8:02 ` sashiko-bot [this message]
2026-11-20 7:59 ` [PATCH net-next V2 2/5] net/mlx5: E-switch, match master egress rule by vport metadata Tariq Toukan
2026-11-20 7:59 ` [PATCH net-next V2 3/5] net/mlx5: E-switch, drop master egress rule under a SW vport LAG Tariq Toukan
2026-11-20 7:59 ` [PATCH net-next V2 4/5] net/mlx5e: Register eswitch-manager VF/SF self-port with switch-id Tariq Toukan
2026-11-21 8:02 ` sashiko-bot
2026-11-20 7:59 ` [PATCH net-next V2 5/5] net/mlx5: LAG, enable LAG over functions that do not represent a physical port Tariq Toukan
2026-11-21 8:02 ` sashiko-bot
2026-11-21 8:02 ` [PATCH net-next V2 0/5] net/mlx5: LAG over VFs/SFs (virtual LAG) sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-226812@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.