All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Wanhui Fu" <fuwh1120@163.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH] infiniband: cxgb4: Add cleanup on failure path in c4iw_init_module()
Date: Sat, 21 Nov 2026 09:05:14 +0000	[thread overview]
Message-ID: <sashiko-outbox-226854@kernel.org> (raw)
In-Reply-To: <20261121090058.400020-1-fuwh1120@163.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] RDMA/cxgb4: missing Fixes: trailer on c4iw_init_module() leak
  fix
--

commit a9076097e24c29502aab3a6c3bfee7c36d52d50c
Author: Wanhui Fu <fuwh1120@163.com>

> infiniband: cxgb4: Add cleanup on failure path in c4iw_init_module()
>
> Add c4iw_cm_term() and debugfs_remove_recursive() if reg_workq is
> not allocated successfully to release memory.
>
> Signed-off-by: Wanhui Fu <fuwh1120@163.com>

[Severity: Low]
This fixes a resource leak introduced when reg_workq allocation was added
to c4iw_init_module().  Should this include:

  Fixes: 1c8f1da5d851 ("iw_cxgb4: Fix possible circular dependency locking warning")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261121090058.400020-1-fuwh1120@163.com?part=1

      reply	other threads:[~2026-11-21  9:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21  9:00 [PATCH] infiniband: cxgb4: Add cleanup on failure path in c4iw_init_module() Wanhui Fu
2026-11-21  9:05 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-226854@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=fuwh1120@163.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.