All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Chaosheng Qu" <chaosheng.qu.linux@gmail.com>,
	linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] rtla/tests: cover cleanup on abnormal exits
Date: Sat, 21 Nov 2026 11:47:40 +0000	[thread overview]
Message-ID: <sashiko-outbox-226990@kernel.org> (raw)
In-Reply-To: <4ffc1e5176e9534d39401670907b4bdd700989c3.1795258353.git.chaosheng.qu.linux@gmail.com>

Thank you for your contribution! Sashiko AI review found 5 potential
issues to consider:
- [Medium] rtla/tests: CPU starvation from -P F:1 on all CPUs at 100%
  runtime
- [Medium] rtla/tests: signal startup race in wait_running() and
  unbounded wait
- [Medium] rtla/tests: false skip on broken binary and unchecked wait
  status
- [Low] rtla/tests: broken tracefs writability check via reset_osnoise()
- [Low] rtla/tests: wrong instance list in cleanup_all() and stale
  comments
--

commit 110e2919f0e6845113d98a17c558268bc9141671
Author: Chaosheng Qu <chaosheng.qu.linux@gmail.com>

rtla/tests: cover cleanup on abnormal exits

This commit adds a TAP test and helper script verifying that rtla removes
its tracefs instance on SIGINT, SIGTERM, duration timeout, and threshold
action failure.

> diff --git a/tools/tracing/rtla/tests/cleanup.t b/tools/tracing/rtla/tests/cleanup.t
> new file mode 100644
> index 0000000000000..176b1a96f87d5
> --- /dev/null
> +++ b/tools/tracing/rtla/tests/cleanup.t

[ ... ]

> +	# check() normally does this before every test. Do the same here, both to
> +	# leave a clean tracer state and to make a hung helper terminate.
> +	reset_osnoise || {
> +		echo "ok $ctr - instances cleaned up on SIGINT, timeout and action failure # SKIP tracefs is not writable"
> +		return
> +	}

[Severity: Low]
Does reset_osnoise() ever return non-zero when tracefs is searchable
(mode 0755) but not writable, or when CONFIG_OSNOISE_TRACER is disabled?

In tools/tracing/rtla/tests/engine.sh, reset_osnoise() only returns 1 if
"pushd /sys/kernel/tracing" fails; it ignores write and cd errors and
returns the exit status of the final popd (0).  When run as non-root or
without /sys/kernel/tracing/osnoise, reset_osnoise() emits uncaptured
stderr errors (and tries to create files like cpus and period_us inside
/sys/kernel/tracing/instances after "cd ../osnoise" fails) instead of
skipping cleanly.  Also, run_cleanup_cases() does not call
reset_osnoise() after check-cleanup.sh fails or times out to restore the
tracer state.

[ ... ]

> diff --git a/tools/tracing/rtla/tests/scripts/check-cleanup.sh b/tools/tracing/rtla/tests/scripts/check-cleanup.sh
> new file mode 100755
> index 0000000000000..c27db96cd556a
> --- /dev/null
> +++ b/tools/tracing/rtla/tests/scripts/check-cleanup.sh
> @@ -0,0 +1,211 @@

[ ... ]

> +# Requires: root, tracefs mounted at /sys/kernel/tracing, CONFIG_OSNOISE_TRACER.
> +# Usage: rtla_cleanup_test.sh /path/to/rtla
> +
> +RTLA=${1:-rtla}
> +TRACEFS=${TRACEFS:-/sys/kernel/tracing}
> +INSTANCES=$TRACEFS/instances
> +FAIL=0
> +PASS=0
> +
> +log()  { printf '%s\n' "$*"; }
> +pass() { PASS=$((PASS+1)); log "PASS: $*"; }
> +fail() { FAIL=$((FAIL+1)); log "FAIL: $*"; }
> +cleanup_all() {
> +	for i in osnoise_top osnoise_hist timerlat_top timerlat_hist hwnoise_top; do
> +		[ -d "$INSTANCES/$i" ] && rmdir "$INSTANCES/$i" 2>/dev/null
> +	done
> +}

[Severity: Low]
Does rtla ever create an instance named hwnoise_top, and should
cleanup_all() include osnoise_trace and timerlat_aa instead?

hwnoise_main() uses osnoise_top_ops and creates osnoise_top, while rtla
also creates auxiliary osnoise_trace and timerlat_aa instances that
cleanup_all() currently leaves behind.  Also, the usage comment above
names rtla_cleanup_test.sh instead of check-cleanup.sh, the comment on
--help below claims main() recognizes -usage and references an earlier
--version draft, and the comment on -S says it yields exit 2 when the
action fails whereas run_tool() exits 2 whenever -S stops tracing.

[ ... ]

> +cleanup_all
> +if [ ! -x "$RTLA" ]; then
> +	log "SKIP: $RTLA is not executable"
> +	exit 0
> +fi
> +help_out=$("$RTLA" --help 2>&1)
> +rtla_rc=$?
> +if [ "$rtla_rc" -ne 129 ] ||
> +   ! printf '%s\n' "$help_out" | grep -q 'rtla version'; then
> +	log "SKIP: $RTLA is not usable (--help exited $rtla_rc, no version banner)"
> +	exit 0
> +fi

[Severity: Medium]
Should a missing or broken $RTLA binary fail the test rather than
exiting 0 with "SKIP:"?

Because cleanup.t turns any "SKIP:" line on exit 0 into a passing
"ok ... # SKIP" TAP result, a broken rtla build that crashes or fails on
--help is reported as a test skip instead of a failure.  In addition,
when check-cleanup.sh is run standalone with its default RTLA=rtla,
'[ ! -x "$RTLA" ]' checks only the current working directory rather than
PATH.

Also, in the SIGINT, SIGTERM, and repeated-interrupt cases below,
'wait "$pid"' ignores rtla's exit status, so an error exit (status 1)
that cleans up the instance on the error-unwind path is reported as PASS.
Finally, check-cleanup.sh sets no EXIT/INT/TERM trap to kill a background
$pid and run cleanup_all() if killed by timeout, and cleanup.t discards
$out when timeout exits with 124 or 137.

> +
> +# Kill a background rtla if a case fails before reaping it.
> +stop_pid() {
> +	[ -n "$1" ] || return
> +	kill -KILL "$1" 2>/dev/null
> +	wait "$1" 2>/dev/null
> +}
> +
> +# Wait for an rtla instance and its signal handler.  The instance appears
> +# before set_signals() runs, so wait for rtla to start its workload (or at
> +# least for it to survive a short grace period) before sending SIGINT.
> +wait_running() {
> +	_path=$1
> +	_pid=$2
> +	wait_present "$_path" 10000 || return 1
> +	sleep 1
> +	kill -0 "$_pid" 2>/dev/null
> +}
> +
> +# ---------------------------------------------------------------------------
> +# 1. SIGINT during a long run
> +# ---------------------------------------------------------------------------
> +cleanup_all
> +$RTLA osnoise top -q -d 30s -P F:1 >/dev/null 2>&1 &

[Severity: Medium]
Can running "osnoise top ... -P F:1" without -c or -r starve SCHED_OTHER
tasks across all CPUs?

When -r and -p are omitted, osnoise_apply_config() configures a 100%
duty cycle (1000000 us runtime per 1000000 us period), and omitting -c
places SCHED_FIFO:1 osnoise/N kernel threads on every online CPU without
moving rtla to a housekeeping CPU.  On a kernel with RT throttling or the
fair DL server disabled this hangs the system until the 2-minute timeout
fires, and even with default RT throttling it consumes 95% of every CPU.
Existing tests in osnoise.t and hwnoise.t pass "-c 0 -r 900000" when
using "-P F:1" so a CPU and period headroom remain available for user
tasks.

> +pid=$!
> +if ! wait_running "$INSTANCES/osnoise_top" "$pid"; then
> +	fail "SIGINT: instance was never created (rtla did not start?)"
> +	stop_pid "$pid"
> +else
> +	kill -INT "$pid" 2>/dev/null
> +	wait "$pid" 2>/dev/null
> +	if wait_gone "$INSTANCES/osnoise_top"; then
> +		pass "SIGINT: instance removed after interrupt"
> +	else
> +		fail "SIGINT: instance still present after interrupt"
> +	fi
> +fi

[Severity: Medium]
Can wait_running() return before run_tool() calls set_signals(), and
does the unbounded 'wait "$pid"' mask broken SIGINT or SIGTERM handling?

In tools/tracing/rtla/src/common.c, run_tool() creates the
instances/osnoise_top directory inside ops->init_tool() at the start of
initialization, then parses all tracefs events, configures osnoise,
spawns per-CPU osnoise kernel threads, scans /proc/*/comm for "-P F:1",
and enables tracing before installing signal handlers:

tools/tracing/rtla/src/common.c:run_tool() {
	...
	retval = ops->enable(tool);
	if (retval)
		goto out_trace;

	tool->start_time = time(NULL);
	set_signals(params);
	...
}

If initialization takes longer than the 1-second sleep in wait_running(),
SIGTERM hits SIG_DFL and kills rtla before set_signals() runs (leaking
osnoise_top), while SIGINT is ignored because background jobs in a
non-interactive shell inherit SIG_IGN for SIGINT until set_signals()
overrides it.  Then, because 'wait "$pid"' runs without a timeout before
wait_gone, an ignored or broken signal simply blocks for 20-30 seconds
until rtla's own "-d 30s" SIGALRM timer stops tracing and removes the
instance, causing wait_gone to report a false PASS.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1795258353.git.chaosheng.qu.linux@gmail.com?part=2

  reply	other threads:[~2026-11-21 11:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21 11:31 [PATCH v3 0/2] rtla: handle SIGTERM and test abnormal exits Chaosheng Qu
2026-11-21 11:31 ` [PATCH v3 2/2] rtla/tests: cover cleanup on " Chaosheng Qu
2026-11-21 11:47   ` sashiko-bot [this message]
2026-11-21 11:31 ` [PATCH v3 1/2] rtla: handle SIGTERM during a run Chaosheng Qu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-226990@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=chaosheng.qu.linux@gmail.com \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.