All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Mahanta Jambigi" <mjambigi@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org,
	"Heiko Carstens" <hca@linux.ibm.com>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	"Alexander Gordeev" <agordeev@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH net-next 1/3] net/smc: keep clcsock until socket release
Date: Sat, 21 Nov 2026 12:46:08 +0000	[thread overview]
Message-ID: <sashiko-outbox-227018@kernel.org> (raw)
In-Reply-To: <20261120124534.430200-2-mjambigi@linux.ibm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] net/smc: missing Fixes trailer for clcsock asynchronous release
  fix
--

commit ebec662c447c805fe2e4f25a121ee577bf45f011
Author: Mahanta Jambigi <mjambigi@linux.ibm.com>

> net/smc: keep clcsock until socket release
>
> The clcsock of an SMC socket can be freed from asynchronous contexts:
> link group termination reaches smc_close_active_abort() and peer close
> reaches smc_close_passive_work(), and both can run while the socket is
> referenced by an open file. A task that uses the fd then operates on a
> released socket.
>
> Free the clcsock only when no socket file can reference it: from the
> release paths, and from the abnormal close paths only once the socket
> has no file left. __smc_release() now tears the connection down before
> it releases the clcsock: smc_conn_kill() and smc_close_passive_work()
> check conn->freed and return early once the connection has been freed.
>
> Signed-off-by: Mahanta Jambigi <mjambigi@linux.ibm.com>

[Severity: Low]
Should this bug fix include Fixes: tags for the commits that introduced
releasing clcsock while a socket file can still reference it?

  Fixes: b03faa1fafc8 ("net/smc: postpone release of clcsock")
  Fixes: 81cf4f4707af ("net/smc: remove close abort worker")
  Fixes: 42bfba9eaa33 ("net/smc: immediate termination for SMCD link groups")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120124534.430200-1-mjambigi@linux.ibm.com?part=1

  reply	other threads:[~2026-11-21 12:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 12:45 [PATCH net-next 0/3] net/smc: fix clcsock lifetime vs asynchronous paths Mahanta Jambigi
2026-11-20 12:45 ` [PATCH net-next 1/3] net/smc: keep clcsock until socket release Mahanta Jambigi
2026-11-21 12:46   ` sashiko-bot [this message]
2026-11-20 12:45 ` [PATCH net-next 2/3] net/smc: remove the clcsock release lock Mahanta Jambigi
2026-11-21 12:46   ` sashiko-bot
2026-11-20 12:45 ` [PATCH net-next 3/3] net/smc: document the clcsock lifetime Mahanta Jambigi
2026-11-21 12:46 ` [PATCH net-next 0/3] net/smc: fix clcsock lifetime vs asynchronous paths sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-227018@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mjambigi@linux.ibm.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.