All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Yuugo Yoneda" <yogo.0917.sabu@gmail.com>, devicetree@vger.kernel.org
Cc: linux-input@vger.kernel.org, robh@kernel.org,
	conor+dt@kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH RFC v2 05/13] dt-bindings: timer: add SiRF AT550 system timer
Date: Sat, 21 Nov 2026 12:48:33 +0000	[thread overview]
Message-ID: <sashiko-outbox-227027@kernel.org> (raw)
In-Reply-To: <20261121-at550-rfc-v1-v2-5-b0309d0789b2@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: timer: interrupts listed before clocks in
  sirf,at550-timer.yaml
--

commit 7d468a2e01539543c583a2c3ed0d939b2fa94299
Author: Yuugo Yoneda <yogo.0917.sabu@gmail.com>

dt-bindings: timer: add SiRF AT550 system timer

This commit adds the Devicetree binding schema for the SiRF AT550 system
timer and lists it in MAINTAINERS.

> diff --git a/Documentation/devicetree/bindings/timer/sirf,at550-timer.yaml b/Documentation/devicetree/bindings/timer/sirf,at550-timer.yaml
> new file mode 100644
> index 0000000000000..6611dabe7f554
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/timer/sirf,at550-timer.yaml
> @@ -0,0 +1,51 @@

[ ... ]

> +properties:
> +  compatible:
> +    const: sirf,at550-timer
> +  reg:
> +    maxItems: 1
> +  interrupts:
> +    minItems: 1
> +    items:
> +      - description: Match channel 0 interrupt
> +      - description: Match channel 1 interrupt
> +      - description: Match channel 2 interrupt
> +      - description: Match channel 3 interrupt
> +      - description: Match channel 4 interrupt
> +      - description: Match channel 5 interrupt
> +  clocks:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    timer@90050000 {
> +        compatible = "sirf,at550-timer";
> +        reg = <0x90050000 0x1000>;
> +        interrupt-parent = <&intc>;
> +        interrupts = <0>;
> +        clocks = <&counter_clk>;
> +    };

[Severity: Low]
In DT binding schemas and example nodes, clocks should be listed before
interrupts (compatible, reg, clocks, interrupts) in properties, required,
and examples.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261121-at550-rfc-v1-v2-0-b0309d0789b2@gmail.com?part=5

  reply	other threads:[~2026-11-21 12:48 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21 12:43 [PATCH RFC v2 00/13] SiRF AT550 / YPL514si initial RAM-boot platform support Yuugo Yoneda
2026-11-21 12:43 ` Yuugo Yoneda via B4 Relay
2026-11-21 12:43 ` [PATCH RFC v2 01/13] dt-bindings: vendor-prefixes: add Yupiteru Yuugo Yoneda
2026-11-21 12:43   ` Yuugo Yoneda via B4 Relay
2026-11-21 12:43 ` [PATCH RFC v2 02/13] dt-bindings: arm: add SiRF AT550 and Yupiteru YPL514si Yuugo Yoneda
2026-11-21 12:43   ` Yuugo Yoneda via B4 Relay
2026-11-21 12:43 ` [PATCH RFC v2 03/13] dt-bindings: interrupt-controller: add SiRF AT550 interrupt controller Yuugo Yoneda
2026-11-21 12:43   ` Yuugo Yoneda via B4 Relay
2026-11-21 12:43 ` [PATCH RFC v2 04/13] irqchip: add SiRF AT550 interrupt controller driver Yuugo Yoneda
2026-11-21 12:43   ` Yuugo Yoneda via B4 Relay
2026-11-21 12:43 ` [PATCH RFC v2 05/13] dt-bindings: timer: add SiRF AT550 system timer Yuugo Yoneda
2026-11-21 12:43   ` Yuugo Yoneda via B4 Relay
2026-11-21 12:48   ` sashiko-bot [this message]
2026-11-21 12:43 ` [PATCH RFC v2 06/13] clocksource/drivers/timer-at550: add SiRF AT550 counter and match timer Yuugo Yoneda
2026-11-21 12:43   ` Yuugo Yoneda via B4 Relay
2026-11-21 12:43 ` [PATCH RFC v2 07/13] dt-bindings: input: touchscreen: add SiRF AT550 touchscreen Yuugo Yoneda
2026-11-21 12:43   ` Yuugo Yoneda via B4 Relay
2026-11-21 12:48   ` sashiko-bot
2026-11-21 12:43 ` [PATCH RFC v2 08/13] Input: add polled SiRF AT550 resistive touchscreen driver Yuugo Yoneda
2026-11-21 12:43   ` Yuugo Yoneda via B4 Relay
2026-11-21 12:43 ` [PATCH RFC v2 09/13] dt-bindings: mmc: add SiRF AT550 SDHCI host controller Yuugo Yoneda
2026-11-21 12:43   ` Yuugo Yoneda via B4 Relay
2026-11-21 12:48   ` sashiko-bot
2026-11-21 12:43 ` [PATCH RFC v2 10/13] mmc: sdhci-at550: add SiRF AT550 programmed-I/O host driver Yuugo Yoneda
2026-11-21 12:43   ` Yuugo Yoneda via B4 Relay
2026-11-21 12:43 ` [PATCH RFC v2 11/13] ARM: at550: add SiRF AT550 platform support Yuugo Yoneda
2026-11-21 12:43   ` Yuugo Yoneda via B4 Relay
2026-11-21 12:43 ` [PATCH RFC v2 12/13] ARM: dts: sirf: add SiRF AT550 SoC and Yupiteru YPL514si board Yuugo Yoneda
2026-11-21 12:43   ` Yuugo Yoneda via B4 Relay
2026-11-21 12:43 ` [PATCH RFC v2 13/13] ARM: configs: add at550_defconfig Yuugo Yoneda
2026-11-21 12:43   ` Yuugo Yoneda via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-227027@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=yogo.0917.sabu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.