All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Arun Iyengar" <aiyengar1990@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org,
	media-ci@linuxtv.org
Subject: Re: [PATCH v4 1/3] media: dt-bindings: Add Rockchip IEP2 deinterlacer
Date: Sat, 21 Nov 2026 14:30:30 +0000	[thread overview]
Message-ID: <sashiko-outbox-227097@kernel.org> (raw)
In-Reply-To: <20261121-iep2-v4-1-760cf25f322b@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: media: rockchip,rk3568-iep2: interrupts listed
  before clocks
--

commit 025585c81c62fe98d43733346b23c19c6b7363de
Author: Arun Iyengar <aiyengar1990@gmail.com>

media: dt-bindings: Add Rockchip IEP2 deinterlacer

This commit adds a Device Tree binding schema for the Rockchip IEP2 image
enhancement processor on RK3568 and RK3588 SoCs, along with a MAINTAINERS
entry.

> diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-iep2.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-iep2.yaml
> new file mode 100644
> index 0000000000000..0c7666de19f8d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-iep2.yaml
> @@ -0,0 +1,95 @@

[ ... ]

> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description: AXI bus clock
> +      - description: AHB bus clock
> +      - description: Core clock
> +
> +  clock-names:
> +    items:
> +      - const: aclk
> +      - const: hclk
> +      - const: sclk

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - clock-names
> +  - power-domains
> +  - iommus
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/rockchip,rk3588-cru.h>
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    #include <dt-bindings/power/rk3588-power.h>
> +    #include <dt-bindings/reset/rockchip,rk3588-cru.h>
> +
> +    bus {
> +      #address-cells = <2>;
> +      #size-cells = <2>;
> +
> +      deinterlace@fdbb0000 {
> +        compatible = "rockchip,rk3588-iep2", "rockchip,rk3568-iep2";
> +        reg = <0x0 0xfdbb0000 0x0 0x500>;
> +        interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
> +        clocks = <&cru ACLK_IEP2P0>, <&cru HCLK_IEP2P0>,
> +                 <&cru CLK_IEP2P0_CORE>;
> +        clock-names = "aclk", "hclk", "sclk";

[Severity: Low]
In the properties block, the required list, and the example node, interrupts
is listed before clocks and clock-names. Could clocks and clock-names be
placed before interrupts in all three places to follow the standard DT
binding property order (compatible, reg, clocks, clock-names, interrupts)?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261121-iep2-v4-0-760cf25f322b@gmail.com?part=1

  reply	other threads:[~2026-11-21 14:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-21 14:25 [PATCH v4 0/3] media: rockchip: Add the IEP2 deinterlacer of RK3568/RK3588 Arun Iyengar via B4 Relay
2026-11-21 14:25 ` Arun Iyengar via B4 Relay
2026-11-21 14:25 ` Arun Iyengar
2026-11-21 14:25 ` [PATCH v4 1/3] media: dt-bindings: Add Rockchip IEP2 deinterlacer Arun Iyengar via B4 Relay
2026-11-21 14:25   ` Arun Iyengar via B4 Relay
2026-11-21 14:25   ` Arun Iyengar
2026-11-21 14:30   ` sashiko-bot [this message]
2026-11-21 14:25 ` [PATCH v4 2/3] media: rockchip: Add IEP2 deinterlacer driver Arun Iyengar via B4 Relay
2026-11-21 14:25   ` Arun Iyengar via B4 Relay
2026-11-21 14:25   ` Arun Iyengar
2026-11-21 14:25 ` [PATCH v4 3/3] arm64: dts: rockchip: Add IEP2 deinterlacer to RK3588 Arun Iyengar via B4 Relay
2026-11-21 14:25   ` Arun Iyengar via B4 Relay
2026-11-21 14:25   ` Arun Iyengar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-227097@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=aiyengar1990@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=media-ci@linuxtv.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.