All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Vasilij Strassheim" <v.strassheim@linutronix.de>
Cc: devicetree@vger.kernel.org, mfd@lists.linux.dev, robh@kernel.org,
	conor+dt@kernel.org, lee@kernel.org
Subject: Re: [PATCH net-next v5 4/9] dt-bindings: mfd: Add SoC-e SWIP parent
Date: Sat, 21 Nov 2026 14:53:25 +0000	[thread overview]
Message-ID: <sashiko-outbox-227108@kernel.org> (raw)
In-Reply-To: <20261120-devel-vstrassheim-soce-dsa-ml-v5-4-5de9225715e6@linutronix.de>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] dt-bindings: mfd: soce,swip: overlapping switch child and
  split MDIO reg
--

commit beb83bca6b797666b59f03629a91afa93df57a6e
Author: Vasilij Strassheim <v.strassheim@linutronix.de>

dt-bindings: mfd: Add SoC-e SWIP parent

This commit adds a Device Tree binding schema for the SoC-e SWIP
multifunction Ethernet switch FPGA IP core and its child nodes.

> diff --git a/Documentation/devicetree/bindings/mfd/soce,swip.yaml b/Documentation/devicetree/bindings/mfd/soce,swip.yaml
> new file mode 100644
> index 0000000000000..69bb9eae379f8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/soce,swip.yaml
> @@ -0,0 +1,138 @@
[ ... ]
> +  ranges: true
> +
> +  ethernet-switch@0:
> +    $ref: /schemas/net/dsa/soce,swip-switch.yaml#
> +    unevaluatedProperties: false
> +
> +  mdio-mux@202:
> +    $ref: /schemas/net/mdio-mux-mmioreg.yaml#
> +    unevaluatedProperties: false
> +
> +  mdio@204:
> +    $ref: /schemas/net/soce,swip-mdio.yaml#
> +    unevaluatedProperties: false
[ ... ]
> +examples:
> +  - |
> +    ip-core@80020000 {
> +        compatible = "soce,swip";
> +        reg = <0x80020000 0x10000>;
> +        ranges = <0x0 0x80020000 0x10000>;
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +
> +        ethernet-switch@0 {
> +            compatible = "soce,swip-switch-00-04-0c-10";
> +            reg = <0x0 0x10000>;
[ ... ]
> +        mdio-mux@202 {
> +            compatible = "mdio-mux-mmioreg", "mdio-mux";
> +            reg = <0x202 0x2>;
> +            mux-mask = <0x07ff>;
> +            mdio-parent-bus = <&mdio_parent>;
> +            #address-cells = <1>;
> +            #size-cells = <0>;
[ ... ]
> +        mdio_parent: mdio@204 {
> +            compatible = "soce,swip-mdio";
> +            reg = <0x204 0xc>, <0x200 0x2>;
> +            reg-names = "data", "control";
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +        };
> +    };

[Severity: Medium]
As reported by Krzysztof Kozlowski on v4 [1], should the parent IP core
and ethernet-switch@0 be combined into the ethernet-switch node instead of
using an MFD wrapper where the switch child claims the entire 0x0..0x10000
parent MMIO range?

Here ethernet-switch@0 claims reg = <0x0 0x10000>, which overlaps both the
parent register at offset 0x0 and the sibling MDIO registers at
0x200..0x20f.

In addition, mdio@204 (reg = <0x200 0x2>) and mdio-mux@202 (reg = <0x202
0x2>) split a single 32-bit MDIO control register at offset 0x200 into two
16-bit halfwords across two sibling nodes.  Handling the mux selector bits
directly in the MDIO controller node and driver avoids splitting one
32-bit hardware register across mdio-mux-mmioreg and soce,swip-mdio, and
allows the MDIO driver to check that the controller is idle before
changing the selected bus.

[1] https://lore.kernel.org/r/20261106-judicious-penguin-of-enhancement-b28c8b@quoll

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-devel-vstrassheim-soce-dsa-ml-v5-0-5de9225715e6@linutronix.de?part=4

  parent reply	other threads:[~2026-11-21 14:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 14:52 [PATCH net-next v5 0/9] net: dsa: Add support for SoC-e Ethernet switch IP cores Vasilij Strassheim
2026-11-20 14:52 ` [PATCH net-next v5 1/9] dt-bindings: vendor-prefixes: Add soce Vasilij Strassheim
2026-11-20 14:52 ` [PATCH net-next v5 2/9] dt-bindings: net: Add SoC-e SWIP MDIO controller Vasilij Strassheim
2026-11-21 14:53   ` sashiko-bot
2026-11-20 14:52 ` [PATCH net-next v5 3/9] dt-bindings: net: dsa: Add SoC-e SWIP switch function Vasilij Strassheim
2026-11-21 14:53   ` sashiko-bot
2026-11-20 14:52 ` [PATCH net-next v5 4/9] dt-bindings: mfd: Add SoC-e SWIP parent Vasilij Strassheim
2026-11-21 10:19   ` Krzysztof Kozlowski
2026-11-21 14:53   ` sashiko-bot [this message]
2026-11-20 14:52 ` [PATCH net-next v5 5/9] net: dsa: Add tag handling for SoC-e switches Vasilij Strassheim
2026-11-21 14:53   ` sashiko-bot
2026-11-20 14:52 ` [PATCH net-next v5 6/9] net: mdio: Add SoC-e SWIP MDIO controller driver Vasilij Strassheim
2026-11-20 14:52 ` [PATCH net-next v5 7/9] mfd: soce: Add SWIP core driver Vasilij Strassheim
2026-11-20 14:52 ` [PATCH net-next v5 8/9] net: dsa: soce: Add basic support for SoC-e SWIP switch Vasilij Strassheim
2026-11-20 14:52 ` [PATCH net-next v5 9/9] net: dsa: soce: Add VLAN membership table support Vasilij Strassheim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-227108@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee@kernel.org \
    --cc=mfd@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=v.strassheim@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.