From: sashiko-bot@kernel.org
To: "Markus Elfring" <Markus.Elfring@web.de>, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] usb: bdc: Use devm_clk_get_optional_enabled() in bdc_probe()
Date: Sat, 21 Nov 2026 15:05:25 +0000 [thread overview]
Message-ID: <sashiko-outbox-227115@kernel.org> (raw)
In-Reply-To: <cc916c01-fb49-43ae-ac08-047f5fc5001e@web.de>
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 21 Nov 2026 15:37:14 +0100
>
> * Reuse existing functionality from devm_clk_get_optional_enabled()
> instead of keeping duplicate source code.
>
> * Omit a clk_disable_unprepare() call on an error handling path
> and in the implementation of the function “bdc_remove”.
>
> * Delete the label “disable_clk”.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/cc916c01-fb49-43ae-ac08-047f5fc5001e@web.de?part=1
prev parent reply other threads:[~2026-11-21 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-21 15:00 [PATCH v2] usb: bdc: Use devm_clk_get_optional_enabled() in bdc_probe() Markus Elfring
2026-11-21 15:05 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-227115@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.