All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Andrei Maslennikov <andrei@caspur.it>
Cc: nfs@lists.sourceforge.net
Subject: Re: NFS performance issue - P3 vs P4
Date: 11 Oct 2002 23:01:40 +0200	[thread overview]
Message-ID: <shs1y6witaj.fsf@charged.uio.no> (raw)
In-Reply-To: <Pine.LNX.3.95a.1021011121800.12919A-100000@kiwi.caspur.it>

>>>>> " " == Andrei Maslennikov <andrei@caspur.it> writes:

     > with all the recent patches. On clients, we use RH kernel
     > 2.4.18-10smp.

Has a known UDP bug that can cause it to flood servers. Netapp over
Gigabit has previously been seen to be vulnerable. Please either use a
TCP connection to the Netapp, or try the appended patch.

Cheers,
  Trond

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
#	           ChangeSet	1.555.13.1 -> 1.555.13.2
#	net/ipv4/ip_output.c	1.10    -> 1.11   
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 02/08/03	davem@nuts.ninka.net	1.555.13.2
# IPv4: Fix MSG_DONTWAIT behavior on output fragmentation.
# --------------------------------------------
#
diff -Nru a/net/ipv4/ip_output.c b/net/ipv4/ip_output.c
--- a/net/ipv4/ip_output.c	Fri Oct 11 22:59:13 2002
+++ b/net/ipv4/ip_output.c	Fri Oct 11 22:59:13 2002
@@ -520,8 +520,18 @@
 		/*
 		 *	Get the memory we require with some space left for alignment.
 		 */
-
-		skb = sock_alloc_send_skb(sk, fraglen+hh_len+15, flags&MSG_DONTWAIT, &err);
+		if (!(flags & MSG_DONTWAIT) || nfrags == 0) {
+			skb = sock_alloc_send_skb(sk, fraglen + hh_len + 15,
+						  (flags & MSG_DONTWAIT), &err);
+		} else {
+			/* On a non-blocking write, we check for send buffer
+			 * usage on the first fragment only.
+			 */
+			skb = sock_wmalloc(sk, fraglen + hh_len + 15, 1,
+					   sk->allocation);
+			if (!skb)
+				err = -ENOBUFS;
+		}
 		if (skb == NULL)
 			goto error;
 


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

  reply	other threads:[~2002-10-11 21:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-11 19:43 NFS performance issue - P3 vs P4 Andrei Maslennikov
2002-10-11 21:01 ` Trond Myklebust [this message]
2002-10-11 22:42   ` Andrei Maslennikov
2002-10-11 23:40     ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=shs1y6witaj.fsf@charged.uio.no \
    --to=trond.myklebust@fys.uio.no \
    --cc=andrei@caspur.it \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.