All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Bernhard Kaindl <bk@suse.de>,  Peter Lojkin <ia6432@inbox.ru>,
	<nfs@lists.sourceforge.net>,  Chris Mason <mason@suse.com>
Subject: Re: NFS oopses on smp servers
Date: 16 Dec 2002 17:58:30 +0100	[thread overview]
Message-ID: <shs8yypaojt.fsf@charged.uio.no> (raw)
In-Reply-To: <shs8yyqht9o.fsf@charged.uio.no>

>>>>> " " == Trond Myklebust <trond.myklebust@fys.uio.no> writes:

     > Try the appended patch instead:

Duh: typo...

Cheers,
  Trond

--- linux-2.4.20-smp/fs/nfs/pagelist.c.orig	Fri Nov 29 00:53:15 2002
+++ linux-2.4.20-smp/fs/nfs/pagelist.c	Mon Dec 16 17:36:56 2002
@@ -134,9 +134,9 @@
 		req->wb_cred = NULL;
 	}
 	if (req->wb_page) {
+		atomic_dec(&NFS_REQUESTLIST(req->wb_inode)->nr_requests);
 		page_cache_release(req->wb_page);
 		req->wb_page = NULL;
-		atomic_dec(&NFS_REQUESTLIST(req->wb_inode)->nr_requests);
 	}
 }
 
@@ -165,8 +165,6 @@
 		BUG();
 	if (NFS_WBACK_BUSY(req))
 		BUG();
-	if (atomic_read(&NFS_REQUESTLIST(req->wb_inode)->nr_requests) < 0)
-		BUG();
 #endif
 
 	/* Release struct file or cached credential */


-------------------------------------------------------
This sf.net email is sponsored by:
With Great Power, Comes Great Responsibility 
Learn to use your power at OSDN's High Performance Computing Channel
http://hpc.devchannel.org/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

  reply	other threads:[~2002-12-16 16:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-15 14:58 NFS oopses on smp servers Peter Lojkin
2002-12-16 14:38 ` Bernhard Kaindl
2002-12-16 15:34   ` Trond Myklebust
2002-12-16 16:58     ` Trond Myklebust [this message]
2002-12-26 14:31       ` Peter Lojkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=shs8yypaojt.fsf@charged.uio.no \
    --to=trond.myklebust@fys.uio.no \
    --cc=bk@suse.de \
    --cc=ia6432@inbox.ru \
    --cc=mason@suse.com \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.