From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Vladimir Serov <vserov@infratel.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Russell King <rmk@arm.linux.org.uk>
Subject: Re: [BUG] nfs client stuck in D state in linux 2.4.17 - 2.4.21-pre5
Date: 20 May 2003 04:09:31 +0200 [thread overview]
Message-ID: <shsel2uqsh0.fsf@charged.uio.no> (raw)
In-Reply-To: <3EC8DA1B.50304@infratel.com>
Did you try the patch I sent you last week? (appended below)
Cheers,
Trond
--- linux-2.4.21-up/include/linux/sunrpc/sched.h.orig 2003-05-13 17:51:59.000000000 +0200
+++ linux-2.4.21-up/include/linux/sunrpc/sched.h 2003-05-13 23:04:44.000000000 +0200
@@ -128,7 +128,12 @@
#define RPC_IS_RUNNING(t) (test_bit(RPC_TASK_RUNNING, &(t)->tk_runstate))
#define rpc_set_running(t) (set_bit(RPC_TASK_RUNNING, &(t)->tk_runstate))
-#define rpc_clear_running(t) (clear_bit(RPC_TASK_RUNNING, &(t)->tk_runstate))
+#define rpc_clear_running(t) \
+ do { \
+ smp_mb__before_clear_bit(); \
+ clear_bit(RPC_TASK_RUNNING, &(t)->tk_runstate); \
+ smp_mb__after_clear_bit(); \
+ } while(0)
#define rpc_set_sleeping(t) (set_bit(RPC_TASK_SLEEPING, &(t)->tk_runstate))
--- linux-2.4.21-up/include/linux/sunrpc/xprt.h.orig 2003-05-13 17:51:59.000000000 +0200
+++ linux-2.4.21-up/include/linux/sunrpc/xprt.h 2003-05-13 23:06:41.000000000 +0200
@@ -200,7 +200,12 @@
#define xprt_connected(xp) (test_bit(XPRT_CONNECT, &(xp)->sockstate))
#define xprt_set_connected(xp) (set_bit(XPRT_CONNECT, &(xp)->sockstate))
#define xprt_test_and_set_connected(xp) (test_and_set_bit(XPRT_CONNECT, &(xp)->sockstate))
-#define xprt_clear_connected(xp) (clear_bit(XPRT_CONNECT, &(xp)->sockstate))
+#define xprt_clear_connected(xp) \
+ do { \
+ smp_mb__before_clear_bit(); \
+ clear_bit(XPRT_CONNECT, &(xp)->sockstate); \
+ smp_mb__after_clear_bit(); \
+ } while(0)
#endif /* __KERNEL__*/
next prev parent reply other threads:[~2003-05-20 1:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-18 14:57 kernel nfsd Stephan von Krawczynski
2003-03-18 15:31 ` Trond Myklebust
2003-03-18 15:42 ` Stephan von Krawczynski
2003-03-18 16:07 ` Oleg Drokin
2003-03-18 16:28 ` Stephan von Krawczynski
2003-03-18 16:41 ` Stephan von Krawczynski
2003-03-18 16:46 ` Stephan von Krawczynski
2003-03-18 17:28 ` Bernd Schubert
2003-03-19 6:43 ` Oleg Drokin
2003-03-19 11:51 ` Bernd Schubert
2003-03-18 22:09 ` Neil Brown
2003-03-19 11:01 ` Stephan von Krawczynski
2003-03-20 16:22 ` [BUG] nfs client stuck in D state in linux 2.4.17 - 2.4.21-pre5 Vladimir Serov
2003-03-20 16:29 ` Trond Myklebust
2003-03-21 9:31 ` Vladimir Serov
2003-03-21 11:16 ` Trond Myklebust
[not found] ` <3E7B0051.8060603@infratel.com>
[not found] ` <15995.578.341176.325238@charged.uio.no>
[not found] ` <3E7B10DF.5070005@infratel.com>
[not found] ` <15995.5996.446164.746224@charged.uio.no>
[not found] ` <3E7B1DF9.2090401@infratel.com>
[not found] ` <15995.10797.983569.410234@charged.uio.no>
2003-05-07 14:42 ` Vladimir Serov
2003-05-07 15:06 ` Trond Myklebust
2003-05-08 13:15 ` Vladimir Serov
2003-05-13 21:11 ` Trond Myklebust
2003-05-19 13:20 ` Vladimir Serov
2003-05-20 2:09 ` Trond Myklebust [this message]
2003-05-20 12:07 ` Vladimir Serov
2003-05-20 12:34 ` Trond Myklebust
2003-05-21 9:29 ` Russell King
2003-05-21 9:43 ` Russell King
2003-05-21 14:58 ` Nicolas Pitre
2003-05-21 13:36 ` Vladimir Serov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=shsel2uqsh0.fsf@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
--cc=vserov@infratel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.