From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: kuznet@ms2.inr.ac.ru
Cc: kalele@veritas.COM (Shirish Kalele), linux-kernel@vger.kernel.org
Subject: Re: [NFS] NFSD over TCP: TCP broken?
Date: 17 Oct 2001 20:38:31 +0200 [thread overview]
Message-ID: <shsk7xu5cyg.fsf@charged.uio.no> (raw)
In-Reply-To: <200110171758.VAA22159@ms2.inr.ac.ru>
In-Reply-To: kuznet@ms2.inr.ac.ru's message of "Wed, 17 Oct 2001 21:58:37 +0400 (MSK DST)"
>>>>> " " == kuznet <kuznet@ms2.inr.ac.ru> writes:
> Hello!
>> where the interleaving gets in.
> I do not think that you diagnosed the problem correctly. nfsd
> used non blocking io and write to tcp is strictly atomic in
> this case.
Some of the patches that attempted to fix the nfsd server code relied
on making the TCP stuff blocking. I've seen several such patches
floating around that ignore the fact that the socket lock is dropped
when the IPV4 socket code sleeps.
In any case, even with nonblocking TCP, one has to protect the socket
until the entire message has been sent. Otherwise we risk seeing
another thread racing for the socket while we're doing whatever needs
to be done to clear the -EAGAIN.
Cheers,
Trond
next prev parent reply other threads:[~2001-10-17 18:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <00f501c156f9$95337ef0$3291b40a@fserv2000.net>
2001-10-17 12:38 ` [NFS] NFSD over TCP: TCP broken? Shirish Kalele
2001-10-17 17:58 ` kuznet
2001-10-17 18:38 ` Trond Myklebust [this message]
[not found] <005a01c1579d$adab2100$3291b40a@fserv2000.net>
2001-10-17 18:39 ` kuznet
[not found] <00b401c157a1$8edd3f20$3291b40a@fserv2000.net>
2001-10-17 19:27 ` kuznet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=shsk7xu5cyg.fsf@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=kalele@veritas.COM \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.