From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Paul Mundt <lethal@linux-sh.org>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/sunrpc/clnt.c compile fix
Date: 09 Oct 2003 12:37:49 -0400 [thread overview]
Message-ID: <shsr81mnz8i.fsf@charged.uio.no> (raw)
In-Reply-To: <20031009161350.GA9170@linux-sh.org>
>>>>> " " == Paul Mundt <lethal@linux-sh.org> writes:
> Not sure if anyone has submitted this already, but as the
> subject implies, net/sunrpc/clnt.c does not compile in either
> stock test7 or in current BK:
Only if you do not also set CONFIG_SYSCTL.
> CC net/sunrpc/clnt.o net/sunrpc/clnt.c: In function
> `call_verify': net/sunrpc/clnt.c:965: structure has no member
> named `tk_pid' net/sunrpc/clnt.c:970: structure has no member
> named `tk_pid' net/sunrpc/clnt.c:976: structure has no member
> named `tk_pid' make[1]: *** [net/sunrpc/clnt.o] Error 1 make:
> *** [net/sunrpc/clnt.o] Error 2
> This is due to the fact that tk_pid is protected by
> RPC_DEBUG. Wrapping through dprintk() fixes this.
No... You are suppressing legitimate warning messages that inform the
user of a client/server mismatch!
Better then to remove the tk_pid from the warning messages...
Cheers
Trond
next prev parent reply other threads:[~2003-10-09 16:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-09 16:13 [PATCH] net/sunrpc/clnt.c compile fix Paul Mundt
2003-10-09 16:33 ` Geert Uytterhoeven
2003-10-09 16:37 ` Trond Myklebust [this message]
2003-10-09 16:40 ` Paul Mundt
2003-10-09 16:50 ` Trond Myklebust
2003-10-09 16:54 ` Paul Mundt
2003-10-09 16:57 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=shsr81mnz8i.fsf@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.