From: Kees Bakker <rnews@altium.nl>
To: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: Martin Dalecki <dalecki@evision-ventures.com>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ATA: cleanup of channel->autodma flags usage
Date: 27 Jun 2002 16:23:02 +0200 [thread overview]
Message-ID: <siit443int.fsf@koli.tasking.nl> (raw)
In-Reply-To: <Pine.SOL.4.30.0206252129130.27820-200000@mion.elka.pw.edu.pl>
>>>>> "Bartlomiej" == Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl> writes:
Bartlomiej> incremental to generic ATA PCI auto-dma patches...
[...]
Bartlomiej> - remove ATA_F_NOAUTODMA flag from aec62xx.c, hpt34x.c,
Bartlomiej> sis5513.c and via82cxxx.c drivers, it's use was bogus
Bartlomiej> in these drivers
Bartlomiej> only two usages of ATA_F_NOAUTODMA are left (in ide-pci.c),
Bartlomiej> probably they can alse be removed due to fact that drivers
Bartlomiej> should disable autodma not ide-pci (i.e. hpt34x)
[...]
That should say: ATA_F_NOADMA
I have removed ATA_F_NODMA in ide-pci.c for my VIA8233
(PCI_DEVICE_ID_VIA_82C586_1). So far it has not failed (using 2.5.20).
--- linux-2.5.20/drivers/ide/ide-pci.c~ Mon Jun 3 14:49:59 2002
+++ linux-2.5.20/drivers/ide/ide-pci.c Fri Jun 7 18:52:50 2002
@@ -742,8 +742,7 @@
{
vendor: PCI_VENDOR_ID_VIA,
device: PCI_DEVICE_ID_VIA_82C586_1,
- bootable: ON_BOARD,
- flags: ATA_F_NOADMA
+ bootable: ON_BOARD
},
{
vendor: PCI_VENDOR_ID_TTI,
- Kees
next prev parent reply other threads:[~2002-06-27 14:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-25 19:31 [PATCH] ATA: cleanup of channel->autodma flags usage Bartlomiej Zolnierkiewicz
2002-06-27 14:23 ` Kees Bakker [this message]
2002-06-27 14:59 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=siit443int.fsf@koli.tasking.nl \
--to=rnews@altium.nl \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=dalecki@evision-ventures.com \
--cc=kees.bakker@altium.nl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.