From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35BF0CCF9F0 for ; Wed, 29 Oct 2025 08:14:06 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vE1J4-0008KT-3j; Wed, 29 Oct 2025 04:13:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vE1J0-0008Ju-MR for qemu-arm@nongnu.org; Wed, 29 Oct 2025 04:13:18 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vE1Iu-0004qk-PI for qemu-arm@nongnu.org; Wed, 29 Oct 2025 04:13:18 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4770c2cd96fso28832835e9.3 for ; Wed, 29 Oct 2025 01:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761725584; x=1762330384; darn=nongnu.org; h=mime-version:message-id:in-reply-to:references:user-agent:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=R/9s/t1bENeKNi0IR6brXQSJO7uR7qYZrg1UP6diQPQ=; b=VcbRcKev4ZmA2BYiVCqYiyEjTO3bMIo8HIT/Q+pJJC0Orn1K3C+yWyDLLnDzEhI+ej WpUp1QbFVxmfGEPMMRdNajm4MrZ40Y5a6nu92GFwa8cqDp/Q1LG6YsAX6T6ULBqEWsV3 9vUafx2kSr/pSNm4acIcKNoqLmN1mgVDlV/oe/P0wuAubW4Sg1iLySHx/7HAeTDEuUyA cpMUovjWYuzKUAeeqJPWcHOISGPmYezvdspqcLdeuH30a7+Bme5aaqsR+Cm2BiyKro+g MqyqR4Ddw2761QYGy16QnTs95YFtGh/mjzcvFcSv24UL2kFlOrL/NBJVu9IADeG4iJKY uW/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761725584; x=1762330384; h=mime-version:message-id:in-reply-to:references:user-agent:subject :cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R/9s/t1bENeKNi0IR6brXQSJO7uR7qYZrg1UP6diQPQ=; b=mcEatoRSQd8pR7SFvN64voqQGRLZT/S4EKMaa3mrXNS1KNhraTmpaMfgdVZeva+pI8 Bu63fcpKQXuc3EzgBQTsSgtbYYU8NfxLwRrfckq0zsh/QtwB5kM4swfnbAptwNRmP3X3 Z1qCsB49TkKwqL30Atd7+rV0HTszRKu6+5LmdwGCW8mejlRTsF+8tG5yWcD25l7zfznG oFI7tBUieiIBs0WFLGN1gkL2eJgK6/wRFB+EnqM9Yd22loGst4oUm/EbqJkAuGTvxggW CL3Fn9r7+6teQV9pSao/uspSDdPm3QyAk/bIG8xiyPdxfr9fbZtaBTx0KYQ4zO1t1LsB Xw1w== X-Forwarded-Encrypted: i=1; AJvYcCVPIyHvp0LCl9QA89eEHWx+iVaGwgrvOSLgxjFSzAgwWvSWifSYITHHo3taTQsK39hWiuYKHgIqtQ==@nongnu.org X-Gm-Message-State: AOJu0YzzKzUyPuL2xrmWgn4Bcz15Ha4hpwNQpdZDpVxGp7g2WgkcWyx/ eGarNXCIxKXUkWVd7Kh2vKuSp0x1q2ZOBjd3gNDABgNLYneaq6pqthCsczGwDm/CWlE= X-Gm-Gg: ASbGncsxE3xg6hILaOGYVoOnI3Ijsbk60GnhCqIZpY7CdwCiMV7mtLt3K9jEldk40uO sVSCAE186zH+6+sCPZElUaawLi9OOmsBKplSITKly9JemLC92UxOESIgcbeE9Xs5pWH9RbwegMF NlFzrM6jlm0lcQaxkKmyiBtLiSu+eoDmIx5qzkyhtZR9riWMPgffgGxnZDAe5kWknTRCZCmIleT NlAUc58k7Q/cEVntdoBCeGF7Hm9gZnzKCUdRizaAS3qFOYNiCSPTuaWq9nkLymTU2UO1ZdvmGIc 2xbbGC7ojMVXK9iZ5gQxf9JK7AatvgvMaE9K4mYMJhJfQ5wEHXcEC5R3VhftjyEMR/YxznkxTYQ T890npaVzxQ1X4Ju53zyL+CHHEN9T01t7qO1Tw/n3xzbKZ9rQF/5C/YzGc6pz2T69PVkS5Y7WUm CKEheKFGDWeIFJ2PYDg6QIM89P2UkD7vurtxOm57QIADidtenJ X-Google-Smtp-Source: AGHT+IGVueVntI3GwRFIek3kHcTea1AOzJsr+wA8rD7J0CWGkRhwXu2gQwodz1ctuioGDLPGmVhaQg== X-Received: by 2002:a05:600c:a55:b0:471:9da:5248 with SMTP id 5b1f17b1804b1-4771e400d8emr14146385e9.26.1761725584206; Wed, 29 Oct 2025 01:13:04 -0700 (PDT) Received: from meli-email.org (athedsl-4440624.home.otenet.gr. [79.129.178.32]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429952b7badsm24440045f8f.7.2025.10.29.01.13.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Oct 2025 01:13:03 -0700 (PDT) Date: Wed, 29 Oct 2025 10:11:35 +0200 From: Manos Pitsidianakis To: qemu-devel@nongnu.org, Alex Benn=?UTF-8?B?w6k=?=e Cc: Liu Zhiwei , Alexandre Iooss , Chinmay Rath , qemu-arm@nongnu.org, Peter Maydell , Nicholas Piggin , Ilya Leoshkevich , David Hildenbrand , qemu-ppc@nongnu.org, Paolo Bonzini , qemu-s390x@nongnu.org, Pierrick Bouvier , Bastian Koppelmann , Helge Deller , =?UTF-8?B?QWxleCBCZW5uw6ll?= , Stafford Horne , Mahmoud Mandour , Artyom Tarasenko , Eduardo Habkost , Palmer Dabbelt , Alistair Francis , Laurent Vivier , Weiwei Li , Daniel Henrique Barboza , Mark Cave-Ayland , Yoshinori Sato , "Edgar E. Iglesias" , Aurelien Jarno , Richard Henderson , Thomas Huth , Max Filippov , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9_?= , Jiaxun Yang , Michael Rolnik , Song Gao , qemu-riscv@nongnu.org, Aleksandar Rikalo Subject: Re: [PATCH 03/35] scripts/ci: move build-environment.yaml up a level User-Agent: meli/0.8.12 References: <20251027110344.2289945-1-alex.bennee@linaro.org> <20251027110344.2289945-4-alex.bennee@linaro.org> In-Reply-To: <20251027110344.2289945-4-alex.bennee@linaro.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=manos.pitsidianakis@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, CTE_8BIT_MISMATCH=0.737, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org On Mon, 27 Oct 2025 13:03, Alex Bennée wrote: >We can share the setup of the build environment with multiple >operating systems as we just need to check the YAML for each env is >present in the directory structure. > >Signed-off-by: Alex Bennée >--- Reviewed-by: Manos Pitsidianakis > .../ci/setup/{ubuntu => }/build-environment.yml | 16 +++++++++++----- > 1 file changed, 11 insertions(+), 5 deletions(-) > rename scripts/ci/setup/{ubuntu => }/build-environment.yml (81%) > >diff --git a/scripts/ci/setup/ubuntu/build-environment.yml b/scripts/ci/setup/build-environment.yml >similarity index 81% >rename from scripts/ci/setup/ubuntu/build-environment.yml >rename to scripts/ci/setup/build-environment.yml >index 1c517c74f74..66bde188755 100644 >--- a/scripts/ci/setup/ubuntu/build-environment.yml >+++ b/scripts/ci/setup/build-environment.yml >@@ -27,18 +27,24 @@ > - ansible_facts['distribution'] == 'Ubuntu' > > # the package lists are updated by "make lcitool-refresh" >- - name: Include package lists based on OS and architecture >- include_vars: >- file: "ubuntu-2404-{{ ansible_facts['architecture'] }}.yaml" >+ - name: Define package list file path >+ set_fact: >+ package_file: "ubuntu/ubuntu-2404-{{ ansible_facts['architecture'] }}.yaml" > when: > - ansible_facts['distribution'] == 'Ubuntu' > - ansible_facts['distribution_version'] == '24.04' > >+ - name: Include package lists based on OS and architecture >+ include_vars: >+ file: "{{ package_file }}" >+ when: >+ - package_file is exists >+ > - name: Install packages for QEMU on Ubuntu 24.04 > package: > name: "{{ packages }}" > when: >- - ansible_facts['distribution'] == 'Ubuntu' >- - ansible_facts['distribution_version'] == '24.04' >+ - package_file is exists >+ - packages is defined > > >-- >2.47.3 > >