All of lore.kernel.org
 help / color / mirror / Atom feed
From: 关文涛 <guanwentao@uniontech.com>
To: "Kuniyuki Iwashima" <kuniyu@google.com>
Cc: edumazet <edumazet@google.com>, ncardwell <ncardwell@google.com>,
	kuba <kuba@kernel.org>, netdev <netdev@vger.kernel.org>,
	melotti <melotti@google.com>, stable <stable@vger.kernel.org>
Subject: Re: [PATCH net] tcp: cancel cloned request timers without waiting
Date: Thu, 19 Nov 2026 14:40:16 +0800	[thread overview]
Message-ID: <tencent_39F082F22E8C4DA7199FAC72@qq.com> (raw)
In-Reply-To: <av6VHCsEnrAMOx0M@google.com>

Hi,

> On Thu, 19 Nov 2026 10:56:20 +0800, Wentao Guan wrote:
> > When a cloned request is migrated again, its timer has the same lockdep
> > class as the running request callback. Using timer_delete_sync() through
> > __inet_csk_reqsk_queue_drop(..., false) can therefore trigger a
> > recursive-locking splat and disable lockdep.
> 
> This is net-next material.

Thanks for your review, I will modifiy it in v2.

> >
> > The clone is unhashed when inet_ehash_insert() fails, so
> > reqsk_queue_unlink() is a no-op. Its timer is pinned to the current CPU,
> > allowing it to be cancelled without waiting for its callback. Use
> > timer_delete() and drop the timer reference directly instead of
> > synchronously deleting it through the queue helper.
> 
> This change depnds on 4e2b3ef19e0e, without that, __reqsk_free()
> frees reqsk immediately and timer triggers UAF.
> 
> So please mention the commit.
OK, I will add them.

> >
> > Fixes: 97c8a3c1f73d ("tcp: Fix potential UAF in reqsk_timer_handler().")
> > Cc: stable@vger.kernel.org
>
> Please drop two tags above.
OK.

BRs
Wentao Guan

      reply	other threads:[~2026-11-19  6:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  2:56 [PATCH net] tcp: cancel cloned request timers without waiting Wentao Guan
2026-11-19  3:03 ` netdev-bot+sinfo
2026-11-19  6:22 ` Kuniyuki Iwashima
2026-11-19  6:40   ` 关文涛 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_39F082F22E8C4DA7199FAC72@qq.com \
    --to=guanwentao@uniontech.com \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=melotti@google.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.