From: Ruihai Zhou <zhou.ruihai@qq.com>
To: srinivas.kandagatla@linaro.org, gregkh@linuxfoundation.org,
msp@baylibre.com, zhou.ruihai@qq.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] nvmem: core: Fix memleak in nvmem_add_cells_from_dt error path
Date: Wed, 11 Sep 2024 20:06:55 +0800 [thread overview]
Message-ID: <tencent_C3AF1A5AA6C84EC8AFBC9434383912612209@qq.com> (raw)
In the nvmem_add_cells_from_dt(), if the devicetree 'bits' property
is outside of the valid range, the info.name alloc by kasprintf will
cause memleak. Just free before return from nvmem_add_cells_from_dt
in the error path.
Fixes: def3173d4f17 ("nvmem: core: Print error on wrong bits DT property")
Signed-off-by: Ruihai Zhou <zhou.ruihai@qq.com>
---
drivers/nvmem/core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
index 516dfd861b9f..ce71bee5e1a9 100644
--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -826,6 +826,7 @@ static int nvmem_add_cells_from_dt(struct nvmem_device *nvmem, struct device_nod
info.nbits = be32_to_cpup(addr);
if (info.bit_offset >= BITS_PER_BYTE || info.nbits < 1) {
dev_err(dev, "nvmem: invalid bits on %pOF\n", child);
+ kfree(info.name);
of_node_put(child);
return -EINVAL;
}
--
2.31.1
next reply other threads:[~2024-09-11 12:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 12:06 Ruihai Zhou [this message]
2024-09-11 12:27 ` [PATCH] nvmem: core: Fix memleak in nvmem_add_cells_from_dt error path Greg KH
2024-09-11 13:05 ` Markus Elfring
2024-09-11 13:09 ` Greg Kroah-Hartman
2024-09-11 19:46 ` Markus Schneider-Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_C3AF1A5AA6C84EC8AFBC9434383912612209@qq.com \
--to=zhou.ruihai@qq.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msp@baylibre.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.