Re: [PATCH 01/25] plugins: bump version

[Manos Pitsidianakis <manos.pitsidianakis@linaro.org>]

On Wed, 03 Jun 2026 23:51, Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com> wrote:
>Next commits will be breaking changes, so bump min version and version
>accordingly.
>
>Signed-off-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>
>---

Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>

> include/plugins/qemu-plugin.h | 6 +++++-
> plugins/plugin.h              | 2 +-
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/include/plugins/qemu-plugin.h b/include/plugins/qemu-plugin.h
>index 4eb1d2cd85c..435a14f5a00 100644
>--- a/include/plugins/qemu-plugin.h
>+++ b/include/plugins/qemu-plugin.h
>@@ -80,11 +80,15 @@ typedef uint64_t qemu_plugin_id_t;
>  * - added disconinuity callback API (for interrupts, exceptions, host calls)
>  * - added syscall filter callback API, which allows skipping syscalls and
>  *   setting custom syscall return values
>+ *
>+ * version 7:
>+ * - add userdata to all plugin callbacks, allowing maintenance of state
>+ *   externally, and easing interfacing with other languages.

You could alternatively add only "version 7" line and add the 
"changelog" lines in the patches that introduce them, but doesn't make a 
big difference.

>  */
> 
> extern QEMU_PLUGIN_EXPORT int qemu_plugin_version;
> 
>-#define QEMU_PLUGIN_VERSION 6
>+#define QEMU_PLUGIN_VERSION 7
> 
> /**
>  * struct qemu_info_t - system information for plugins
>diff --git a/plugins/plugin.h b/plugins/plugin.h
>index 6fbc443b96c..9179da43851 100644
>--- a/plugins/plugin.h
>+++ b/plugins/plugin.h
>@@ -16,7 +16,7 @@
> #include "qemu/queue.h"
> #include "qemu/qht.h"
> 
>-#define QEMU_PLUGIN_MIN_VERSION 2
>+#define QEMU_PLUGIN_MIN_VERSION 7
> 
> /* global state */
> struct qemu_plugin_state {
>-- 
>2.43.0
>
>