From: tip-bot for Anders Roxell <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, anders.roxell@linaro.org,
peterz@infradead.org, hpa@zytor.com, mingo@kernel.org,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: [tip:x86/mm] arm/asm/tlb.h: Fix build error implicit func declaration
Date: Wed, 25 Jul 2018 07:37:15 -0700 [thread overview]
Message-ID: <tip-063daa8129f94d651c4d30a8333b577c5bbf8090@git.kernel.org> (raw)
In-Reply-To: <20180725095557.19668-1-anders.roxell@linaro.org>
Commit-ID: 063daa8129f94d651c4d30a8333b577c5bbf8090
Gitweb: https://git.kernel.org/tip/063daa8129f94d651c4d30a8333b577c5bbf8090
Author: Anders Roxell <anders.roxell@linaro.org>
AuthorDate: Wed, 25 Jul 2018 11:55:57 +0200
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 25 Jul 2018 12:09:09 +0200
arm/asm/tlb.h: Fix build error implicit func declaration
Building on arm 32 with LPAE enabled we don't include asm-generic/tlb.h,
where we have tlb_flush_remove_tables_local and tlb_flush_remove_tables
defined.
The build fails with:
mm/memory.c: In function ‘tlb_remove_table_smp_sync’:
mm/memory.c:339:2: error: implicit declaration of function ‘tlb_flush_remove_tables_local’; did you mean ‘tlb_remove_table’? [-Werror=implicit-function-declaration]
...
This bug got introduced in:
2ff6ddf19c0e ("x86/mm/tlb: Leave lazy TLB mode at page table free time")
To fix this issue we define them in arm 32's specific asm/tlb.h file as well.
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: dave.hansen@intel.com
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux@armlinux.org.uk
Cc: riel@surriel.com
Cc: songliubraving@fb.com
Fixes: 2ff6ddf19c0e ("x86/mm/tlb: Leave lazy TLB mode at page table free time")
Link: http://lkml.kernel.org/r/20180725095557.19668-1-anders.roxell@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/arm/include/asm/tlb.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/include/asm/tlb.h b/arch/arm/include/asm/tlb.h
index d5562f9ce600..f854148c8d7c 100644
--- a/arch/arm/include/asm/tlb.h
+++ b/arch/arm/include/asm/tlb.h
@@ -292,5 +292,13 @@ static inline void tlb_remove_check_page_size_change(struct mmu_gather *tlb,
{
}
+static inline void tlb_flush_remove_tables(struct mm_struct *mm)
+{
+}
+
+static inline void tlb_flush_remove_tables_local(void *arg)
+{
+}
+
#endif /* CONFIG_MMU */
#endif
prev parent reply other threads:[~2018-07-25 14:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 9:55 [PATCH] arm: asm/tlb.h: Fix build error implicit func declaration Anders Roxell
2018-07-25 9:55 ` Anders Roxell
2018-07-25 10:09 ` Ingo Molnar
2018-07-25 10:09 ` Ingo Molnar
2018-07-25 14:37 ` tip-bot for Anders Roxell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-063daa8129f94d651c4d30a8333b577c5bbf8090@git.kernel.org \
--to=tipbot@zytor.com \
--cc=anders.roxell@linaro.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.