From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942449AbdDTNRR (ORCPT ); Thu, 20 Apr 2017 09:17:17 -0400 Received: from terminus.zytor.com ([65.50.211.136]:54451 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S942869AbdDTNRK (ORCPT ); Thu, 20 Apr 2017 09:17:10 -0400 Date: Thu, 20 Apr 2017 06:12:55 -0700 From: tip-bot for Matthias Kaehlcke Message-ID: Cc: mka@chromium.org, john.stultz@linaro.org, md@google.com, mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org, grundler@chromium.org, tglx@linutronix.de, ghackmann@google.com, dtor@chromium.org Reply-To: grundler@chromium.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, ghackmann@google.com, dtor@chromium.org, mka@chromium.org, john.stultz@linaro.org, md@google.com, hpa@zytor.com, mingo@kernel.org In-Reply-To: <20170418233037.70990-1-mka@chromium.org> References: <20170418233037.70990-1-mka@chromium.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:timers/core] clocksource: Use GENMASK_ULL in definition of CLOCKSOURCE_MASK Git-Commit-ID: 0773cea37470f8e080c510fe720fc356cf35df3a X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: 0773cea37470f8e080c510fe720fc356cf35df3a Gitweb: http://git.kernel.org/tip/0773cea37470f8e080c510fe720fc356cf35df3a Author: Matthias Kaehlcke AuthorDate: Tue, 18 Apr 2017 16:30:37 -0700 Committer: Thomas Gleixner CommitDate: Thu, 20 Apr 2017 14:56:58 +0200 clocksource: Use GENMASK_ULL in definition of CLOCKSOURCE_MASK Besides reusing existing code this removes the special case handling for 64-bit masks, which causes clang to raise a shift count overflow warning due to https://bugs.llvm.org//show_bug.cgi?id=10030. Suggested-by: Dmitry Torokhov Signed-off-by: Matthias Kaehlcke Cc: Grant Grundler Cc: Greg Hackmann Cc: Michael Davidson Cc: John Stultz Link: http://lkml.kernel.org/r/20170418233037.70990-1-mka@chromium.org Signed-off-by: Thomas Gleixner --- include/linux/clocksource.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h index cfc7584..f2b10d9 100644 --- a/include/linux/clocksource.h +++ b/include/linux/clocksource.h @@ -120,7 +120,7 @@ struct clocksource { #define CLOCK_SOURCE_RESELECT 0x100 /* simplify initialization of mask field */ -#define CLOCKSOURCE_MASK(bits) (u64)((bits) < 64 ? ((1ULL<<(bits))-1) : -1) +#define CLOCKSOURCE_MASK(bits) GENMASK_ULL((bits) - 1, 0) static inline u32 clocksource_freq2mult(u32 freq, u32 shift_constant, u64 from) {