All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Dave Young <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, ard.biesheuvel@linaro.org,
	gregkh@linuxfoundation.org, peterz@infradead.org,
	mingo@kernel.org, linux-kernel@vger.kernel.org,
	torvalds@linux-foundation.org, matt@codeblueprint.co.uk,
	hpa@zytor.com, dyoung@redhat.com
Subject: [tip:efi/urgent] efi: Add comment to avoid future expanding of sysfs systab
Date: Wed, 6 Dec 2017 12:30:44 -0800	[thread overview]
Message-ID: <tip-0b02e448a2ebb46eb9be4f1bdfc87112bd420cbf@git.kernel.org> (raw)
In-Reply-To: <20171206095010.24170-4-ard.biesheuvel@linaro.org>

Commit-ID:  0b02e448a2ebb46eb9be4f1bdfc87112bd420cbf
Gitweb:     https://git.kernel.org/tip/0b02e448a2ebb46eb9be4f1bdfc87112bd420cbf
Author:     Dave Young <dyoung@redhat.com>
AuthorDate: Wed, 6 Dec 2017 09:50:10 +0000
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Wed, 6 Dec 2017 19:32:23 +0100

efi: Add comment to avoid future expanding of sysfs systab

/sys/firmware/efi/systab shows several different values, it breaks sysfs
one file one value design.  But since there are already userspace tools
depend on it eg. kexec-tools so add code comment to alert future expanding
of this file.

Signed-off-by: Dave Young <dyoung@redhat.com>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-efi@vger.kernel.org
Link: http://lkml.kernel.org/r/20171206095010.24170-4-ard.biesheuvel@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 drivers/firmware/efi/efi.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index c3eefa1..557a478 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -109,6 +109,8 @@ struct kobject *efi_kobj;
 /*
  * Let's not leave out systab information that snuck into
  * the efivars driver
+ * Note, do not add more fields in systab sysfs file as it breaks sysfs
+ * one value per file rule!
  */
 static ssize_t systab_show(struct kobject *kobj,
 			   struct kobj_attribute *attr, char *buf)

  reply	other threads:[~2017-12-06 20:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-06  9:50 [GIT PULL 0/3] EFI fixes for v4.15 Ard Biesheuvel
2017-12-06  9:50 ` Ard Biesheuvel
2017-12-06  9:50 ` [PATCH 1/3] efi: move some sysfs files to be read-only by root Ard Biesheuvel
2017-12-06 20:29   ` [tip:efi/urgent] efi: Move " tip-bot for Greg Kroah-Hartman
2017-12-06  9:50 ` [PATCH 2/3] efi/esrt: use memunmap rather kfree to free the remapping Ard Biesheuvel
2017-12-06 20:30   ` [tip:efi/urgent] efi/esrt: Use memunmap() instead of kfree() " tip-bot for Pan Bian
     [not found] ` <20171206095010.24170-1-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-12-06  9:50   ` [PATCH 3/3] efi: add comment to avoid future expanding of sysfs systab Ard Biesheuvel
2017-12-06  9:50     ` Ard Biesheuvel
2017-12-06 20:30     ` tip-bot for Dave Young [this message]
2017-12-06 17:20   ` [GIT PULL 0/3] EFI fixes for v4.15 Ingo Molnar
2017-12-06 17:20     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-0b02e448a2ebb46eb9be4f1bdfc87112bd420cbf@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=dyoung@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.