All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Jiri Olsa <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, acme@kernel.org,
	jolsa@kernel.org, adrian.hunter@intel.com, mingo@kernel.org,
	acme@redhat.com, tglx@linutronix.de, jolsa@redhat.com,
	sukadev@linux.vnet.ibm.com
Subject: [tip:perf/core] tools build: Allow duplicate objects in the object list
Date: Thu, 27 Aug 2015 23:41:37 -0700	[thread overview]
Message-ID: <tip-0bdede8a3e4ff7710622a2e6713d04b3243c24a8@git.kernel.org> (raw)
In-Reply-To: <20150826130103.GF22670@krava.redhat.com>

Commit-ID:  0bdede8a3e4ff7710622a2e6713d04b3243c24a8
Gitweb:     http://git.kernel.org/tip/0bdede8a3e4ff7710622a2e6713d04b3243c24a8
Author:     Jiri Olsa <jolsa@redhat.com>
AuthorDate: Wed, 26 Aug 2015 15:01:03 +0200
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 26 Aug 2015 10:34:58 -0300

tools build: Allow duplicate objects in the object list

It's sometimes useful to specify the object affiliation to multiple
config options like:

  libperf-$(CONFIG_X86) += tsc.o
  libperf-$(CONFIG_AUXTRACE) += tsc.o

while the object itself is linked only once. Adding the support for this
and ignoring duplicate objects in the object list.

Suggested-by: Arnaldo Carvalho de Melo <acme@kernel.org>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/20150826130103.GF22670@krava.redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/build/Documentation/Build.txt | 1 +
 tools/build/Makefile.build          | 2 +-
 tools/build/tests/ex/Build          | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/build/Documentation/Build.txt b/tools/build/Documentation/Build.txt
index 00ad2d6..aa5e092 100644
--- a/tools/build/Documentation/Build.txt
+++ b/tools/build/Documentation/Build.txt
@@ -66,6 +66,7 @@ To follow the above example, the user provides following 'Build' files:
   ex/Build:
     ex-y += a.o
     ex-y += b.o
+    ex-y += b.o # duplicates in the lists are allowed
 
     libex-y += c.o
     libex-y += d.o
diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
index 8120af9..0c5f485 100644
--- a/tools/build/Makefile.build
+++ b/tools/build/Makefile.build
@@ -63,7 +63,7 @@ quiet_cmd_gen = GEN      $@
 # If there's nothing to link, create empty $@ object.
 quiet_cmd_ld_multi = LD       $@
       cmd_ld_multi = $(if $(strip $(obj-y)),\
-		       $(LD) -r -o $@ $(obj-y),rm -f $@; $(AR) rcs $@)
+		       $(LD) -r -o $@  $(filter $(obj-y),$^),rm -f $@; $(AR) rcs $@)
 
 # Build rules
 $(OUTPUT)%.o: %.c FORCE
diff --git a/tools/build/tests/ex/Build b/tools/build/tests/ex/Build
index 70d8762..429c7d4 100644
--- a/tools/build/tests/ex/Build
+++ b/tools/build/tests/ex/Build
@@ -1,6 +1,7 @@
 ex-y += ex.o
 ex-y += a.o
 ex-y += b.o
+ex-y += b.o
 ex-y += empty/
 ex-y += empty2/
 

  reply	other threads:[~2015-08-28  6:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-25 10:42 [PATCH 1/2] perf tools: Fix build on powerpc broken by pt/bts Adrian Hunter
2015-08-25 10:42 ` [PATCH 2/2] perf tools: Make NO_AUXTRACE default for non-x86 architectures Adrian Hunter
2015-08-25 15:30 ` [PATCH 1/2] perf tools: Fix build on powerpc broken by pt/bts Arnaldo Carvalho de Melo
2015-08-26  6:57   ` Adrian Hunter
2015-08-26  7:25     ` Jiri Olsa
2015-08-26  7:27       ` Adrian Hunter
2015-08-26  8:07         ` Jiri Olsa
2015-08-26 13:01           ` [PATCH] tools build: Allow duplicate objects in the object list Jiri Olsa
2015-08-28  6:41             ` tip-bot for Jiri Olsa [this message]
2015-08-26 13:08           ` [PATCH 1/2] perf tools: Fix build on powerpc broken by pt/bts Arnaldo Carvalho de Melo
2015-08-28  6:41           ` [tip:perf/core] perf tools: Remove export.h from MANIFEST tip-bot for Jiri Olsa
2015-08-26  7:06   ` [PATCH 1/2] perf tools: Fix build on powerpc broken by pt/bts Jiri Olsa
2015-08-31 18:39   ` [PATCH V2] " Adrian Hunter
2015-09-01  8:30     ` [tip:perf/urgent] perf tools: Fix build on powerpc broken by pt/ bts tip-bot for Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-0bdede8a3e4ff7710622a2e6713d04b3243c24a8@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=sukadev@linux.vnet.ibm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.