All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Namhyung Kim <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: tglx@linutronix.de, acme@redhat.com, hpa@zytor.com,
	paulus@samba.org, jolsa@redhat.com, a.p.zijlstra@chello.nl,
	fweisbec@gmail.com, jean.pihet@linaro.org, jolsa@kernel.org,
	linux-kernel@vger.kernel.org, dsahern@gmail.com,
	namhyung@kernel.org, mingo@kernel.org, namhyung.kim@lge.com
Subject: [tip:perf/urgent] perf report: Set callchain_param.record_mode for future use
Date: Wed, 15 Oct 2014 22:23:39 -0700	[thread overview]
Message-ID: <tip-0cdccac6fe4b1316f04f0dbfcc4efab51932014a@git.kernel.org> (raw)
In-Reply-To: <1412556363-26229-2-git-send-email-namhyung@kernel.org>

Commit-ID:  0cdccac6fe4b1316f04f0dbfcc4efab51932014a
Gitweb:     http://git.kernel.org/tip/0cdccac6fe4b1316f04f0dbfcc4efab51932014a
Author:     Namhyung Kim <namhyung@kernel.org>
AuthorDate: Mon, 6 Oct 2014 09:45:59 +0900
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 15 Oct 2014 16:20:03 -0300

perf report: Set callchain_param.record_mode for future use

Normally the callchain_param.record_mode is used only for record path.
But as it might need to prepare something for dwarf unwinding, setup
this info for perf report too.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jean Pihet <jean.pihet@linaro.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1412556363-26229-2-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/builtin-report.c     | 7 +++++++
 tools/perf/tests/dwarf-unwind.c | 3 +++
 2 files changed, 10 insertions(+)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 2cfc4b93..140a6cd 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -257,6 +257,13 @@ static int report__setup_sample_type(struct report *rep)
 		}
 	}
 
+	if (symbol_conf.use_callchain || symbol_conf.cumulate_callchain) {
+		if ((sample_type & PERF_SAMPLE_REGS_USER) &&
+		    (sample_type & PERF_SAMPLE_STACK_USER))
+			callchain_param.record_mode = CALLCHAIN_DWARF;
+		else
+			callchain_param.record_mode = CALLCHAIN_FP;
+	}
 	return 0;
 }
 
diff --git a/tools/perf/tests/dwarf-unwind.c b/tools/perf/tests/dwarf-unwind.c
index 96adb73..fc25e57 100644
--- a/tools/perf/tests/dwarf-unwind.c
+++ b/tools/perf/tests/dwarf-unwind.c
@@ -9,6 +9,7 @@
 #include "perf_regs.h"
 #include "map.h"
 #include "thread.h"
+#include "callchain.h"
 
 static int mmap_handler(struct perf_tool *tool __maybe_unused,
 			union perf_event *event,
@@ -120,6 +121,8 @@ int test__dwarf_unwind(void)
 		return -1;
 	}
 
+	callchain_param.record_mode = CALLCHAIN_DWARF;
+
 	if (init_live_machine(machine)) {
 		pr_err("Could not init machine\n");
 		goto out;

  reply	other threads:[~2014-10-16  5:24 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-06  0:45 [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4) Namhyung Kim
2014-10-06  0:45 ` [PATCH 1/5] perf report: Set callchain_param.record_mode for future use Namhyung Kim
2014-10-16  5:23   ` tip-bot for Namhyung Kim [this message]
2014-10-06  0:46 ` [PATCH 2/5] perf callchain: Create an address space per thread Namhyung Kim
2014-10-16  5:23   ` [tip:perf/urgent] " tip-bot for Namhyung Kim
2014-10-06  0:46 ` [PATCH 3/5] perf callchain: Use global caching provided by libunwind Namhyung Kim
2014-10-30  6:39   ` [tip:perf/core] " tip-bot for Namhyung Kim
2014-10-06  0:46 ` [PATCH 4/5] perf kvm: Use thread_{,_set}_priv helpers Namhyung Kim
2014-10-16  5:24   ` [tip:perf/urgent] " tip-bot for Namhyung Kim
2014-10-06  0:46 ` [PATCH 5/5] perf trace: " Namhyung Kim
2014-10-16  5:24   ` [tip:perf/urgent] " tip-bot for Namhyung Kim
2014-10-13 18:11 ` [PATCHSET 0/5] perf tools: Speed up dwarf callchain post-unwinding for libunwind (v4) Jiri Olsa
2014-10-14 21:08   ` Arnaldo Carvalho de Melo
2014-10-15 19:24   ` Arnaldo Carvalho de Melo
2014-10-15 20:06     ` Arnaldo Carvalho de Melo
2014-10-16 13:14       ` Namhyung Kim
2014-10-22  1:34       ` Namhyung Kim
2014-10-22  1:50         ` Arnaldo Carvalho de Melo
2014-10-23 23:35         ` Arnaldo Carvalho de Melo
2014-10-24  0:44           ` Namhyung Kim
2014-10-24  1:56             ` Arnaldo Carvalho de Melo
2014-10-24  2:37               ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-0cdccac6fe4b1316f04f0dbfcc4efab51932014a@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=fweisbec@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jean.pihet@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.