All of lore.kernel.org
 help / color / mirror / Atom feed
From: tip-bot for Konstantin Khlebnikov <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: paulus@samba.org, boris.ostrovsky@oracle.com, mingo@kernel.org,
	hpa@zytor.com, tglx@linutronix.de, linux-kernel@vger.kernel.org,
	david.vrabel@citrix.com, peterz@infradead.org, agraf@suse.de,
	torvalds@linux-foundation.org, khlebnikov@yandex-team.ru,
	efault@gmx.de
Subject: [tip:sched/core] sched/preempt, xen: Use need_resched() instead of should_resched()
Date: Mon, 3 Aug 2015 10:07:37 -0700	[thread overview]
Message-ID: <tip-0fa2f5cb2b0ecd8d56baa51f35f09aab234eb0bf@git.kernel.org> (raw)
In-Reply-To: <20150715095201.12246.49283.stgit@buzz>

Commit-ID:  0fa2f5cb2b0ecd8d56baa51f35f09aab234eb0bf
Gitweb:     http://git.kernel.org/tip/0fa2f5cb2b0ecd8d56baa51f35f09aab234eb0bf
Author:     Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
AuthorDate: Wed, 15 Jul 2015 12:52:01 +0300
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Mon, 3 Aug 2015 12:21:23 +0200

sched/preempt, xen: Use need_resched() instead of should_resched()

This code is used only when CONFIG_PREEMPT=n and only in non-atomic context:
xen_in_preemptible_hcall is set only in privcmd_ioctl_hypercall().
Thus preempt_count is zero and should_resched() is equal to need_resched().

Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Alexander Graf <agraf@suse.de>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: David Vrabel <david.vrabel@citrix.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20150715095201.12246.49283.stgit@buzz
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 drivers/xen/preempt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/preempt.c b/drivers/xen/preempt.c
index a1800c1..08cb419 100644
--- a/drivers/xen/preempt.c
+++ b/drivers/xen/preempt.c
@@ -31,7 +31,7 @@ EXPORT_SYMBOL_GPL(xen_in_preemptible_hcall);
 asmlinkage __visible void xen_maybe_preempt_hcall(void)
 {
 	if (unlikely(__this_cpu_read(xen_in_preemptible_hcall)
-		     && should_resched())) {
+		     && need_resched())) {
 		/*
 		 * Clear flag as we may be rescheduled on a different
 		 * cpu.

      parent reply	other threads:[~2015-08-03 17:08 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15  9:52 [PATCH v2 1/3] drivers/xen/preempt: use need_resched() instead of should_resched() Konstantin Khlebnikov
2015-07-15  9:52 ` Konstantin Khlebnikov
2015-07-15  9:52 ` [PATCH v2 2/3] KVM: PPC: Book3S HV: Use " Konstantin Khlebnikov
2015-07-15  9:52   ` Konstantin Khlebnikov
2015-08-03 17:08   ` [tip:sched/core] sched/preempt, powerpc, kvm: " tip-bot for Konstantin Khlebnikov
2015-07-15  9:52 ` [PATCH v2 2/3] KVM: PPC: Book3S HV: " Konstantin Khlebnikov
2015-07-15  9:52 ` [PATCH v2 3/3] sched/preempt: fix cond_resched_lock() and cond_resched_softirq() Konstantin Khlebnikov
2015-07-15  9:52 ` Konstantin Khlebnikov
2015-07-15  9:52   ` Konstantin Khlebnikov
2015-07-15 12:16   ` Eric Dumazet
2015-07-15 12:16     ` Eric Dumazet
2015-07-15 12:52     ` Konstantin Khlebnikov
2015-07-15 12:52     ` Konstantin Khlebnikov
2015-07-15 12:52       ` Konstantin Khlebnikov
2015-07-15 13:35       ` Peter Zijlstra
2015-07-15 13:35         ` Peter Zijlstra
2015-07-15 13:35       ` Peter Zijlstra
2015-07-15 12:16   ` Eric Dumazet
2015-08-03 17:08   ` [tip:sched/core] sched/preempt: Fix " tip-bot for Konstantin Khlebnikov
2015-07-20 13:41 ` [PATCH v2 1/3] drivers/xen/preempt: use need_resched() instead of should_resched() David Vrabel
2015-07-20 13:41 ` [Xen-devel] " David Vrabel
2015-07-20 13:41   ` David Vrabel
2015-07-20 13:41   ` David Vrabel
2015-08-03 17:07 ` tip-bot for Konstantin Khlebnikov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-0fa2f5cb2b0ecd8d56baa51f35f09aab234eb0bf@git.kernel.org \
    --to=tipbot@zytor.com \
    --cc=agraf@suse.de \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=efault@gmx.de \
    --cc=hpa@zytor.com \
    --cc=khlebnikov@yandex-team.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.