From: tip-bot for Namhyung Kim <namhyung@kernel.org>
To: linux-tip-commits@vger.kernel.org
Cc: acme@redhat.com, linux-kernel@vger.kernel.org, hpa@zytor.com,
mingo@kernel.org, drjones@redhat.com, tglx@linutronix.de,
namhyung@kernel.org
Subject: [tip:perf/urgent] perf header: Fix numa topology printing
Date: Tue, 13 Nov 2012 22:27:10 -0800 [thread overview]
Message-ID: <tip-1234471e2d11e4ee47f6de452dd8b8aeb09b45de@git.kernel.org> (raw)
In-Reply-To: <1350999890-6920-1-git-send-email-namhyung@kernel.org>
Commit-ID: 1234471e2d11e4ee47f6de452dd8b8aeb09b45de
Gitweb: http://git.kernel.org/tip/1234471e2d11e4ee47f6de452dd8b8aeb09b45de
Author: Namhyung Kim <namhyung@kernel.org>
AuthorDate: Tue, 23 Oct 2012 22:44:49 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 30 Oct 2012 10:32:55 -0200
perf header: Fix numa topology printing
Andrew reported that the commit 7e94cfcc9d20 ("perf header: Use pre-
processed session env when printing") regresses the header output. It
was because of a missed string pointer calculation in the loop.
Reported-by: Andrew Jones <drjones@redhat.com>
Tested-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Andrew Jones <drjones@redhat.com>
Link: http://lkml.kernel.org/r/1350999890-6920-1-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
| 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
--git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 7daad23..566b84c 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -1378,6 +1378,8 @@ static void print_numa_topology(struct perf_header *ph, int fd __maybe_unused,
str = tmp + 1;
fprintf(fp, "# node%u cpu list : %s\n", c, str);
+
+ str += strlen(str) + 1;
}
return;
error:
prev parent reply other threads:[~2012-11-14 6:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 13:11 perf: header: Regression Andrew Jones
2012-10-23 2:07 ` Namhyung Kim
2012-10-23 7:27 ` Andrew Jones
2012-10-23 13:44 ` [PATCH 1/2] perf header: Fix numa topology printing Namhyung Kim
2012-10-23 13:44 ` [PATCH 2/2] perf tools: Fix strbuf_addf() when the buffer needs to grow Namhyung Kim
2012-10-24 7:49 ` Andrew Jones
2012-11-14 6:28 ` [tip:perf/urgent] " tip-bot for Namhyung Kim
2012-10-23 14:12 ` [PATCH 1/2] perf header: Fix numa topology printing Andrew Jones
2012-10-24 7:00 ` Namhyung Kim
2012-10-24 7:49 ` Andrew Jones
2012-10-29 15:17 ` Namhyung Kim
2012-11-14 6:27 ` tip-bot for Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-1234471e2d11e4ee47f6de452dd8b8aeb09b45de@git.kernel.org \
--to=namhyung@kernel.org \
--cc=acme@redhat.com \
--cc=drjones@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.