From: tip-bot for Namhyung Kim <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: namhyung@kernel.org, mingo@kernel.org, jolsa@kernel.org,
markus@trippelsdorf.de, acme@redhat.com, hpa@zytor.com,
linux-kernel@vger.kernel.org, peterz@infradead.org,
tglx@linutronix.de
Subject: [tip:perf/urgent] perf hists browser: Show folded sign properly on --hierarchy
Date: Sat, 12 Nov 2016 02:53:38 -0800 [thread overview]
Message-ID: <tip-131d51eb1d17aac3a604cf929fd99ff4dd34f495@git.kernel.org> (raw)
In-Reply-To: <20161108130833.9263-3-namhyung@kernel.org>
Commit-ID: 131d51eb1d17aac3a604cf929fd99ff4dd34f495
Gitweb: http://git.kernel.org/tip/131d51eb1d17aac3a604cf929fd99ff4dd34f495
Author: Namhyung Kim <namhyung@kernel.org>
AuthorDate: Tue, 8 Nov 2016 22:08:31 +0900
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 9 Nov 2016 11:30:47 -0300
perf hists browser: Show folded sign properly on --hierarchy
When horizontal scrolling is used in hierarchy mode, the folded signed
disappears at the right most column.
Committer note:
To test it, run 'perf top --hierarchy, see the '+' symbol at the first
column, then press the right arrow key, the '+' symbol will disappear,
this patch fixes that.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Tested-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20161108130833.9263-3-namhyung@kernel.org
[ Move 'width -= 2' invariant to right after the if/else ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/ui/browsers/hists.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index 225ef2a..e767fbd 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -1381,7 +1381,13 @@ static int hist_browser__show_hierarchy_entry(struct hist_browser *browser,
}
perf_hpp_list__for_each_format(entry->hpp_list, fmt) {
- ui_browser__write_nstring(&browser->b, "", 2);
+ if (first) {
+ ui_browser__printf(&browser->b, "%c ", folded_sign);
+ first = false;
+ } else {
+ ui_browser__write_nstring(&browser->b, "", 2);
+ }
+
width -= 2;
/*
next prev parent reply other threads:[~2016-11-12 21:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 13:08 [PATCH 0/4] perf tools: Assorted fixes for hierarchy mode Namhyung Kim
2016-11-08 13:08 ` [PATCH 1/4] perf hist browser: Fix indentation of folded sign on --hierarchy Namhyung Kim
2016-11-12 10:53 ` [tip:perf/urgent] perf hists " tip-bot for Namhyung Kim
2016-11-08 13:08 ` [PATCH 2/4] perf hist browser: Show folded sign properly " Namhyung Kim
2016-11-09 14:28 ` Arnaldo Carvalho de Melo
2016-11-09 14:29 ` Arnaldo Carvalho de Melo
2016-11-12 10:53 ` tip-bot for Namhyung Kim [this message]
2016-11-08 13:08 ` [PATCH 3/4] perf hist browser: Fix column indentation " Namhyung Kim
2016-11-09 14:45 ` Arnaldo Carvalho de Melo
2016-11-12 10:54 ` [tip:perf/urgent] perf hists " tip-bot for Namhyung Kim
2016-11-08 13:08 ` [PATCH 4/4] perf hists: Fix column length " Namhyung Kim
2016-11-12 10:54 ` [tip:perf/urgent] " tip-bot for Namhyung Kim
2016-11-08 13:21 ` [PATCH 0/4] perf tools: Assorted fixes for hierarchy mode Markus Trippelsdorf
2016-11-09 13:11 ` Arnaldo Carvalho de Melo
2016-11-09 13:15 ` Markus Trippelsdorf
2016-11-08 13:43 ` Markus Trippelsdorf
2016-11-08 15:05 ` Namhyung Kim
2016-11-08 15:10 ` Markus Trippelsdorf
2016-11-09 13:10 ` Arnaldo Carvalho de Melo
2016-11-09 13:15 ` Markus Trippelsdorf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-131d51eb1d17aac3a604cf929fd99ff4dd34f495@git.kernel.org \
--to=tipbot@zytor.com \
--cc=acme@redhat.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.